You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2025/04/28 10:03:12 UTC

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22826


Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................

IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

bin/dump-stacktraces.sh collects pstack and jstack of the cluster. It's
used when some tests time out. Collecting pstacks might take long and
fail in the middle, causing jstacks not being collected. This changes
the script to collect jstacks first.

Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
---
M bin/dump-stacktraces.sh
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/22826/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/22826 )

Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22826/1/bin/dump-stacktraces.sh
File bin/dump-stacktraces.sh:

http://gerrit.cloudera.org:8080/#/c/22826/1/bin/dump-stacktraces.sh@46
PS1, Line 46:   collect_jstacks impalad $pid && collect_gdb_backtraces impalad $pid &
Would it be better to background these individually?



-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 01:41:02 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22826 )

Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22826/1/bin/dump-stacktraces.sh
File bin/dump-stacktraces.sh:

http://gerrit.cloudera.org:8080/#/c/22826/1/bin/dump-stacktraces.sh@30
PS1, Line 30: thread apply all -c
> thread apply all has a "-c" option to continue past an error. Here is the d
Good point!



-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 02:26:28 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22826 )

Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Apr 2025 17:55:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22826 )

Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 09:41:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22826 )

Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................


Patch Set 1:

(1 comment)

In addition to the change in logic, we might be able to make the gdb piece more fault tolerant.

http://gerrit.cloudera.org:8080/#/c/22826/1/bin/dump-stacktraces.sh
File bin/dump-stacktraces.sh:

http://gerrit.cloudera.org:8080/#/c/22826/1/bin/dump-stacktraces.sh@30
PS1, Line 30: thread apply all bt
thread apply all has a "-c" option to continue past an error. Here is the description from "help thread apply all":

By default, an error raised during the execution of COMMAND
aborts "thread apply".
...
  -c
    Print any error raised by COMMAND and continue.



-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 01:45:44 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22826 )

Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22826/1/bin/dump-stacktraces.sh
File bin/dump-stacktraces.sh:

http://gerrit.cloudera.org:8080/#/c/22826/1/bin/dump-stacktraces.sh@46
PS1, Line 46:   collect_jstacks impalad $pid && collect_gdb_backtraces impalad $pid &
> Would it be better to background these individually?
They will both pause the process so can't run in parallel.



-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 01:44:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Kurt Deschler, Riza Suminto, Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22826

to look at the new patch set (#2).

Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................

IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

bin/dump-stacktraces.sh collects pstack and jstack of the cluster. It's
used when some tests time out. Collecting pstacks might take long and
fail in the middle, causing jstacks not being collected. This changes
the script to collect jstacks first.

Also adds -c to the "thread apply all bt" gdb command to continue past
an error.

Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
---
M bin/dump-stacktraces.sh
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/22826/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22826 )

Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11843/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 12:10:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22826 )

Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19119/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 02:55:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22826 )

Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 18:24:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22826 )

Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19039/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Apr 2025 10:29:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22826 )

Change subject: IMPALA-14000: Dump jstacks first in dump-stacktraces.sh
......................................................................

IMPALA-14000: Dump jstacks first in dump-stacktraces.sh

bin/dump-stacktraces.sh collects pstack and jstack of the cluster. It's
used when some tests time out. Collecting pstacks might take long and
fail in the middle, causing jstacks not being collected. This changes
the script to collect jstacks first.

Also adds -c to the "thread apply all bt" gdb command to continue past
an error.

Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Reviewed-on: http://gerrit.cloudera.org:8080/22826
Reviewed-by: Daniel Becker <da...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/dump-stacktraces.sh
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Daniel Becker: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f610ee4d4934fe950a9f56cf74a7e76e5d63651
Gerrit-Change-Number: 22826
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>