You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "jeyhunkarimov (via GitHub)" <gi...@apache.org> on 2024/03/13 21:23:03 UTC

[PR] [FLINK-34640][metrics] Replace DummyMetricGroup usage with UnregisteredMetricsGroup [flink]

jeyhunkarimov opened a new pull request, #24490:
URL: https://github.com/apache/flink/pull/24490

   ## What is the purpose of the change
   
   Replace DummyMetricGroup usage with UnregisteredMetricsGroup
   
   ## Brief change log
   
   *(for example:)*
     - Remove DummyMetricGroup and replace it with UnregisteredMetricsGroup
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34640][metrics] Replace DummyMetricGroup usage with UnregisteredMetricsGroup [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24490:
URL: https://github.com/apache/flink/pull/24490#issuecomment-1995888995

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "39a6d1928dc2fbaa1de123871b7537c92a03af45",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "39a6d1928dc2fbaa1de123871b7537c92a03af45",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 39a6d1928dc2fbaa1de123871b7537c92a03af45 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34640][metrics] Replace DummyMetricGroup usage with UnregisteredMetricsGroup [flink]

Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe merged PR #24490:
URL: https://github.com/apache/flink/pull/24490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34640][metrics] Replace DummyMetricGroup usage with UnregisteredMetricsGroup [flink]

Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe commented on PR #24490:
URL: https://github.com/apache/flink/pull/24490#issuecomment-1996136921

   The PR is fine. Let's wait until the CI is passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34640][metrics] Replace DummyMetricGroup usage with UnregisteredMetricsGroup [flink]

Posted by "jeyhunkarimov (via GitHub)" <gi...@apache.org>.
jeyhunkarimov commented on PR #24490:
URL: https://github.com/apache/flink/pull/24490#issuecomment-1995999503

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34640][metrics] Replace DummyMetricGroup usage with UnregisteredMetricsGroup [flink]

Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe commented on PR #24490:
URL: https://github.com/apache/flink/pull/24490#issuecomment-1996133377

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org