[jira] [Commented] (CB-8669) Always use setters to fix memory issues without ARC

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-8669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966046#comment-14966046 ] 

ASF GitHub Bot commented on CB-8669:
------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-file/pull/104


> Always use setters to fix memory issues without ARC
> ---------------------------------------------------
>
>                 Key: CB-8669
>                 URL: https://issues.apache.org/jira/browse/CB-8669
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File
>            Reporter: Olivier Louvignes
>
> https://github.com/apache/cordova-plugin-file/pull/104
> Encountered memory issues with a non-ARC project (cordova+unity3d). Setter should be used to prevent memory issues, eg:
> A synthesized retained setter looks like :
> {code}
> - (void)setValue: (id)newValue
> {
>     if (value != newValue)
>     {
>         [value release];
>         value = newValue;
>         [value retain];
>     }
> } 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org