You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/08/28 06:45:09 UTC
[GitHub] [incubator-pekko] He-Pin opened a new pull request, #592: Update the javafmt version and reformat
He-Pin opened a new pull request, #592:
URL: https://github.com/apache/incubator-pekko/pull/592
I always need to do manual revert after running a local test, so I think it better to reformat it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #592: Update the javafmt version and reformat
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #592:
URL: https://github.com/apache/incubator-pekko/pull/592#issuecomment-1695305748
@mdedetrich Do it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin closed pull request #592: Update the javafmt version and reformat
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed pull request #592: Update the javafmt version and reformat
URL: https://github.com/apache/incubator-pekko/pull/592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #592: Update the javafmt version and reformat
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #592:
URL: https://github.com/apache/incubator-pekko/pull/592#issuecomment-1695299589
@mdedetrich Maybe I'm using windows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #592: Update the javafmt version and reformat
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #592:
URL: https://github.com/apache/incubator-pekko/pull/592#issuecomment-1695279613
@He-Pin The code format check is still failing, did you format all files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin closed pull request #592: Update the javafmt version and reformat
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed pull request #592: Update the javafmt version and reformat
URL: https://github.com/apache/incubator-pekko/pull/592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #592: Update the javafmt version and reformat
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #592:
URL: https://github.com/apache/incubator-pekko/pull/592#issuecomment-1695300865
@He-Pin Should I recreate the PR myself? I will give you credit via `Co-Authored-By`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org