You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mxnet.apache.org by Lin Yuan <ap...@gmail.com> on 2018/11/06 18:09:07 UTC

[DISCUSS] Speedup non-code PR in CI

Dear Community,

I recently submitted a few small PRs with only changes in README files.
However, I noticed they still triggered the full cycle of CI including
build and test on all platforms.

Do we have a plan to speed up this process, maybe skipping non-code related
PRs in CI? Sorry, if this topic has been raised earlier and if not I
appreciate any comments.

Cheers,

Lin

Re: [DISCUSS] Speedup non-code PR in CI

Posted by Anton Chernov <me...@gmail.com>.
Hi Lin,

thanks for your suggestion. I think it makes total sense. The triggering
logic of the verification build is in the Jenkinsfile [1]. We would be
happy if you could drive this and introduce a PR that implements this check.

Best
Anton

[1] https://github.com/apache/incubator-mxnet/blob/master/Jenkinsfile

вт, 6 нояб. 2018 г. в 20:55, Lin Yuan <ap...@gmail.com>:

> Kellen and Pedro,
>
> Thanks for your pointers. I am not an expert in CI but one naive speedup I
> can see is that if the PR only contains *.md file, then skip the build and
> testing cycles. This can make documentation/correction easier and save
> computation resource for other needed tests. Any side effect there?
>
> Thanks,
>
> Lin
>

Re: [DISCUSS] Speedup non-code PR in CI

Posted by Lin Yuan <ap...@gmail.com>.
Kellen and Pedro,

Thanks for your pointers. I am not an expert in CI but one naive speedup I
can see is that if the PR only contains *.md file, then skip the build and
testing cycles. This can make documentation/correction easier and save
computation resource for other needed tests. Any side effect there?

Thanks,

Lin

Re: [DISCUSS] Speedup non-code PR in CI

Posted by kellen sunderland <ke...@gmail.com>.
There's some documentation summarizing what we've discussed in the past on
this site:
https://cwiki.apache.org/confluence/display/MXNET/CI+Runtime+Improvements

On Tue, Nov 6, 2018 at 10:56 AM Pedro Larroy <pe...@gmail.com>
wrote:

> It has been raised but there are practical complications about introducing
> an additional layer of logic for skipping CI in some scenarios.
>
> How many of these PRs do we have which will justify investing human effort
> on optimizing an automated process?
> How much effort shall it be dedicated to this logic that can be invested
> somewhere else?
>
> If you have a proposal, you are welcome to explain.
>
> Pedro.
>
> On Tue, Nov 6, 2018 at 7:09 PM Lin Yuan <ap...@gmail.com> wrote:
>
> > Dear Community,
> >
> > I recently submitted a few small PRs with only changes in README files.
> > However, I noticed they still triggered the full cycle of CI including
> > build and test on all platforms.
> >
> > Do we have a plan to speed up this process, maybe skipping non-code
> related
> > PRs in CI? Sorry, if this topic has been raised earlier and if not I
> > appreciate any comments.
> >
> > Cheers,
> >
> > Lin
> >
>

Re: [DISCUSS] Speedup non-code PR in CI

Posted by Pedro Larroy <pe...@gmail.com>.
It has been raised but there are practical complications about introducing
an additional layer of logic for skipping CI in some scenarios.

How many of these PRs do we have which will justify investing human effort
on optimizing an automated process?
How much effort shall it be dedicated to this logic that can be invested
somewhere else?

If you have a proposal, you are welcome to explain.

Pedro.

On Tue, Nov 6, 2018 at 7:09 PM Lin Yuan <ap...@gmail.com> wrote:

> Dear Community,
>
> I recently submitted a few small PRs with only changes in README files.
> However, I noticed they still triggered the full cycle of CI including
> build and test on all platforms.
>
> Do we have a plan to speed up this process, maybe skipping non-code related
> PRs in CI? Sorry, if this topic has been raised earlier and if not I
> appreciate any comments.
>
> Cheers,
>
> Lin
>