You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/29 05:30:00 UTC

[GitHub] [arrow] jorgecarleitao commented on pull request #8546: ARROW-10413: [Rust] [Parquet] Unignore some tests that are passing now

jorgecarleitao commented on pull request #8546:
URL: https://github.com/apache/arrow/pull/8546#issuecomment-718369211


   > > Cool improvements here. Thanks a lot for taking them on! I left some comments on the code.
   > > My main concern is the `PartialEq for ArrayData`, which IMO is not correct. All other comments are smaller improvements..
   > 
   > Once rebased, this PR only removes 3 or 4 `#[ignore]`s in the parquet tests
   
   Yeah, when I reviewed these, I though that the writer branch was still not merged in master, and thus ended up reviewing everything. My bad there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org