You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "stataru8 (via GitHub)" <gi...@apache.org> on 2024/07/22 10:20:14 UTC
[PR] Repair camel-azure-storage-blob dependencies [camel-karaf]
stataru8 opened a new pull request, #460:
URL: https://github.com/apache/camel-karaf/pull/460
Fixes https://github.com/apache/camel-karaf/issues/455
- group the azure-msal4j dependencies into a feature
- bump up `azure-storage-common-version`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Repair camel-azure-storage-blob dependencies [camel-karaf]
Posted by "stataru8 (via GitHub)" <gi...@apache.org>.
stataru8 commented on code in PR #460:
URL: https://github.com/apache/camel-karaf/pull/460#discussion_r1686323182
##########
pom.xml:
##########
@@ -537,7 +537,7 @@
<azure-messaging-eventhubs-checkpointstore-blob-version>1.19.5
</azure-messaging-eventhubs-checkpointstore-blob-version>
<azure-messaging-eventhubs-version>5.18.5</azure-messaging-eventhubs-version>
- <azure-storage-common-version>12.25.1</azure-storage-common-version>
+ <azure-storage-common-version>12.26.0-beta.1</azure-storage-common-version>
Review Comment:
We have
```
<bundle dependency='true'>wrap:mvn:com.azure/azure-storage-blob/${auto-detect-version}</bundle>
<bundle dependency='true'>wrap:mvn:com.azure/azure-storage-blob-changefeed/${azure-storage-blob-changefeed-version}</bundle>
```
[${azure-storage-blob-changefeed-version} is 12.0.0-beta.22](https://github.com/apache/camel-karaf/blob/b9692f085afa8908118257e52cc213440ce705f2/pom.xml#L118): this will trigger the auto detect plugin to pick up `com.azure/azure-storage-blob/12.27.0-beta.1` (instead of 12.26.1) which then requires `mvn:com.azure/azure-storage-common/12.26.0-beta.1` (instead of [12.25.1 from ${azure-storage-common-version}](https://github.com/apache/camel-karaf/blob/b9692f085afa8908118257e52cc213440ce705f2/pom.xml#L540) )
ref: https://central.sonatype.com/artifact/com.azure/azure-storage-blob-changefeed/12.0.0-beta.22
This will lead to ClassNotFoundException because of missing `StorageBearerTokenChallengeAuthorizationPolicy`
`12.25.1`: [https://github.com/Azure/azure-sdk-for-java/tree/azure-storage-common_12.25.1/sdk/[…]re-storage-common/src/main/java/com/azure/storage/common/policy](https://github.com/Azure/azure-sdk-for-java/tree/azure-storage-common_12.25.1/sdk/storage/azure-storage-common/src/main/java/com/azure/storage/common/policy)
`12.26.0-beta.1`: [https://github.com/Azure/azure-sdk-for-java/tree/azure-storage-common_12.26.0-beta[…]re-storage-common/src/main/java/com/azure/storage/common/policy](https://github.com/Azure/azure-sdk-for-java/tree/azure-storage-common_12.26.0-beta.1/sdk/storage/azure-storage-common/src/main/java/com/azure/storage/common/policy)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Repair camel-azure-storage-blob dependencies [camel-karaf]
Posted by "stataru8 (via GitHub)" <gi...@apache.org>.
stataru8 commented on code in PR #460:
URL: https://github.com/apache/camel-karaf/pull/460#discussion_r1686330865
##########
features/src/main/feature/camel-features.xml:
##########
@@ -193,16 +193,28 @@
<bundle dependency='true'>mvn:org.reactivestreams/reactive-streams/${reactive-streams-version}</bundle>
</feature>
<feature name="azure" version="${azure-core-version}" start-level="50">
+ <feature version='[${azure-core-version},2)'>azure-msal4j</feature>
<feature version='${camel-osgi-jackson2-version}'>jackson</feature>
<bundle dependency='true'>mvn:com.fasterxml.jackson.dataformat/jackson-dataformat-xml/${jackson2-version}</bundle>
<bundle dependency='true'>mvn:com.fasterxml.jackson.datatype/jackson-datatype-jsr310/${jackson2-version}</bundle>
<bundle dependency='true'>wrap:mvn:com.azure/azure-core/${azure-core-version}$${spi-consumer}&Import-Package=*;resolution:=optional,com.fasterxml.jackson.dataformat.xml.deser;resolution:=optional,com.fasterxml.jackson.dataformat.xml.ser;resolution:=optional</bundle>
- <bundle dependency='true'>wrap:mvn:com.azure/azure-identity/${azure-identity-version}</bundle>
- <bundle dependency='true'>mvn:org.reactivestreams/reactive-streams/${reactive-streams-version}</bundle>
+ <bundle dependency='true'>wrap:mvn:com.azure/azure-identity/${azure-identity-version}$Import-Package=com.sun.jna,*;resolution:=optional</bundle>
Review Comment:
this is to fix the following ClassNotFoundException, which is thrown even when the bundle is present
```
Caused by: java.lang.ClassNotFoundException: com.sun.jna.Platform not found by wrap_file__C__Users_stataru_.m2_repository_com_azure_azure-identity_1.13.0_azure-identity-1.13.
0.jar_Bundle-Version_1.13.0 [197]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Repair camel-azure-storage-blob dependencies [camel-karaf]
Posted by "stataru8 (via GitHub)" <gi...@apache.org>.
stataru8 commented on code in PR #460:
URL: https://github.com/apache/camel-karaf/pull/460#discussion_r1686928850
##########
pom.xml:
##########
@@ -537,7 +537,7 @@
<azure-messaging-eventhubs-checkpointstore-blob-version>1.19.5
</azure-messaging-eventhubs-checkpointstore-blob-version>
<azure-messaging-eventhubs-version>5.18.5</azure-messaging-eventhubs-version>
- <azure-storage-common-version>12.25.1</azure-storage-common-version>
+ <azure-storage-common-version>12.26.0-beta.1</azure-storage-common-version>
Review Comment:
Ok, I've added `azure-storage-blob-version` to the pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Repair camel-azure-storage-blob dependencies [camel-karaf]
Posted by "f2par0 (via GitHub)" <gi...@apache.org>.
f2par0 commented on code in PR #460:
URL: https://github.com/apache/camel-karaf/pull/460#discussion_r1686533580
##########
pom.xml:
##########
@@ -537,7 +537,7 @@
<azure-messaging-eventhubs-checkpointstore-blob-version>1.19.5
</azure-messaging-eventhubs-checkpointstore-blob-version>
<azure-messaging-eventhubs-version>5.18.5</azure-messaging-eventhubs-version>
- <azure-storage-common-version>12.25.1</azure-storage-common-version>
+ <azure-storage-common-version>12.26.0-beta.1</azure-storage-common-version>
Review Comment:
If you keep 1.25.1 for azure-storage-common-version and force 12.26.1 for azure-storage-blob-version , it should fix the missing `StorageBearerTokenChallengeAuthorizationPolicy` class ?
I think the ${auto-detect-version} is going a little bit to far in the version update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Repair camel-azure-storage-blob dependencies [camel-karaf]
Posted by "stataru8 (via GitHub)" <gi...@apache.org>.
stataru8 commented on code in PR #460:
URL: https://github.com/apache/camel-karaf/pull/460#discussion_r1686928850
##########
pom.xml:
##########
@@ -537,7 +537,7 @@
<azure-messaging-eventhubs-checkpointstore-blob-version>1.19.5
</azure-messaging-eventhubs-checkpointstore-blob-version>
<azure-messaging-eventhubs-version>5.18.5</azure-messaging-eventhubs-version>
- <azure-storage-common-version>12.25.1</azure-storage-common-version>
+ <azure-storage-common-version>12.26.0-beta.1</azure-storage-common-version>
Review Comment:
Yes, it fixes the missing `StorageBearerTokenChallengeAuthorizationPolicy` class
I've added `azure-storage-blob-version` to the pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Repair camel-azure-storage-blob dependencies [camel-karaf]
Posted by "stataru8 (via GitHub)" <gi...@apache.org>.
stataru8 commented on code in PR #460:
URL: https://github.com/apache/camel-karaf/pull/460#discussion_r1686330865
##########
features/src/main/feature/camel-features.xml:
##########
@@ -193,16 +193,28 @@
<bundle dependency='true'>mvn:org.reactivestreams/reactive-streams/${reactive-streams-version}</bundle>
</feature>
<feature name="azure" version="${azure-core-version}" start-level="50">
+ <feature version='[${azure-core-version},2)'>azure-msal4j</feature>
<feature version='${camel-osgi-jackson2-version}'>jackson</feature>
<bundle dependency='true'>mvn:com.fasterxml.jackson.dataformat/jackson-dataformat-xml/${jackson2-version}</bundle>
<bundle dependency='true'>mvn:com.fasterxml.jackson.datatype/jackson-datatype-jsr310/${jackson2-version}</bundle>
<bundle dependency='true'>wrap:mvn:com.azure/azure-core/${azure-core-version}$${spi-consumer}&Import-Package=*;resolution:=optional,com.fasterxml.jackson.dataformat.xml.deser;resolution:=optional,com.fasterxml.jackson.dataformat.xml.ser;resolution:=optional</bundle>
- <bundle dependency='true'>wrap:mvn:com.azure/azure-identity/${azure-identity-version}</bundle>
- <bundle dependency='true'>mvn:org.reactivestreams/reactive-streams/${reactive-streams-version}</bundle>
+ <bundle dependency='true'>wrap:mvn:com.azure/azure-identity/${azure-identity-version}$Import-Package=com.sun.jna,*;resolution:=optional</bundle>
Review Comment:
this is needed to fix:
```
Caused by: java.lang.ClassNotFoundException: com.sun.jna.Platform not found by wrap_file__C__Users_stataru_.m2_repository_com_azure_azure-identity_1.13.0_azure-identity-1.13.
0.jar_Bundle-Version_1.13.0 [197]
```
(it is thrown even when the bundle is present)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Repair camel-azure-storage-blob dependencies [camel-karaf]
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo merged PR #460:
URL: https://github.com/apache/camel-karaf/pull/460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Repair camel-azure-storage-blob dependencies [camel-karaf]
Posted by "stataru8 (via GitHub)" <gi...@apache.org>.
stataru8 commented on code in PR #460:
URL: https://github.com/apache/camel-karaf/pull/460#discussion_r1686330865
##########
features/src/main/feature/camel-features.xml:
##########
@@ -193,16 +193,28 @@
<bundle dependency='true'>mvn:org.reactivestreams/reactive-streams/${reactive-streams-version}</bundle>
</feature>
<feature name="azure" version="${azure-core-version}" start-level="50">
+ <feature version='[${azure-core-version},2)'>azure-msal4j</feature>
<feature version='${camel-osgi-jackson2-version}'>jackson</feature>
<bundle dependency='true'>mvn:com.fasterxml.jackson.dataformat/jackson-dataformat-xml/${jackson2-version}</bundle>
<bundle dependency='true'>mvn:com.fasterxml.jackson.datatype/jackson-datatype-jsr310/${jackson2-version}</bundle>
<bundle dependency='true'>wrap:mvn:com.azure/azure-core/${azure-core-version}$${spi-consumer}&Import-Package=*;resolution:=optional,com.fasterxml.jackson.dataformat.xml.deser;resolution:=optional,com.fasterxml.jackson.dataformat.xml.ser;resolution:=optional</bundle>
- <bundle dependency='true'>wrap:mvn:com.azure/azure-identity/${azure-identity-version}</bundle>
- <bundle dependency='true'>mvn:org.reactivestreams/reactive-streams/${reactive-streams-version}</bundle>
+ <bundle dependency='true'>wrap:mvn:com.azure/azure-identity/${azure-identity-version}$Import-Package=com.sun.jna,*;resolution:=optional</bundle>
Review Comment:
this is needed to fix
```
Caused by: java.lang.ClassNotFoundException: com.sun.jna.Platform not found by wrap_file__C__Users_stataru_.m2_repository_com_azure_azure-identity_1.13.0_azure-identity-1.13.
0.jar_Bundle-Version_1.13.0 [197]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Repair camel-azure-storage-blob dependencies [camel-karaf]
Posted by "stataru8 (via GitHub)" <gi...@apache.org>.
stataru8 commented on code in PR #460:
URL: https://github.com/apache/camel-karaf/pull/460#discussion_r1686327088
##########
pom.xml:
##########
@@ -537,7 +537,7 @@
<azure-messaging-eventhubs-checkpointstore-blob-version>1.19.5
</azure-messaging-eventhubs-checkpointstore-blob-version>
<azure-messaging-eventhubs-version>5.18.5</azure-messaging-eventhubs-version>
- <azure-storage-common-version>12.25.1</azure-storage-common-version>
+ <azure-storage-common-version>12.26.0-beta.1</azure-storage-common-version>
Review Comment:
Should I have added `azure-storage-blob-version` to the pom instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org