You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/29 17:56:19 UTC
[GitHub] [beam] damccorm commented on a diff in pull request #23076: GA Migration Go and GoPortable PreCommit
damccorm commented on code in PR #23076:
URL: https://github.com/apache/beam/pull/23076#discussion_r983849429
##########
.github/workflows/job-portable-precommit-go.yml:
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs Go Portable PreCommit scheduled on cron, on push to master and on pull request
+
+name: PreCommit Go Portable
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/go**', 'model/**', 'release/**']
+permissions: read-all
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: recursive
Review Comment:
We don't need submodules here.
##########
.github/workflows/job-precommit-go.yml:
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs Go PreCommit scheduled on cron, on push to master and on pull request
+
+name: PreCommit Go
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/go**', 'model/**', 'release/**']
+permissions: read-all
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: recursive
Review Comment:
Same, we don't need submodules here
##########
.github/workflows/job-precommit-go.yml:
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs Go PreCommit scheduled on cron, on push to master and on pull request
+
+name: PreCommit Go
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/go**', 'model/**', 'release/**']
+permissions: read-all
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: recursive
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ precommit-go:
Review Comment:
Out of scope here (and not part of the agreed upon work), but this job/workflow file is doing a very similar thing as the existing go tests workflow - https://github.com/apache/beam/blob/master/.github/workflows/go_tests.yml - this should eventually be refactored to be a single workflow.
FYI @lostluck - I filed https://github.com/apache/beam/issues/23424, but I may just pick this up when the time comes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org