You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/15 21:49:42 UTC

[GitHub] [airflow] ashb commented on a change in pull request #15395: Bugfix: ``TypeError`` when Serializing & sorting iterators

ashb commented on a change in pull request #15395:
URL: https://github.com/apache/airflow/pull/15395#discussion_r614413116



##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -252,6 +252,14 @@ def _serialize(cls, var: Any) -> Any:  # Unfortunately there is no support for r
 
     # pylint: enable=too-many-return-statements
 
+    @classmethod
+    def _serialize_and_sort(cls, var):
+        """Serialized and Sort the values in the iterator"""

Review comment:
       This is passed much more than just an iterator, so this comment needs updating/expanding please.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org