You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "wsjz (via GitHub)" <gi...@apache.org> on 2023/08/15 11:58:12 UTC
[GitHub] [doris] wsjz opened a new pull request, #23015: [fix](multi-catalog)fix avro and jdbc scanner dependency
wsjz opened a new pull request, #23015:
URL: https://github.com/apache/doris/pull/23015
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts [doris]
Posted by "hidataplus (via GitHub)" <gi...@apache.org>.
hidataplus commented on PR #23015:
URL: https://github.com/apache/doris/pull/23015#issuecomment-2051348121
what diffrents about "fe/fe-core/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java" and "fe/be-java-extensions/preload-extensions/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java",???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23015:
URL: https://github.com/apache/doris/pull/23015#issuecomment-1683937677
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #23015:
URL: https://github.com/apache/doris/pull/23015#issuecomment-1683856194
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] AshinGau commented on a diff in pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "AshinGau (via GitHub)" <gi...@apache.org>.
AshinGau commented on code in PR #23015:
URL: https://github.com/apache/doris/pull/23015#discussion_r1296837935
##########
fe/be-java-extensions/java-udf/pom.xml:
##########
@@ -47,6 +63,170 @@ under the License.
<artifactId>reflectasm</artifactId>
<version>1.11.9</version>
</dependency>
+ <dependency>
Review Comment:
Why add so many dependencies in java-udf?
##########
fe/pom.xml:
##########
@@ -1041,7 +1041,7 @@ under the License.
<groupId>org.apache.spark</groupId>
<artifactId>spark-core_2.12</artifactId>
<version>${spark.version}</version>
- <scope>provided</scope>
+ <scope>compile</scope>
Review Comment:
Why change the scope from `provided` to `compile`?
##########
fe/be-java-extensions/java-common/pom.xml:
##########
@@ -60,5 +60,29 @@ under the License.
<artifactId>jackson-databind</artifactId>
</dependency>
</dependencies>
-
+ <build>
+ <plugins>
Review Comment:
Why add scala plugin in java-common?
##########
fe/be-java-extensions/avro-scanner/pom.xml:
##########
@@ -41,16 +41,6 @@ under the License.
<artifactId>java-common</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
Review Comment:
Why remove avro dependency in avro-scanner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23015:
URL: https://github.com/apache/doris/pull/23015#issuecomment-1684745905
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.83 seconds
stream load tsv: 539 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162330278 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23015:
URL: https://github.com/apache/doris/pull/23015#issuecomment-1683651257
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.95 seconds
stream load tsv: 542 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162015008 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #23015:
URL: https://github.com/apache/doris/pull/23015#issuecomment-1683611755
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #23015:
URL: https://github.com/apache/doris/pull/23015#issuecomment-1684900719
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #23015:
URL: https://github.com/apache/doris/pull/23015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23015:
URL: https://github.com/apache/doris/pull/23015#issuecomment-1683891130
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.21 seconds
stream load tsv: 535 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17161912511 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23015:
URL: https://github.com/apache/doris/pull/23015#issuecomment-1684917107
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #23015:
URL: https://github.com/apache/doris/pull/23015#issuecomment-1683609087
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #23015:
URL: https://github.com/apache/doris/pull/23015#issuecomment-1683856093
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #23015: [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #23015:
URL: https://github.com/apache/doris/pull/23015#issuecomment-1684719140
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org