[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #5322: Support for Sliding Windows Joins with Symmetric Hash Join (SHJ)

["Dandandan (via GitHub)" <gi...@apache.org>]

Dandandan commented on code in PR #5322:
URL: https://github.com/apache/arrow-datafusion/pull/5322#discussion_r1111954855


##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -84,25 +84,25 @@ use super::{
 };
 use crate::physical_plan::joins::utils::{
     adjust_indices_by_join_type, apply_join_filter_to_indices, build_batch_from_indices,
-    get_final_indices_from_bit_map, need_produce_result_in_final,
+    get_final_indices_from_bit_map, need_produce_result_in_final, JoinSide,
 };
 use log::debug;
 use std::fmt;
 use std::task::Poll;
 
-// Maps a `u64` hash value based on the left ["on" values] to a list of indices with this key's value.
+// Maps a `u64` hash value based on the build side ["on" values] to a list of indices with this key's value.

Review Comment:
   I like the refactorings / renaming



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org