[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #5010: HADOOP-8728. Display (fs -text) shouldn't hard-depend on Writable serialized sequence files.

[GitBox <gi...@apache.org>]

ashutoshcipher commented on code in PR #5010:
URL: https://github.com/apache/hadoop/pull/5010#discussion_r994280180


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java:
##########
@@ -217,8 +216,8 @@ protected void processPath(PathData item) throws IOException {
 
   protected class TextRecordInputStream extends InputStream {
     SequenceFile.Reader r;
-    Writable key;
-    Writable val;
+    Object key;

Review Comment:
   Hi @goiri. Thanks for your review. 
   
   Currently - The Display command (fs -text) currently reads only Writable-based SequenceFiles. This isn't necessary to do, and prevents reading non-Writable-based serialization in SequenceFiles from the shell.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org