You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Puneet Gupta <pu...@gmail.com> on 2016/01/25 06:16:26 UTC

Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/
-----------------------------------------------------------

Review request for lens.


Bugs: lens-921
    https://issues.apache.org/jira/browse/lens-921


Repository: lens


Description
-------

Added a new server configration

+  <property>
+    <name>lens.server.inmemory.resultset.ttl.secs</name>
+    <value>300</value>
+    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
+     The default value is 300 seconds (5 minutes).
+     </description>
+  </property>


Diffs
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a 
  lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5 
  src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306 
  src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe 

Diff: https://reviews.apache.org/r/42703/diff/


Testing
-------

[INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
[INFO] Lens ............................................... SUCCESS [  5.054 s]
[INFO] Lens API ........................................... SUCCESS [ 12.519 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
[INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
[INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
[INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
[INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
[INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
[INFO] Lens client ........................................ SUCCESS [  6.583 s]
[INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
[INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
[INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
[INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
[INFO] Lens Regression .................................... SUCCESS [  4.283 s]
[INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:05 min
[INFO] Finished at: 2016-01-25T10:14:25+05:30
[INFO] Final Memory: 191M/1654M
[INFO] ------------------------------------------------------------------------


Added a new test case 
org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()


Thanks,

Puneet Gupta


Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/#review116066
-----------------------------------------------------------


Ship it!




Ship It!

- Rajat Khandelwal


On Jan. 25, 2016, 10:46 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42703/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 10:46 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-921
>     https://issues.apache.org/jira/browse/lens-921
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added a new server configration
> 
> +  <property>
> +    <name>lens.server.inmemory.resultset.ttl.secs</name>
> +    <value>300</value>
> +    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
> +     The default value is 300 seconds (5 minutes).
> +     </description>
> +  </property>
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a 
>   lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5 
>   src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306 
>   src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe 
> 
> Diff: https://reviews.apache.org/r/42703/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
> [INFO] Lens ............................................... SUCCESS [  5.054 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.519 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
> [INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
> [INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
> [INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
> [INFO] Lens client ........................................ SUCCESS [  6.583 s]
> [INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
> [INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
> [INFO] Lens Regression .................................... SUCCESS [  4.283 s]
> [INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:05 min
> [INFO] Finished at: 2016-01-25T10:14:25+05:30
> [INFO] Final Memory: 191M/1654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Added a new test case 
> org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>


Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

Posted by Puneet Gupta <pu...@gmail.com>.

> On Jan. 27, 2016, 11:47 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java, line 1026
> > <https://reviews.apache.org/r/42703/diff/2/?file=1222600#file1222600line1026>
> >
> >     Hope the test is not causing intermittent failures, when other tests run.

No faulires seen in 3 runs.


- Puneet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/#review116575
-----------------------------------------------------------


On Jan. 27, 2016, 9:32 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42703/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 9:32 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-921
>     https://issues.apache.org/jira/browse/lens-921
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added a new server configration
> 
> +  <property>
> +    <name>lens.server.inmemory.resultset.ttl.secs</name>
> +    <value>300</value>
> +    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
> +     The default value is 300 seconds (5 minutes).
> +     </description>
> +  </property>
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9af 
>   lens-server/src/main/resources/lensserver-default.xml cac641a 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5 
>   src/site/apt/admin/config.apt 54f827e 
>   src/site/apt/admin/session-config.apt 05a2c2c 
> 
> Diff: https://reviews.apache.org/r/42703/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
> [INFO] Lens ............................................... SUCCESS [  5.054 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.519 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
> [INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
> [INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
> [INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
> [INFO] Lens client ........................................ SUCCESS [  6.583 s]
> [INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
> [INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
> [INFO] Lens Regression .................................... SUCCESS [  4.283 s]
> [INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:05 min
> [INFO] Finished at: 2016-01-25T10:14:25+05:30
> [INFO] Final Memory: 191M/1654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Added a new test case 
> org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>


Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/#review116575
-----------------------------------------------------------




lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 1026)
<https://reviews.apache.org/r/42703/#comment177601>

    Hope the test is not causing intermittent failures, when other tests run.


- Amareshwari Sriramadasu


On Jan. 27, 2016, 9:32 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42703/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 9:32 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-921
>     https://issues.apache.org/jira/browse/lens-921
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added a new server configration
> 
> +  <property>
> +    <name>lens.server.inmemory.resultset.ttl.secs</name>
> +    <value>300</value>
> +    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
> +     The default value is 300 seconds (5 minutes).
> +     </description>
> +  </property>
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9af 
>   lens-server/src/main/resources/lensserver-default.xml cac641a 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5 
>   src/site/apt/admin/config.apt 54f827e 
>   src/site/apt/admin/session-config.apt 05a2c2c 
> 
> Diff: https://reviews.apache.org/r/42703/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
> [INFO] Lens ............................................... SUCCESS [  5.054 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.519 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
> [INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
> [INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
> [INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
> [INFO] Lens client ........................................ SUCCESS [  6.583 s]
> [INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
> [INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
> [INFO] Lens Regression .................................... SUCCESS [  4.283 s]
> [INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:05 min
> [INFO] Finished at: 2016-01-25T10:14:25+05:30
> [INFO] Final Memory: 191M/1654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Added a new test case 
> org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>


Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/#review116577
-----------------------------------------------------------




lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 992)
<https://reviews.apache.org/r/42703/#comment177602>

    Can we reduce it to 5 seconds?


- Amareshwari Sriramadasu


On Jan. 27, 2016, 9:32 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42703/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 9:32 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-921
>     https://issues.apache.org/jira/browse/lens-921
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added a new server configration
> 
> +  <property>
> +    <name>lens.server.inmemory.resultset.ttl.secs</name>
> +    <value>300</value>
> +    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
> +     The default value is 300 seconds (5 minutes).
> +     </description>
> +  </property>
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9af 
>   lens-server/src/main/resources/lensserver-default.xml cac641a 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5 
>   src/site/apt/admin/config.apt 54f827e 
>   src/site/apt/admin/session-config.apt 05a2c2c 
> 
> Diff: https://reviews.apache.org/r/42703/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
> [INFO] Lens ............................................... SUCCESS [  5.054 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.519 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
> [INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
> [INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
> [INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
> [INFO] Lens client ........................................ SUCCESS [  6.583 s]
> [INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
> [INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
> [INFO] Lens Regression .................................... SUCCESS [  4.283 s]
> [INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:05 min
> [INFO] Finished at: 2016-01-25T10:14:25+05:30
> [INFO] Final Memory: 191M/1654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Added a new test case 
> org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>


Re: Review Request 42703: Lens 921 - Clean unaccessed InMemoryResultSet intances form server

Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/
-----------------------------------------------------------

(Updated Feb. 1, 2016, 5:34 a.m.)


Review request for lens.


Summary (updated)
-----------------

Lens 921 - Clean unaccessed InMemoryResultSet intances form server


Bugs: lens-921
    https://issues.apache.org/jira/browse/lens-921


Repository: lens


Description
-------

Lens 921- Clean unaccessed InMemoryResultSet intances form server
	 	
Added a new server configration
Review comment fixed
+ <property>
+ <name>**lens.server.inmemory.resultset.ttl.secs**</name>
+ <value>300</value>
+ <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
The default value is 300 seconds (5 minutes).
+ </description>
+ </property>


Diffs
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 672f2bea36af4040e17d4d70b14ea0e1c773d5d9 
  lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded051fdd89bc9838ef2b60a91138fd40424 
  lens-server/src/test/resources/lens-site.xml 9cb4a6f6dcdce5522f9a37a2cb76e98699eecc56 
  src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306 
  src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe 

Diff: https://reviews.apache.org/r/42703/diff/


Testing
-------

[INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
[INFO] Lens ............................................... SUCCESS [  5.054 s]
[INFO] Lens API ........................................... SUCCESS [ 12.519 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
[INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
[INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
[INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
[INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
[INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
[INFO] Lens client ........................................ SUCCESS [  6.583 s]
[INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
[INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
[INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
[INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
[INFO] Lens Regression .................................... SUCCESS [  4.283 s]
[INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:05 min
[INFO] Finished at: 2016-01-25T10:14:25+05:30
[INFO] Final Memory: 191M/1654M
[INFO] ------------------------------------------------------------------------


Added a new test case 
org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()


Thanks,

Puneet Gupta


Re: Review Request 42703: bug fix

Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/
-----------------------------------------------------------

(Updated Feb. 1, 2016, 5:25 a.m.)


Review request for lens.


Bugs: lens-921
    https://issues.apache.org/jira/browse/lens-921


Repository: lens


Description (updated)
-------

Lens 921- Clean unaccessed InMemoryResultSet intances form server
	 	
Added a new server configration
Review comment fixed
+ <property>
+ <name>**lens.server.inmemory.resultset.ttl.secs**</name>
+ <value>300</value>
+ <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
The default value is 300 seconds (5 minutes).
+ </description>
+ </property>


Diffs
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 672f2bea36af4040e17d4d70b14ea0e1c773d5d9 
  lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded051fdd89bc9838ef2b60a91138fd40424 
  lens-server/src/test/resources/lens-site.xml 9cb4a6f6dcdce5522f9a37a2cb76e98699eecc56 
  src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306 
  src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe 

Diff: https://reviews.apache.org/r/42703/diff/


Testing
-------

[INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
[INFO] Lens ............................................... SUCCESS [  5.054 s]
[INFO] Lens API ........................................... SUCCESS [ 12.519 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
[INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
[INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
[INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
[INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
[INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
[INFO] Lens client ........................................ SUCCESS [  6.583 s]
[INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
[INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
[INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
[INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
[INFO] Lens Regression .................................... SUCCESS [  4.283 s]
[INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:05 min
[INFO] Finished at: 2016-01-25T10:14:25+05:30
[INFO] Final Memory: 191M/1654M
[INFO] ------------------------------------------------------------------------


Added a new test case 
org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()


Thanks,

Puneet Gupta


Re: Review Request 42703: bug fix

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/#review116940
-----------------------------------------------------------


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Jan. 29, 2016, 11:14 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42703/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 11:14 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-921
>     https://issues.apache.org/jira/browse/lens-921
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Review comment fixed
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 672f2bea36af4040e17d4d70b14ea0e1c773d5d9 
>   lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded051fdd89bc9838ef2b60a91138fd40424 
>   lens-server/src/test/resources/lens-site.xml 9cb4a6f6dcdce5522f9a37a2cb76e98699eecc56 
>   src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306 
>   src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe 
> 
> Diff: https://reviews.apache.org/r/42703/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
> [INFO] Lens ............................................... SUCCESS [  5.054 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.519 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
> [INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
> [INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
> [INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
> [INFO] Lens client ........................................ SUCCESS [  6.583 s]
> [INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
> [INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
> [INFO] Lens Regression .................................... SUCCESS [  4.283 s]
> [INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:05 min
> [INFO] Finished at: 2016-01-25T10:14:25+05:30
> [INFO] Final Memory: 191M/1654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Added a new test case 
> org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>


Re: Review Request 42703: bug fix

Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/
-----------------------------------------------------------

(Updated Jan. 29, 2016, 11:14 a.m.)


Review request for lens.


Changes
-------

Fixed review comment


Summary (updated)
-----------------

bug fix


Bugs: lens-921
    https://issues.apache.org/jira/browse/lens-921


Repository: lens


Description (updated)
-------

Review comment fixed


Diffs (updated)
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 672f2bea36af4040e17d4d70b14ea0e1c773d5d9 
  lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded051fdd89bc9838ef2b60a91138fd40424 
  lens-server/src/test/resources/lens-site.xml 9cb4a6f6dcdce5522f9a37a2cb76e98699eecc56 
  src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306 
  src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe 

Diff: https://reviews.apache.org/r/42703/diff/


Testing
-------

[INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
[INFO] Lens ............................................... SUCCESS [  5.054 s]
[INFO] Lens API ........................................... SUCCESS [ 12.519 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
[INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
[INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
[INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
[INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
[INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
[INFO] Lens client ........................................ SUCCESS [  6.583 s]
[INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
[INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
[INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
[INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
[INFO] Lens Regression .................................... SUCCESS [  4.283 s]
[INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:05 min
[INFO] Finished at: 2016-01-25T10:14:25+05:30
[INFO] Final Memory: 191M/1654M
[INFO] ------------------------------------------------------------------------


Added a new test case 
org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()


Thanks,

Puneet Gupta


Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/
-----------------------------------------------------------

(Updated Jan. 29, 2016, 9:50 a.m.)


Review request for lens.


Changes
-------

* Reduced test case time from 15 to 5 seconds
* Upadted purger sleep time for test cases from default 10 secs to 1 sec


Bugs: lens-921
    https://issues.apache.org/jira/browse/lens-921


Repository: lens


Description
-------

Added a new server configration

+  <property>
+    <name>lens.server.inmemory.resultset.ttl.secs</name>
+    <value>300</value>
+    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
+     The default value is 300 seconds (5 minutes).
+     </description>
+  </property>


Diffs (updated)
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 672f2be 
  lens-server/src/main/resources/lensserver-default.xml cac641a 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded 
  lens-server/src/test/resources/lens-site.xml 9cb4a6f 
  src/site/apt/admin/config.apt 54f827e 
  src/site/apt/admin/session-config.apt 05a2c2c 

Diff: https://reviews.apache.org/r/42703/diff/


Testing
-------

[INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
[INFO] Lens ............................................... SUCCESS [  5.054 s]
[INFO] Lens API ........................................... SUCCESS [ 12.519 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
[INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
[INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
[INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
[INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
[INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
[INFO] Lens client ........................................ SUCCESS [  6.583 s]
[INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
[INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
[INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
[INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
[INFO] Lens Regression .................................... SUCCESS [  4.283 s]
[INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:05 min
[INFO] Finished at: 2016-01-25T10:14:25+05:30
[INFO] Final Memory: 191M/1654M
[INFO] ------------------------------------------------------------------------


Added a new test case 
org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()


Thanks,

Puneet Gupta


Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/
-----------------------------------------------------------

(Updated Jan. 27, 2016, 9:32 a.m.)


Review request for lens.


Changes
-------

Fixed review comments


Bugs: lens-921
    https://issues.apache.org/jira/browse/lens-921


Repository: lens


Description
-------

Added a new server configration

+  <property>
+    <name>lens.server.inmemory.resultset.ttl.secs</name>
+    <value>300</value>
+    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
+     The default value is 300 seconds (5 minutes).
+     </description>
+  </property>


Diffs (updated)
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0 
  lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9af 
  lens-server/src/main/resources/lensserver-default.xml cac641a 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5 
  src/site/apt/admin/config.apt 54f827e 
  src/site/apt/admin/session-config.apt 05a2c2c 

Diff: https://reviews.apache.org/r/42703/diff/


Testing
-------

[INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
[INFO] Lens ............................................... SUCCESS [  5.054 s]
[INFO] Lens API ........................................... SUCCESS [ 12.519 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
[INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
[INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
[INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
[INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
[INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
[INFO] Lens client ........................................ SUCCESS [  6.583 s]
[INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
[INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
[INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
[INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
[INFO] Lens Regression .................................... SUCCESS [  4.283 s]
[INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:05 min
[INFO] Finished at: 2016-01-25T10:14:25+05:30
[INFO] Final Memory: 191M/1654M
[INFO] ------------------------------------------------------------------------


Added a new test case 
org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()


Thanks,

Puneet Gupta


Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/#review116068
-----------------------------------------------------------


Ship it!




Ship It!

- Rajat Khandelwal


On Jan. 25, 2016, 10:46 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42703/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 10:46 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-921
>     https://issues.apache.org/jira/browse/lens-921
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added a new server configration
> 
> +  <property>
> +    <name>lens.server.inmemory.resultset.ttl.secs</name>
> +    <value>300</value>
> +    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
> +     The default value is 300 seconds (5 minutes).
> +     </description>
> +  </property>
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a 
>   lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5 
>   src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306 
>   src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe 
> 
> Diff: https://reviews.apache.org/r/42703/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
> [INFO] Lens ............................................... SUCCESS [  5.054 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.519 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
> [INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
> [INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
> [INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
> [INFO] Lens client ........................................ SUCCESS [  6.583 s]
> [INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
> [INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
> [INFO] Lens Regression .................................... SUCCESS [  4.283 s]
> [INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:05 min
> [INFO] Finished at: 2016-01-25T10:14:25+05:30
> [INFO] Final Memory: 191M/1654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Added a new test case 
> org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>


Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

Posted by Puneet Gupta <pu...@gmail.com>.

> On Jan. 25, 2016, 12:29 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 281
> > <https://reviews.apache.org/r/42703/diff/1/?file=1219141#file1219141line281>
> >
> >     We should not be creating it as static value. Instead, we should read from init on service.

The value is being read form LensServerConf. Will make it non static so that its created (and possibly LensServerConf instance also) only when instance of QueryExecutionServiceImpl is created.


> On Jan. 25, 2016, 12:29 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 551
> > <https://reviews.apache.org/r/42703/diff/1/?file=1219141#file1219141line551>
> >
> >     Should we be calling a close on resultset? Oherwrise other resources like jdbc connection are cleared?

The Query Purging flow should take care of that. 

But another thing that gets enforced now is that any result of type InMemory should be consumable within 3 minutes , otherwise the reader will get closed result set exception since the query will get purged within 3 minutes. 

Should we increase the TTL to say 10 minutes So the reader has enough time to read all the rows of a big resultset?


- Puneet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/#review116080
-----------------------------------------------------------


On Jan. 25, 2016, 5:16 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42703/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 5:16 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-921
>     https://issues.apache.org/jira/browse/lens-921
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added a new server configration
> 
> +  <property>
> +    <name>lens.server.inmemory.resultset.ttl.secs</name>
> +    <value>300</value>
> +    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
> +     The default value is 300 seconds (5 minutes).
> +     </description>
> +  </property>
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a 
>   lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5 
>   src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306 
>   src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe 
> 
> Diff: https://reviews.apache.org/r/42703/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
> [INFO] Lens ............................................... SUCCESS [  5.054 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.519 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
> [INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
> [INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
> [INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
> [INFO] Lens client ........................................ SUCCESS [  6.583 s]
> [INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
> [INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
> [INFO] Lens Regression .................................... SUCCESS [  4.283 s]
> [INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:05 min
> [INFO] Finished at: 2016-01-25T10:14:25+05:30
> [INFO] Final Memory: 191M/1654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Added a new test case 
> org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>


Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

Posted by Puneet Gupta <pu...@gmail.com>.

> On Jan. 25, 2016, 12:29 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 551
> > <https://reviews.apache.org/r/42703/diff/1/?file=1219141#file1219141line551>
> >
> >     Should we be calling a close on resultset? Oherwrise other resources like jdbc connection are cleared?
> 
> Puneet Gupta wrote:
>     The Query Purging flow should take care of that. 
>     
>     But another thing that gets enforced now is that any result of type InMemory should be consumable within 3 minutes , otherwise the reader will get closed result set exception since the query will get purged within 3 minutes. 
>     
>     Should we increase the TTL to say 10 minutes So the reader has enough time to read all the rows of a big resultset?
> 
> Amareshwari Sriramadasu wrote:
>     I see default is 5 minutes and should be fine. Can you add comment about how closing of result sets is taken care?

As in when the QueryPurger thread runs , it calls a closeQuery() on the selected driver for the query to be purged.  This takes care of releasing the resources.
 finished.getCtx().getSelectedDriver().closeQuery(finished.getQueryHandle());


- Puneet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/#review116080
-----------------------------------------------------------


On Jan. 25, 2016, 5:16 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42703/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 5:16 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-921
>     https://issues.apache.org/jira/browse/lens-921
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added a new server configration
> 
> +  <property>
> +    <name>lens.server.inmemory.resultset.ttl.secs</name>
> +    <value>300</value>
> +    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
> +     The default value is 300 seconds (5 minutes).
> +     </description>
> +  </property>
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a 
>   lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5 
>   src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306 
>   src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe 
> 
> Diff: https://reviews.apache.org/r/42703/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
> [INFO] Lens ............................................... SUCCESS [  5.054 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.519 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
> [INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
> [INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
> [INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
> [INFO] Lens client ........................................ SUCCESS [  6.583 s]
> [INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
> [INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
> [INFO] Lens Regression .................................... SUCCESS [  4.283 s]
> [INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:05 min
> [INFO] Finished at: 2016-01-25T10:14:25+05:30
> [INFO] Final Memory: 191M/1654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Added a new test case 
> org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>


Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

Posted by Amareshwari Sriramadasu <am...@apache.org>.

> On Jan. 25, 2016, 12:29 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 281
> > <https://reviews.apache.org/r/42703/diff/1/?file=1219141#file1219141line281>
> >
> >     We should not be creating it as static value. Instead, we should read from init on service.
> 
> Puneet Gupta wrote:
>     The value is being read form LensServerConf. Will make it non static so that its created (and possibly LensServerConf instance also) only when instance of QueryExecutionServiceImpl is created.

Let us move it to get initialized from init() of the service instead of reading from static conf.


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/#review116080
-----------------------------------------------------------


On Jan. 29, 2016, 9:50 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42703/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 9:50 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-921
>     https://issues.apache.org/jira/browse/lens-921
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added a new server configration
> 
> +  <property>
> +    <name>lens.server.inmemory.resultset.ttl.secs</name>
> +    <value>300</value>
> +    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
> +     The default value is 300 seconds (5 minutes).
> +     </description>
> +  </property>
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 672f2be 
>   lens-server/src/main/resources/lensserver-default.xml cac641a 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded 
>   lens-server/src/test/resources/lens-site.xml 9cb4a6f 
>   src/site/apt/admin/config.apt 54f827e 
>   src/site/apt/admin/session-config.apt 05a2c2c 
> 
> Diff: https://reviews.apache.org/r/42703/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
> [INFO] Lens ............................................... SUCCESS [  5.054 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.519 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
> [INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
> [INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
> [INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
> [INFO] Lens client ........................................ SUCCESS [  6.583 s]
> [INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
> [INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
> [INFO] Lens Regression .................................... SUCCESS [  4.283 s]
> [INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:05 min
> [INFO] Finished at: 2016-01-25T10:14:25+05:30
> [INFO] Final Memory: 191M/1654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Added a new test case 
> org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>


Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

Posted by Amareshwari Sriramadasu <am...@apache.org>.

> On Jan. 25, 2016, 12:29 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 551
> > <https://reviews.apache.org/r/42703/diff/1/?file=1219141#file1219141line551>
> >
> >     Should we be calling a close on resultset? Oherwrise other resources like jdbc connection are cleared?
> 
> Puneet Gupta wrote:
>     The Query Purging flow should take care of that. 
>     
>     But another thing that gets enforced now is that any result of type InMemory should be consumable within 3 minutes , otherwise the reader will get closed result set exception since the query will get purged within 3 minutes. 
>     
>     Should we increase the TTL to say 10 minutes So the reader has enough time to read all the rows of a big resultset?

I see default is 5 minutes and should be fine. Can you add comment about how closing of result sets is taken care?


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/#review116080
-----------------------------------------------------------


On Jan. 25, 2016, 5:16 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42703/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 5:16 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-921
>     https://issues.apache.org/jira/browse/lens-921
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added a new server configration
> 
> +  <property>
> +    <name>lens.server.inmemory.resultset.ttl.secs</name>
> +    <value>300</value>
> +    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
> +     The default value is 300 seconds (5 minutes).
> +     </description>
> +  </property>
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a 
>   lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5 
>   src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306 
>   src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe 
> 
> Diff: https://reviews.apache.org/r/42703/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
> [INFO] Lens ............................................... SUCCESS [  5.054 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.519 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
> [INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
> [INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
> [INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
> [INFO] Lens client ........................................ SUCCESS [  6.583 s]
> [INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
> [INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
> [INFO] Lens Regression .................................... SUCCESS [  4.283 s]
> [INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:05 min
> [INFO] Finished at: 2016-01-25T10:14:25+05:30
> [INFO] Final Memory: 191M/1654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Added a new test case 
> org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>


Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42703/#review116080
-----------------------------------------------------------




lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 281)
<https://reviews.apache.org/r/42703/#comment177082>

    We should not be creating it as static value. Instead, we should read from init on service.



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 551)
<https://reviews.apache.org/r/42703/#comment177083>

    Should we be calling a close on resultset? Oherwrise other resources like jdbc connection are cleared?


- Amareshwari Sriramadasu


On Jan. 25, 2016, 5:16 a.m., Puneet Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42703/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 5:16 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-921
>     https://issues.apache.org/jira/browse/lens-921
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added a new server configration
> 
> +  <property>
> +    <name>lens.server.inmemory.resultset.ttl.secs</name>
> +    <value>300</value>
> +    <description>This property defines the TTL(time to live) in seconds for all result sets of type InMemoryResultSet beyond which they are eligible for purging irrespective of whether the result set has been read or not.
> +     The default value is 300 seconds (5 minutes).
> +     </description>
> +  </property>
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306 
>   lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a 
>   lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5b287398f93fd518d99f3d562f9a76d5e5 
>   src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306 
>   src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe 
> 
> Diff: https://reviews.apache.org/r/42703/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [  7.276 s]
> [INFO] Lens ............................................... SUCCESS [  5.054 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.519 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 12.829 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 13.575 s]
> [INFO] Lens DB storage .................................... SUCCESS [  1.888 s]
> [INFO] Lens Query Library ................................. SUCCESS [  3.302 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [  4.532 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [  6.367 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [  4.499 s]
> [INFO] Lens Server ........................................ SUCCESS [ 43.967 s]
> [INFO] Lens client ........................................ SUCCESS [  6.583 s]
> [INFO] Lens CLI ........................................... SUCCESS [  7.888 s]
> [INFO] Lens Examples ...................................... SUCCESS [  1.322 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [  1.779 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 16.864 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [  9.823 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [  7.942 s]
> [INFO] Lens Regression .................................... SUCCESS [  4.283 s]
> [INFO] Lens UI ............................................ SUCCESS [ 12.508 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:05 min
> [INFO] Finished at: 2016-01-25T10:14:25+05:30
> [INFO] Final Memory: 191M/1654M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Added a new test case 
> org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult()
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>