You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2015/08/14 18:52:05 UTC
Review Request 37485: Remove unnecessary wait-and-assert for process
termination
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37485/
-----------------------------------------------------------
Review request for geode and Darrel Schneider.
Bugs: GEODE-209
https://issues.apache.org/jira/browse/GEODE-209
Repository: geode
Description
-------
The waiting for and asserting of process termination is taking more than 5 minutes on ASF infrastructure. This is not necessary for the test and I don't want to increase the wait time so I'm removing it from the test and replace it with a call to destroy the process.
Diffs
-----
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithTimeoutOfWaitForOutputToMatchJUnitTest.java 1b8a312
Diff: https://reviews.apache.org/r/37485/diff/
Testing
-------
FailWithTimeoutOfWaitForOutputToMatchJUnitTest
GoldenTestFrameworkTestSuite
check
Thanks,
Kirk Lund
Re: Review Request 37485: Remove unnecessary wait-and-assert for
process termination
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37485/#review95444
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Aug. 14, 2015, 9:52 a.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37485/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 9:52 a.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Bugs: GEODE-209
> https://issues.apache.org/jira/browse/GEODE-209
>
>
> Repository: geode
>
>
> Description
> -------
>
> The waiting for and asserting of process termination is taking more than 5 minutes on ASF infrastructure. This is not necessary for the test and I don't want to increase the wait time so I'm removing it from the test and replace it with a call to destroy the process.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithTimeoutOfWaitForOutputToMatchJUnitTest.java 1b8a312
>
> Diff: https://reviews.apache.org/r/37485/diff/
>
>
> Testing
> -------
>
> FailWithTimeoutOfWaitForOutputToMatchJUnitTest
> GoldenTestFrameworkTestSuite
> check
>
>
> Thanks,
>
> Kirk Lund
>
>