You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@solr.apache.org by Eric Pugh <ep...@opensourceconnections.com> on 2022/07/20 00:12:42 UTC
I think I broke the build...
Good news, the spotless check for wildcard imports works…. The bad news is that I thought SOLR-16271 was complete and there were no wildcard imports…
I can revert the change to main and branch_9x, or maybe someone wants to confirm https://github.com/apache/solr/pull/949 and then the build should pass again?
Not sure which is more intrusive…
https://www.youbrokethebuild.com/
Eric
_______________________
Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal>
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
Re: I think I broke the build...
Posted by Uwe Schindler <uw...@thetaphi.de>.
Hi Eric,
looks fixed. The yellow builds are typical test failures and have
nothing to do with your changes. If precommit fails the build gets red
(test failures are configured in Gradle to proceed and not exit). So the
Gradle build does not fails and succeeds till end, only the test
failures are reported as yellow.
In short: If builds are red, then its an issue with build system or
precommit checks, if it is yellow it is just some failing tests.
Uwe
Am 20.07.2022 um 14:05 schrieb Eric Pugh:
> 4167 passed after I updated the build with the imports. https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/4167/
>
> 4168 failed, but it may have been timing issues….
>
>
>> On Jul 19, 2022, at 10:00 PM, Eric Pugh <ep...@opensourceconnections.com> wrote:
>>
>> Good point! I hadn’t even thought of that. Will do, and if Jenkins blows up, untangle in the morning.
>>
>>> On Jul 19, 2022, at 8:36 PM, Houston Putman <houston@apache.org <ma...@apache.org>> wrote:
>>>
>>> If the spotless works on the PR, which the github actions indicate, then
>>> you might as well just merge the PR instead of reverting.
>>>
>>> On Tue, Jul 19, 2022 at 8:12 PM Eric Pugh <epugh@opensourceconnections.com <ma...@opensourceconnections.com>>
>>> wrote:
>>>
>>>> Good news, the spotless check for wildcard imports works…. The bad news
>>>> is that I thought SOLR-16271 was complete and there were no wildcard
>>>> imports…
>>>>
>>>> I can revert the change to main and branch_9x, or maybe someone wants to
>>>> confirm https://github.com/apache/solr/pull/949 <https://github.com/apache/solr/pull/949> and then the build should
>>>> pass again?
>>>>
>>>> Not sure which is more intrusive…
>>>>
>>>> https://www.youbrokethebuild.com/ <https://www.youbrokethebuild.com/>
>>>>
>>>> Eric
>>>>
>>>> _______________________
>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 |
>>>> http://www.opensourceconnections.com <
>>>> http://www.opensourceconnections.com/ <http://www.opensourceconnections.com/>> | My Free/Busy <
>>>> http://tinyurl.com/eric-cal <http://tinyurl.com/eric-cal>>
>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <
>>>> https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>>
>>>>
>>>> This e-mail and all contents, including attachments, is considered to be
>>>> Company Confidential unless explicitly stated otherwise, regardless of
>>>> whether attachments are marked as such.
>> _______________________
>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal>
>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
>> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
>>
> _______________________
> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal>
> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
>
>
--
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: uwe@thetaphi.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org
Re: I think I broke the build...
Posted by Eric Pugh <ep...@opensourceconnections.com>.
4167 passed after I updated the build with the imports. https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/4167/
4168 failed, but it may have been timing issues….
> On Jul 19, 2022, at 10:00 PM, Eric Pugh <ep...@opensourceconnections.com> wrote:
>
> Good point! I hadn’t even thought of that. Will do, and if Jenkins blows up, untangle in the morning.
>
>> On Jul 19, 2022, at 8:36 PM, Houston Putman <houston@apache.org <ma...@apache.org>> wrote:
>>
>> If the spotless works on the PR, which the github actions indicate, then
>> you might as well just merge the PR instead of reverting.
>>
>> On Tue, Jul 19, 2022 at 8:12 PM Eric Pugh <epugh@opensourceconnections.com <ma...@opensourceconnections.com>>
>> wrote:
>>
>>> Good news, the spotless check for wildcard imports works…. The bad news
>>> is that I thought SOLR-16271 was complete and there were no wildcard
>>> imports…
>>>
>>> I can revert the change to main and branch_9x, or maybe someone wants to
>>> confirm https://github.com/apache/solr/pull/949 <https://github.com/apache/solr/pull/949> and then the build should
>>> pass again?
>>>
>>> Not sure which is more intrusive…
>>>
>>> https://www.youbrokethebuild.com/ <https://www.youbrokethebuild.com/>
>>>
>>> Eric
>>>
>>> _______________________
>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 |
>>> http://www.opensourceconnections.com <
>>> http://www.opensourceconnections.com/ <http://www.opensourceconnections.com/>> | My Free/Busy <
>>> http://tinyurl.com/eric-cal <http://tinyurl.com/eric-cal>>
>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <
>>> https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>>
>>>
>>> This e-mail and all contents, including attachments, is considered to be
>>> Company Confidential unless explicitly stated otherwise, regardless of
>>> whether attachments are marked as such.
>
> _______________________
> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal>
> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
>
_______________________
Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal>
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
Re: I think I broke the build...
Posted by Eric Pugh <ep...@opensourceconnections.com>.
Good point! I hadn’t even thought of that. Will do, and if Jenkins blows up, untangle in the morning.
> On Jul 19, 2022, at 8:36 PM, Houston Putman <ho...@apache.org> wrote:
>
> If the spotless works on the PR, which the github actions indicate, then
> you might as well just merge the PR instead of reverting.
>
> On Tue, Jul 19, 2022 at 8:12 PM Eric Pugh <epugh@opensourceconnections.com <ma...@opensourceconnections.com>>
> wrote:
>
>> Good news, the spotless check for wildcard imports works…. The bad news
>> is that I thought SOLR-16271 was complete and there were no wildcard
>> imports…
>>
>> I can revert the change to main and branch_9x, or maybe someone wants to
>> confirm https://github.com/apache/solr/pull/949 and then the build should
>> pass again?
>>
>> Not sure which is more intrusive…
>>
>> https://www.youbrokethebuild.com/
>>
>> Eric
>>
>> _______________________
>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 |
>> http://www.opensourceconnections.com <
>> http://www.opensourceconnections.com/ <http://www.opensourceconnections.com/>> | My Free/Busy <
>> http://tinyurl.com/eric-cal <http://tinyurl.com/eric-cal>>
>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <
>> https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>>
>>
>> This e-mail and all contents, including attachments, is considered to be
>> Company Confidential unless explicitly stated otherwise, regardless of
>> whether attachments are marked as such.
_______________________
Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal>
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
Re: I think I broke the build...
Posted by Houston Putman <ho...@apache.org>.
If the spotless works on the PR, which the github actions indicate, then
you might as well just merge the PR instead of reverting.
On Tue, Jul 19, 2022 at 8:12 PM Eric Pugh <ep...@opensourceconnections.com>
wrote:
> Good news, the spotless check for wildcard imports works…. The bad news
> is that I thought SOLR-16271 was complete and there were no wildcard
> imports…
>
> I can revert the change to main and branch_9x, or maybe someone wants to
> confirm https://github.com/apache/solr/pull/949 and then the build should
> pass again?
>
> Not sure which is more intrusive…
>
> https://www.youbrokethebuild.com/
>
> Eric
>
> _______________________
> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 |
> http://www.opensourceconnections.com <
> http://www.opensourceconnections.com/> | My Free/Busy <
> http://tinyurl.com/eric-cal>
> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <
> https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
>
> This e-mail and all contents, including attachments, is considered to be
> Company Confidential unless explicitly stated otherwise, regardless of
> whether attachments are marked as such.
>
>