[GitHub] [calcite] asolimando commented on pull request #2852: Fix ColumnMetaData.Rep for nested arrays

[GitBox <gi...@apache.org>]

asolimando commented on PR #2852:
URL: https://github.com/apache/calcite/pull/2852#issuecomment-1175860897

   Hi @joshuamaurice, I don't know why the PR was closed without any comments, this should not happen.
   
   I haven't looked at the fix, but for each non-trivial change (e.g., fixing a typo) we need a Jira ticket, please refer to the [contributor's guideline](https://calcite.apache.org/develop/#contributing) for all the details.
   
   I read you haven't any tests for confirming the limitation (and that your fix is correct), this won't allow to merge the PR. Please file a ticket (following the guidelines for the title and description), try to first derive such a test (you might for instance use coverage tools like in IntelliJ with "line counts" to see which UTs cover the code you are willing to fix, and try to derive a test from there, if you fail describe what you have tried in the ticket and we will try to suggest where to start.
   
   Welcome to the community!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org