You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/07/24 14:37:51 UTC
[PR] [Studio] Validate system alert acknowledge requests [rocketmq-dashboard]
Aias00 opened a new pull request, #551:
URL: https://github.com/apache/rocketmq-dashboard/pull/551
## Summary
- replace system alert acknowledge map parsing with a typed request DTO
- validate required alert ids before invoking acknowledge operations
- add controller tests for list, acknowledge, reject invalid ids, and clear acknowledged alerts
## Scope
- RocketMQ Studio contest scope: Track 1 / METRICS-01 system alert action hardening
- Does not introduce Namespace behavior
## Tests
- `JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q -Dtest=SystemAlertControllerTest,AlertServiceTest test`
- `JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q test`
- `git diff --check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Studio] Validate system alert acknowledge requests [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #551: [Studio] Validate system alert acknowledge requests
URL: https://github.com/apache/rocketmq-dashboard/pull/551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Studio] Validate system alert acknowledge requests [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #551:
URL: https://github.com/apache/rocketmq-dashboard/pull/551#issuecomment-5086677518
Superseded by #632. Consolidated with related ops request validation changes to reduce review overhead while preserving the same scoped fixes and tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org