[jira] [Commented] (HBASE-13578) Remove Arrays.asList().subList() from FSHLog.offer()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516995#comment-14516995 ] 

Hadoop QA commented on HBASE-13578:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12728755/HBASE-13578-v0.patch
  against master branch at commit 75bb815d9954e538488c4c549f7261b5be80551b.
  ATTACHMENT ID: 12728755

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestJMXListener

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13860//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13860//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13860//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13860//console

This message is automatically generated.

> Remove Arrays.asList().subList() from FSHLog.offer()
> ----------------------------------------------------
>
>                 Key: HBASE-13578
>                 URL: https://issues.apache.org/jira/browse/HBASE-13578
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>    Affects Versions: 1.0.0, 2.0.0, 1.1.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>         Attachments: ArrayTest.java, HBASE-13578-v0.patch
>
>
> while doing a run with a profiler I noticed this:
> {code}
> FSHLog.java
> void offer(final long sequence, final SyncFuture [] syncFutures, final int syncFutureCount) {
>   ...
>   this.syncFutures.addAll(Arrays.asList(syncFutures).subList(0, syncFutureCount));
> }
> {code}
> it is creating an Arrays.ArrayList then a RandomAccessSubList, 
> and then addAll() is using creating an iterator and call the syncFutures.add() for each item.
> a simpler for loop adding the items directly is not too ugly and it will avoid all this stuff.
> I've attached a simple test to compare the two, it will not make huge difference but since we are in the core path any tiny bit probably helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)