Re: [PR] [improve][all] Upgraded Jackson to 2.21 LTS and fixed a few gradle assemble warnings [pulsar]

["Copilot (via GitHub)" <gi...@apache.org>]

Copilot commented on code in PR #25504:
URL: https://github.com/apache/pulsar/pull/25504#discussion_r3070620692


##########
gradle/libs.versions.toml:
##########
@@ -29,7 +29,8 @@ netty = "4.1.132.Final"
 netty-iouring = "0.0.26.Final"
 jetty = "12.1.6"
 jersey = "2.42"
-jackson = "2.18.6"
+jackson = "2.21.2"
+jackson-annotations = "2.21"

Review Comment:
   The PR description says Jackson is upgraded to 2.21.0, but the version catalog sets `jackson` to 2.21.2 (and splits `jackson-annotations` to 2.21). Please align the PR description (or adjust the versions) so reviewers/users can accurately track what is being shipped.



##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java:
##########
@@ -442,6 +442,7 @@ public <T> CompletableFuture<Producer<T>> createProducerAsync(ProducerConfigurat
 
     }
 
+    @SuppressWarnings("unchecked")
     public CompletableFuture<Void> reloadSchemaForAutoProduceProducer(String topic, AutoProduceBytesSchema autoSchema) {

Review Comment:
   The method-level `@SuppressWarnings("unchecked")` is quite broad and can hide unrelated unchecked issues introduced later. Prefer narrowing the suppression to the specific statements/casts (or adjust the generics, e.g., parameterize `AutoProduceBytesSchema` here) so only the necessary unchecked warning is suppressed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org