You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/10/28 06:16:31 UTC
[GitHub] [druid] vogievetsky commented on a change in pull request #11847: Add info for compation config dialog
vogievetsky commented on a change in pull request #11847:
URL: https://github.com/apache/druid/pull/11847#discussion_r738051263
##########
File path: web-console/src/druid-models/compaction-config.tsx
##########
@@ -173,7 +201,15 @@ export const COMPACTION_CONFIG_FIELDS: Field<CompactionConfig>[] = [
required: (t: CompactionConfig) =>
!deepGet(t, 'tuningConfig.partitionsSpec.targetRowsPerSegment') &&
!deepGet(t, 'tuningConfig.partitionsSpec.maxRowsPerSegment'),
- info: <p>Maximum number of rows to include in a partition.</p>,
+ info: (
+ <>
+ <p>Maximum number of rows to include in a partition.</p>{' '}
Review comment:
I don't think you need the `{' '}` in this line, I bet it was just a typo that prettier fixed up for you. Otherwise these changes look good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org