You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2019/05/31 20:59:30 UTC
Review Request 70770: Break up DDLTask - extract Storage related
operations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70770/
-----------------------------------------------------------
Review request for hive and Zoltan Haindrich.
Bugs: HIVE-21797
https://issues.apache.org/jira/browse/HIVE-21797
Repository: hive-git
Description
-------
DDLTask is a huge class, more than 5000 lines long. The related DDLWork is also a huge class, which has a field for each DDL operation it supports. The goal is to refactor these in order to have everything cut into more handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
have a separate class for each operation
have a package for each operation group (database ddl, table ddl, etc), so the amount of classes under a package is more manageable
make all the requests (DDLDesc subclasses) immutable
DDLTask should be agnostic to the actual operations
right now let's ignore the issue of having some operations handled by DDLTask which are not actual DDL operations (lock, unlock, desc...)
In the interim time when there are two DDLTask and DDLWork classes in the code base the new ones in the new package are called DDLTask2 and DDLWork2 thus avoiding the usage of fully qualified class names where both the old and the new classes are in use.
Step #10: extract all the storage related operations from the old DDLTask, and move them under the new package.
Diffs
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java abd351d51a
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableDesc.java 3ff04131d0
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableOperation.java 5d8cd94939
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableWithConstraintsDesc.java ebd3bdbf4d
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableAddColumnsDesc.java a15597c071
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableChangeColumnDesc.java 827cc80d14
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableReplaceColumnsDesc.java 6947c1ed51
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableReplaceColumnsOperation.java 116fa2d28c
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableUpdateColumnsDesc.java f1a1ea12e5
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constaint/AlterTableAddConstraintDesc.java cd8deab596
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/creation/ShowCreateTableOperation.java 3ea7443787
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableClusteredByDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableClusteredByOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableIntoBucketsDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableIntoBucketsOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotClusteredDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotClusteredOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotSkewedDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotSkewedOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotSortedDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotSortedOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetFileFormatDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetFileFormatOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetLocationDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetLocationOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdeDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdeOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdePropsDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdePropsOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSkewedLocationDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSkewedLocationOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSkewedByDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSkewedByOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/package-info.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 2e955aef9d
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 15a266d268
ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 86dfef091c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 995ff9b68c
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java e6779b24a5
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 50304e2374
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java edb20ae7e6
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java cb6958a327
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 97ef823bfd
ql/src/java/org/apache/hadoop/hive/ql/util/DirectionUtils.java PRE-CREATION
ql/src/test/queries/clientpositive/table_storage.q PRE-CREATION
ql/src/test/results/clientnegative/alter_table_wrong_location2.q.out b50786a64c
ql/src/test/results/clientnegative/alter_table_wrong_regex.q.out 667c7d5d38
ql/src/test/results/clientnegative/orc_change_fileformat.q.out db454fe220
ql/src/test/results/clientnegative/orc_change_fileformat_acid.q.out cd3e168b3d
ql/src/test/results/clientnegative/orc_change_serde.q.out 7f882b520c
ql/src/test/results/clientnegative/orc_change_serde_acid.q.out 612207b936
ql/src/test/results/clientnegative/strict_managed_tables6.q.out b6d23d1fac
ql/src/test/results/clientpositive/table_storage.q.out PRE-CREATION
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaHook.java 5ef356d02f
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 03f136bb60
Diff: https://reviews.apache.org/r/70770/diff/1/
Testing
-------
Added new q tests + all the previous q tests are still running.
Thanks,
Miklos Gergely
Re: Review Request 70770: Break up DDLTask - extract Storage related
operations
Posted by Zoltan Haindrich <ki...@rxd.hu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70770/#review215643
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdeOperation.java
Lines 68 (patched)
<https://reviews.apache.org/r/70770/#comment302421>
this is odd
could you open a followup ticket?
- Zoltan Haindrich
On June 1, 2019, 11:03 a.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70770/
> -----------------------------------------------------------
>
> (Updated June 1, 2019, 11:03 a.m.)
>
>
> Review request for hive and Zoltan Haindrich.
>
>
> Bugs: HIVE-21797
> https://issues.apache.org/jira/browse/HIVE-21797
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> DDLTask is a huge class, more than 5000 lines long. The related DDLWork is also a huge class, which has a field for each DDL operation it supports. The goal is to refactor these in order to have everything cut into more handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
>
> have a separate class for each operation
> have a package for each operation group (database ddl, table ddl, etc), so the amount of classes under a package is more manageable
> make all the requests (DDLDesc subclasses) immutable
> DDLTask should be agnostic to the actual operations
> right now let's ignore the issue of having some operations handled by DDLTask which are not actual DDL operations (lock, unlock, desc...)
> In the interim time when there are two DDLTask and DDLWork classes in the code base the new ones in the new package are called DDLTask2 and DDLWork2 thus avoiding the usage of fully qualified class names where both the old and the new classes are in use.
>
> Step #10: extract all the storage related operations from the old DDLTask, and move them under the new package.
>
>
> Diffs
> -----
>
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java abd351d51a
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableDesc.java 3ff04131d0
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableOperation.java 5d8cd94939
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableWithConstraintsDesc.java ebd3bdbf4d
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableAddColumnsDesc.java a15597c071
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableChangeColumnDesc.java 827cc80d14
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableReplaceColumnsDesc.java 6947c1ed51
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableReplaceColumnsOperation.java 116fa2d28c
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableUpdateColumnsDesc.java f1a1ea12e5
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constaint/AlterTableAddConstraintDesc.java cd8deab596
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/creation/ShowCreateTableOperation.java 3ea7443787
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableClusteredByDesc.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableClusteredByOperation.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableIntoBucketsDesc.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableIntoBucketsOperation.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotClusteredDesc.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotClusteredOperation.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotSkewedDesc.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotSkewedOperation.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotSortedDesc.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotSortedOperation.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetFileFormatDesc.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetFileFormatOperation.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetLocationDesc.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetLocationOperation.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdeDesc.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdeOperation.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdePropsDesc.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdePropsOperation.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSkewedLocationDesc.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSkewedLocationOperation.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSkewedByDesc.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSkewedByOperation.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/package-info.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 2e955aef9d
> ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 15a266d268
> ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 86dfef091c
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 995ff9b68c
> ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java e6779b24a5
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 50304e2374
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java edb20ae7e6
> ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java cb6958a327
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 97ef823bfd
> ql/src/java/org/apache/hadoop/hive/ql/util/DirectionUtils.java PRE-CREATION
> ql/src/test/queries/clientpositive/table_storage.q PRE-CREATION
> ql/src/test/results/clientnegative/alter_table_wrong_location2.q.out b50786a64c
> ql/src/test/results/clientnegative/alter_table_wrong_regex.q.out 667c7d5d38
> ql/src/test/results/clientnegative/orc_change_fileformat.q.out db454fe220
> ql/src/test/results/clientnegative/orc_change_fileformat_acid.q.out cd3e168b3d
> ql/src/test/results/clientnegative/orc_change_serde.q.out 7f882b520c
> ql/src/test/results/clientnegative/orc_change_serde_acid.q.out 612207b936
> ql/src/test/results/clientnegative/strict_managed_tables6.q.out b6d23d1fac
> ql/src/test/results/clientpositive/table_storage.q.out PRE-CREATION
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaHook.java 5ef356d02f
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee0e52879a
>
>
> Diff: https://reviews.apache.org/r/70770/diff/2/
>
>
> Testing
> -------
>
> Added new q tests + all the previous q tests are still running.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 70770: Break up DDLTask - extract Storage related
operations
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70770/
-----------------------------------------------------------
(Updated June 1, 2019, 9:03 a.m.)
Review request for hive and Zoltan Haindrich.
Bugs: HIVE-21797
https://issues.apache.org/jira/browse/HIVE-21797
Repository: hive-git
Description
-------
DDLTask is a huge class, more than 5000 lines long. The related DDLWork is also a huge class, which has a field for each DDL operation it supports. The goal is to refactor these in order to have everything cut into more handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
have a separate class for each operation
have a package for each operation group (database ddl, table ddl, etc), so the amount of classes under a package is more manageable
make all the requests (DDLDesc subclasses) immutable
DDLTask should be agnostic to the actual operations
right now let's ignore the issue of having some operations handled by DDLTask which are not actual DDL operations (lock, unlock, desc...)
In the interim time when there are two DDLTask and DDLWork classes in the code base the new ones in the new package are called DDLTask2 and DDLWork2 thus avoiding the usage of fully qualified class names where both the old and the new classes are in use.
Step #10: extract all the storage related operations from the old DDLTask, and move them under the new package.
Diffs (updated)
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java abd351d51a
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableDesc.java 3ff04131d0
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableOperation.java 5d8cd94939
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableWithConstraintsDesc.java ebd3bdbf4d
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableAddColumnsDesc.java a15597c071
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableChangeColumnDesc.java 827cc80d14
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableReplaceColumnsDesc.java 6947c1ed51
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableReplaceColumnsOperation.java 116fa2d28c
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/AlterTableUpdateColumnsDesc.java f1a1ea12e5
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constaint/AlterTableAddConstraintDesc.java cd8deab596
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/creation/ShowCreateTableOperation.java 3ea7443787
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableClusteredByDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableClusteredByOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableIntoBucketsDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableIntoBucketsOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotClusteredDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotClusteredOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotSkewedDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotSkewedOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotSortedDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableNotSortedOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetFileFormatDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetFileFormatOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetLocationDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetLocationOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdeDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdeOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdePropsDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSerdePropsOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSkewedLocationDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSetSkewedLocationOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSkewedByDesc.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/AlterTableSkewedByOperation.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/package-info.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 2e955aef9d
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 15a266d268
ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 86dfef091c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 995ff9b68c
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java e6779b24a5
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 50304e2374
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java edb20ae7e6
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java cb6958a327
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 97ef823bfd
ql/src/java/org/apache/hadoop/hive/ql/util/DirectionUtils.java PRE-CREATION
ql/src/test/queries/clientpositive/table_storage.q PRE-CREATION
ql/src/test/results/clientnegative/alter_table_wrong_location2.q.out b50786a64c
ql/src/test/results/clientnegative/alter_table_wrong_regex.q.out 667c7d5d38
ql/src/test/results/clientnegative/orc_change_fileformat.q.out db454fe220
ql/src/test/results/clientnegative/orc_change_fileformat_acid.q.out cd3e168b3d
ql/src/test/results/clientnegative/orc_change_serde.q.out 7f882b520c
ql/src/test/results/clientnegative/orc_change_serde_acid.q.out 612207b936
ql/src/test/results/clientnegative/strict_managed_tables6.q.out b6d23d1fac
ql/src/test/results/clientpositive/table_storage.q.out PRE-CREATION
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaHook.java 5ef356d02f
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee0e52879a
Diff: https://reviews.apache.org/r/70770/diff/2/
Changes: https://reviews.apache.org/r/70770/diff/1-2/
Testing
-------
Added new q tests + all the previous q tests are still running.
Thanks,
Miklos Gergely