[jira] [Commented] (YUNIKORN-2991) The queue in Draining state does not accept new applications

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905328#comment-17905328 ] 

Wilfred Spiegelenburg commented on YUNIKORN-2991:
-------------------------------------------------

I agree the queue in a draining state should not accept new applications.

I looked at your proposed fix, that is a really simple and straight forward change. Can you look at the possibility of adding it to the {{{}AppPlacementManager.PlaceApplication(){}}}? In that call we check the ACL of the queue and if the queue is a parent queue or not. The stat of the queue could be checked there too. That would mean a rule that returns a draining queue or tries to create a queue under a draining parent would fail. We then skip to the next rule to see if that works.

That gives a little more flexibility if a queue has changed in the config that has a set of placement rules.

> The queue in Draining state does not accept new applications
> ------------------------------------------------------------
>
>                 Key: YUNIKORN-2991
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2991
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - scheduler
>            Reporter: haorenhui
>            Priority: Minor
>              Labels: pull-request-available
>
> When the queue is in the Drafting state, new applications are still allowed to be scheduled after submission. Should we refuse?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org