You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/13 19:49:02 UTC
Review Request 24658: Updated equality check for CommandInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24658/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee
Diff: https://reviews.apache.org/r/24658/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 24658: Updated equality check for CommandInfo.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 13, 2014, 6:10 p.m., Vinod Kone wrote:
> > src/common/type_utils.cpp, lines 76-86
> > <https://reviews.apache.org/r/24658/diff/1/?file=659441#file659441line76>
> >
> > Hmm. I think the order is important for argv right?
> >
> > e.g., ./foo argv1 argv2 is not the same as ./foo argv2 argv1.
Good catch!
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24658/#review50478
-----------------------------------------------------------
On Aug. 13, 2014, 5:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24658/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 5:49 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee
>
> Diff: https://reviews.apache.org/r/24658/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24658: Updated equality check for CommandInfo.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24658/#review50478
-----------------------------------------------------------
src/common/type_utils.cpp
<https://reviews.apache.org/r/24658/#comment88289>
Hmm. I think the order is important for argv right?
e.g., ./foo argv1 argv2 is not the same as ./foo argv2 argv1.
- Vinod Kone
On Aug. 13, 2014, 5:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24658/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 5:49 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee
>
> Diff: https://reviews.apache.org/r/24658/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24658: Updated equality check for CommandInfo.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24658/#review50484
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 13, 2014, 6:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24658/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 6:40 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee
>
> Diff: https://reviews.apache.org/r/24658/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24658: Updated equality check for CommandInfo.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24658/
-----------------------------------------------------------
(Updated Aug. 13, 2014, 6:40 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Updated 'depends'
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee
Diff: https://reviews.apache.org/r/24658/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 24658: Updated equality check for CommandInfo.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24658/
-----------------------------------------------------------
(Updated Aug. 13, 2014, 6:39 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Vinod's comment.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee
Diff: https://reviews.apache.org/r/24658/diff/
Testing
-------
make check
Thanks,
Jie Yu