You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/20 10:03:11 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #8783:
[FLINK-12863][FLINK-12865] Remove concurrency from
HeartbeatManager(Sender)Impl
tillrohrmann commented on a change in pull request #8783: [FLINK-12863][FLINK-12865] Remove concurrency from HeartbeatManager(Sender)Impl
URL: https://github.com/apache/flink/pull/8783#discussion_r295736033
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -1898,4 +1998,22 @@ public SlotReport createSlotReport(ResourceID resourceId) {
return slotReports.poll();
}
}
+
+ private static final class AllocateSlotNotifyingTaskSlotTable extends TaskSlotTable {
+
+ private final OneShotLatch allocateSlotLatch;
+
+ private AllocateSlotNotifyingTaskSlotTable(Collection<ResourceProfile> resourceProfiles, TimerService<AllocationID> timerService, OneShotLatch allocateSlotLatch) {
Review comment:
True, will break the parameter list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services