You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Nicolas Helleringer (JIRA)" <ji...@apache.org> on 2010/04/05 16:33:27 UTC
[jira] Created: (LUCENE-2366) LLRect.createBox returned box does
not contains all points in (center,distance) disc
LLRect.createBox returned box does not contains all points in (center,distance) disc
------------------------------------------------------------------------------------
Key: LUCENE-2366
URL: https://issues.apache.org/jira/browse/LUCENE-2366
Project: Lucene - Java
Issue Type: Bug
Components: contrib/spatial
Affects Versions: 3.0.1
Reporter: Nicolas Helleringer
Attachments: LUCENE-2359.patch
LLRect,createBox computation of a bouding box for a disc given center and distance doest not contains all the point in the distance.
Example : the point north by distance doest not have Lat inferior of Lat of the UpperRight corner of the returned box
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2366) LLRect.createBox returned box does
not contains all points in (center,distance) disc
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll resolved LUCENE-2366.
-------------------------------------
Resolution: Fixed
Committed revision 933754.
> LLRect.createBox returned box does not contains all points in (center,distance) disc
> ------------------------------------------------------------------------------------
>
> Key: LUCENE-2366
> URL: https://issues.apache.org/jira/browse/LUCENE-2366
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/spatial
> Affects Versions: 3.0.1
> Reporter: Nicolas Helleringer
> Attachments: LUCENE-2366.patch, LUCENE-2366.patch, LUCENE-2366.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> LLRect,createBox computation of a bouding box for a disc given center and distance doest not contains all the point in the distance.
> Example : the point north by distance doest not have Lat inferior of Lat of the UpperRight corner of the returned box
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2366) LLRect.createBox returned box does
not contains all points in (center,distance) disc
Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Helleringer updated LUCENE-2366:
----------------------------------------
Attachment: LUCENE-2359.patch
Test case for LLRect.createBox
> LLRect.createBox returned box does not contains all points in (center,distance) disc
> ------------------------------------------------------------------------------------
>
> Key: LUCENE-2366
> URL: https://issues.apache.org/jira/browse/LUCENE-2366
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/spatial
> Affects Versions: 3.0.1
> Reporter: Nicolas Helleringer
> Attachments: LUCENE-2359.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> LLRect,createBox computation of a bouding box for a disc given center and distance doest not contains all the point in the distance.
> Example : the point north by distance doest not have Lat inferior of Lat of the UpperRight corner of the returned box
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2366) LLRect.createBox returned box does
not contains all points in (center,distance) disc
Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Helleringer updated LUCENE-2366:
----------------------------------------
Attachment: LUCENE-2366.patch
Ok found : was due to a lack of normalisation of FloatLatLong uppon construction ( I should fix this in a another patch)
The new LUCENE-2366.patch pass the TestantiM test.
ready to evaluate ! =)
> LLRect.createBox returned box does not contains all points in (center,distance) disc
> ------------------------------------------------------------------------------------
>
> Key: LUCENE-2366
> URL: https://issues.apache.org/jira/browse/LUCENE-2366
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/spatial
> Affects Versions: 3.0.1
> Reporter: Nicolas Helleringer
> Attachments: LUCENE-2366.patch, LUCENE-2366.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> LLRect,createBox computation of a bouding box for a disc given center and distance doest not contains all the point in the distance.
> Example : the point north by distance doest not have Lat inferior of Lat of the UpperRight corner of the returned box
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2366) LLRect.createBox returned box does
not contains all points in (center,distance) disc
Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Helleringer updated LUCENE-2366:
----------------------------------------
Attachment: LUCENE-2366.patch
This patch solves LUCENE-2366 but create a regression in TestCartesian.testAntiM.
I ll try to narrow it and fix it.
> LLRect.createBox returned box does not contains all points in (center,distance) disc
> ------------------------------------------------------------------------------------
>
> Key: LUCENE-2366
> URL: https://issues.apache.org/jira/browse/LUCENE-2366
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/spatial
> Affects Versions: 3.0.1
> Reporter: Nicolas Helleringer
> Attachments: LUCENE-2359.patch, LUCENE-2366.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> LLRect,createBox computation of a bouding box for a disc given center and distance doest not contains all the point in the distance.
> Example : the point north by distance doest not have Lat inferior of Lat of the UpperRight corner of the returned box
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2366) LLRect.createBox returned box does
not contains all points in (center,distance) disc
Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Helleringer resolved LUCENE-2366.
-----------------------------------------
Resolution: Fixed
Lucene Fields: [Patch Available] (was: [New])
> LLRect.createBox returned box does not contains all points in (center,distance) disc
> ------------------------------------------------------------------------------------
>
> Key: LUCENE-2366
> URL: https://issues.apache.org/jira/browse/LUCENE-2366
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/spatial
> Affects Versions: 3.0.1
> Reporter: Nicolas Helleringer
> Attachments: LUCENE-2366.patch, LUCENE-2366.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> LLRect,createBox computation of a bouding box for a disc given center and distance doest not contains all the point in the distance.
> Example : the point north by distance doest not have Lat inferior of Lat of the UpperRight corner of the returned box
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2366) LLRect.createBox returned box does
not contains all points in (center,distance) disc
Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Helleringer updated LUCENE-2366:
----------------------------------------
Attachment: (was: LUCENE-2359.patch)
> LLRect.createBox returned box does not contains all points in (center,distance) disc
> ------------------------------------------------------------------------------------
>
> Key: LUCENE-2366
> URL: https://issues.apache.org/jira/browse/LUCENE-2366
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/spatial
> Affects Versions: 3.0.1
> Reporter: Nicolas Helleringer
> Attachments: LUCENE-2366.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> LLRect,createBox computation of a bouding box for a disc given center and distance doest not contains all the point in the distance.
> Example : the point north by distance doest not have Lat inferior of Lat of the UpperRight corner of the returned box
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2366) LLRect.createBox returned box does
not contains all points in (center,distance) disc
Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Helleringer updated LUCENE-2366:
----------------------------------------
Attachment: LUCENE-2366.patch
Corrected a path problem in the patch file
> LLRect.createBox returned box does not contains all points in (center,distance) disc
> ------------------------------------------------------------------------------------
>
> Key: LUCENE-2366
> URL: https://issues.apache.org/jira/browse/LUCENE-2366
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/spatial
> Affects Versions: 3.0.1
> Reporter: Nicolas Helleringer
> Attachments: LUCENE-2366.patch, LUCENE-2366.patch, LUCENE-2366.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> LLRect,createBox computation of a bouding box for a disc given center and distance doest not contains all the point in the distance.
> Example : the point north by distance doest not have Lat inferior of Lat of the UpperRight corner of the returned box
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Reopened: (LUCENE-2366) LLRect.createBox returned box does
not contains all points in (center,distance) disc
Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Helleringer reopened LUCENE-2366:
-----------------------------------------
> LLRect.createBox returned box does not contains all points in (center,distance) disc
> ------------------------------------------------------------------------------------
>
> Key: LUCENE-2366
> URL: https://issues.apache.org/jira/browse/LUCENE-2366
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/spatial
> Affects Versions: 3.0.1
> Reporter: Nicolas Helleringer
> Attachments: LUCENE-2366.patch, LUCENE-2366.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> LLRect,createBox computation of a bouding box for a disc given center and distance doest not contains all the point in the distance.
> Example : the point north by distance doest not have Lat inferior of Lat of the UpperRight corner of the returned box
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2366) LLRect.createBox returned box does
not contains all points in (center,distance) disc
Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853887#action_12853887 ]
Nicolas Helleringer commented on LUCENE-2366:
---------------------------------------------
I reviewed the code as it still raise an error in the TestCartesian.testAntiM
In fact the error is coming from
{code}
double startX = beginAt - (beginAt %1);
double startY = beginAt - startX ; //should give a whole number
double endX = endAt - (endAt %1);
double endY = endAt -endX; //should give a whole number
{code}
@ CartesianPolyFilterBuilder.getShapeLoop : the double handling that should give a whole number does not.
If you pass my version of LUCENE-2359 that does not rely on this code anymore everything is fine.
> LLRect.createBox returned box does not contains all points in (center,distance) disc
> ------------------------------------------------------------------------------------
>
> Key: LUCENE-2366
> URL: https://issues.apache.org/jira/browse/LUCENE-2366
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/spatial
> Affects Versions: 3.0.1
> Reporter: Nicolas Helleringer
> Attachments: LUCENE-2366.patch, LUCENE-2366.patch, LUCENE-2366.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> LLRect,createBox computation of a bouding box for a disc given center and distance doest not contains all the point in the distance.
> Example : the point north by distance doest not have Lat inferior of Lat of the UpperRight corner of the returned box
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2366) LLRect.createBox returned box does
not contains all points in (center,distance) disc
Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853379#action_12853379 ]
Nicolas Helleringer commented on LUCENE-2366:
---------------------------------------------
I will work on this and have a patch very soon.
> LLRect.createBox returned box does not contains all points in (center,distance) disc
> ------------------------------------------------------------------------------------
>
> Key: LUCENE-2366
> URL: https://issues.apache.org/jira/browse/LUCENE-2366
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/spatial
> Affects Versions: 3.0.1
> Reporter: Nicolas Helleringer
> Attachments: LUCENE-2359.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> LLRect,createBox computation of a bouding box for a disc given center and distance doest not contains all the point in the distance.
> Example : the point north by distance doest not have Lat inferior of Lat of the UpperRight corner of the returned box
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org