You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/19 11:36:43 UTC

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #15200: [Improve][doc][txn] add brokerDeduplicationEnabled=true to enable transaction deduplication

congbobo184 commented on code in PR #15200:
URL: https://github.com/apache/pulsar/pull/15200#discussion_r852938522


##########
site2/docs/txn-use.md:
##########
@@ -20,21 +20,29 @@ This section provides an example of how to use the transaction API to send and r
 
 2. Enable transaction. 
 
-    Change the configuration in the `broker.conf` file.
+    Change the configuration in the `broker.conf` or `standalone.conf` file.
 
     ```
+    //mandatory configuration, used to enable transaction coordinator
     transactionCoordinatorEnabled=true
+   
+    //mandtory configuration, used to create systemTopic used for transaction buffer snapshot
     systemTopicEnabled=true
+   
     ```
 
-    If you want to enable batch messages in transactions, follow the steps below.
+    * If you want to enable batch messages in transactions, follow the steps below.

Review Comment:
   If you want to ack batch message with transaction should enable acknowledgmentAtBatchIndexLevelEnabled, follow the steps below.



##########
site2/docs/txn-use.md:
##########
@@ -20,21 +20,29 @@ This section provides an example of how to use the transaction API to send and r
 
 2. Enable transaction. 
 
-    Change the configuration in the `broker.conf` file.
+    Change the configuration in the `broker.conf` or `standalone.conf` file.
 
     ```
+    //mandatory configuration, used to enable transaction coordinator
     transactionCoordinatorEnabled=true
+   
+    //mandtory configuration, used to create systemTopic used for transaction buffer snapshot
     systemTopicEnabled=true
+   
     ```
 
-    If you want to enable batch messages in transactions, follow the steps below.
+    * If you want to enable batch messages in transactions, follow the steps below.
 
     Set `acknowledgmentAtBatchIndexLevelEnabled` to `true` in the `broker.conf` or `standalone.conf` file.
 
       ```
       acknowledgmentAtBatchIndexLevelEnabled=true
       ```
 
+    * [message deduplication](cookbooks-deduplication.md) is a mandatory configuration, if need to guarantee exactly-once semantics.
+    You can enable message deduplication at the broker level, the namespace level, or the topic level according to your needs.

Review Comment:
   the namespace level or the topic level according to your needs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org