You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/15 14:23:36 UTC
[GitHub] [airflow] PApostol opened a new pull request #20888: UI page title to allow for Markup
PApostol opened a new pull request #20888:
URL: https://github.com/apache/airflow/pull/20888
Set `instance_name_markup = True` in `airflow.cfg` to render `instance_name` with Markup.
Closes #20877.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #20888: UI page title to allow for Markup
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #20888:
URL: https://github.com/apache/airflow/pull/20888#discussion_r787064700
##########
File path: airflow/config_templates/config.yml
##########
@@ -1303,6 +1303,13 @@
type: string
example: ~
default:
+ - name: instance_name_markup
Review comment:
Since it is a boolean value, I would suggest a name that makes it seems so.
Few suggestions: `has_markup_in_instance_name`, `markup_in_instance_name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wolfier commented on pull request #20888: UI page title to allow for Markup
Posted by GitBox <gi...@apache.org>.
wolfier commented on pull request #20888:
URL: https://github.com/apache/airflow/pull/20888#issuecomment-1015678253
Nice change! lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #20888: UI page title to allow for Markup
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #20888:
URL: https://github.com/apache/airflow/pull/20888#discussion_r787065412
##########
File path: airflow/config_templates/config.yml
##########
@@ -1303,6 +1303,13 @@
type: string
example: ~
default:
+ - name: instance_name_markup
Review comment:
Or `instance_name_is_html`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] PApostol commented on pull request #20888: UI page title to allow for Markup
Posted by GitBox <gi...@apache.org>.
PApostol commented on pull request #20888:
URL: https://github.com/apache/airflow/pull/20888#issuecomment-1015711152
> Hmmm for some reason this sits a little uneasily with me, but I can't actually think of any way it would go wrong (in an exploitable way)
I understand where you're coming from, but essentially it's not too different from the [UIAlert code](https://github.com/astronomer/airflow/blob/3bf356ae2f0da40329d501c4d6b39b175120253b/airflow/www/utils.py#L560) (that's where I got the idea from).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #20888: UI page title to allow for Markup
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #20888:
URL: https://github.com/apache/airflow/pull/20888#issuecomment-1015688782
Hmmm for some reason this sits a little uneasily with me, but I can't actually think of any way it would go wrong (in an exploitable way)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #20888: UI page title to allow for Markup
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #20888:
URL: https://github.com/apache/airflow/pull/20888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org