You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/24 20:34:20 UTC
[GitHub] [pulsar] david-streamlio opened a new pull request #9701: Issue-9430 [pulsar-io]: Added delete methods to ConnectorContext
david-streamlio opened a new pull request #9701:
URL: https://github.com/apache/pulsar/pull/9701
<!--
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<9430
### Motivation
We wanted to add the capability of to delete items from the state store inside the IO connector framework. You can currently put/get items to the state store but not delete them. This will bring the Pulsar IO connectors to feature parity with the Pulsar Functions that can (put/get/delete) from the state store.
### Modifications
Added two method signatures to the ConnectorContext object.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- The public API: (yes), it exposes two new methods in the ConnectorContext API
### Documentation
This feature is documented via JavaDoc comments on the newly added methods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng merged pull request #9701: Issue-9430 [pulsar-io]: Added delete methods to ConnectorContext
Posted by GitBox <gi...@apache.org>.
jerrypeng merged pull request #9701:
URL: https://github.com/apache/pulsar/pull/9701
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #9701: Issue-9430 [pulsar-io]: Added delete methods to ConnectorContext
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9701:
URL: https://github.com/apache/pulsar/pull/9701#issuecomment-787113402
Can you add the '@Override' annotation please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] david-streamlio commented on pull request #9701: Issue-9430 [pulsar-io]: Added delete methods to ConnectorContext
Posted by GitBox <gi...@apache.org>.
david-streamlio commented on pull request #9701:
URL: https://github.com/apache/pulsar/pull/9701#issuecomment-787099658
> Where is it the actual implementation?
The implementation of the these deleteState method is inside the [org.apache.pulsar.functions.instance.ContextImpl](https://github.com/apache/pulsar/blob/0469dfe2c7804bd9ca9ea34e95d83b2196216cf9/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java#L387) object that implements this interface. The implementation was always there, it just wasn't exposed through the SourceContext and SinkContext interfaces. This PR exposes those method now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] david-streamlio commented on pull request #9701: Issue-9430 [pulsar-io]: Added delete methods to ConnectorContext
Posted by GitBox <gi...@apache.org>.
david-streamlio commented on pull request #9701:
URL: https://github.com/apache/pulsar/pull/9701#issuecomment-787100018
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] david-streamlio commented on pull request #9701: Issue-9430 [pulsar-io]: Added delete methods to ConnectorContext
Posted by GitBox <gi...@apache.org>.
david-streamlio commented on pull request #9701:
URL: https://github.com/apache/pulsar/pull/9701#issuecomment-786958098
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] david-streamlio edited a comment on pull request #9701: Issue-9430 [pulsar-io]: Added delete methods to ConnectorContext
Posted by GitBox <gi...@apache.org>.
david-streamlio edited a comment on pull request #9701:
URL: https://github.com/apache/pulsar/pull/9701#issuecomment-787099658
> Where is it the actual implementation?
The implementation of the these deleteState methods is inside the [org.apache.pulsar.functions.instance.ContextImpl](https://github.com/apache/pulsar/blob/0469dfe2c7804bd9ca9ea34e95d83b2196216cf9/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java#L387) object that implements this interface. The implementation was always there, it just wasn't exposed through the SourceContext and SinkContext interfaces. This PR exposes those method now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] david-streamlio commented on pull request #9701: Issue-9430 [pulsar-io]: Added delete methods to ConnectorContext
Posted by GitBox <gi...@apache.org>.
david-streamlio commented on pull request #9701:
URL: https://github.com/apache/pulsar/pull/9701#issuecomment-786915690
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] david-streamlio commented on pull request #9701: Issue-9430 [pulsar-io]: Added delete methods to ConnectorContext
Posted by GitBox <gi...@apache.org>.
david-streamlio commented on pull request #9701:
URL: https://github.com/apache/pulsar/pull/9701#issuecomment-788063956
> Can you add the '@override' annotation please?
To which class/interface? All of the methods I added have that annotation except in the base `org.apache.pulsar.io.core.ConnectorContext` interface which doesn't extend anything
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #9701: Issue-9430 [pulsar-io]: Added delete methods to ConnectorContext
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9701:
URL: https://github.com/apache/pulsar/pull/9701#issuecomment-788865393
@david-streamlio
I expected this @Override annotation in this PR, but I see now that it was already present because ContextImpl already implemented the `Context` interface
https://github.com/apache/pulsar/blob/0469dfe2c7804bd9ca9ea34e95d83b2196216cf9/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java#L392
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org