You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/09/27 06:51:53 UTC

[GitHub] [rocketmq-client-go] cserwen commented on a diff in pull request #923: [feat] don't share limit channel in pushConsumer

cserwen commented on code in PR #923:
URL: https://github.com/apache/rocketmq-client-go/pull/923#discussion_r980824992


##########
consumer/push_consumer.go:
##########
@@ -260,6 +260,11 @@ func (pc *pushConsumer) Subscribe(topic string, selector MessageSelector,
 		return errors2.ErrStartTopic
 	}
 
+	if _, ok := pc.crCh[topic]; !ok {
+		defaultOpts := defaultPushConsumerOptions()

Review Comment:
   User may set the value of this parameter, so default options cannot be used here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org