[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5532: Fixing grep thirdeye changes in github action scripts

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5532:
URL: https://github.com/apache/incubator-pinot/pull/5532#discussion_r437784293



##########
File path: .github/workflows/scripts/.pinot_test.sh
##########
@@ -25,7 +25,7 @@ java -version
 COMMIT_BEFORE=$(jq -r ".pull_request.base.sha" "${GITHUB_EVENT_PATH}")
 COMMIT_AFTER=$(jq -r ".pull_request.head.sha" "${GITHUB_EVENT_PATH}")
 git fetch
-git diff --name-only "${COMMIT_BEFORE}...${COMMIT_AFTER}" | grep -E
+git diff --name-only "${COMMIT_BEFORE}...${COMMIT_AFTER}" | grep -E '^(thirdeye)'

Review comment:
       ```suggestion
   git diff --name-only "${COMMIT_BEFORE}" "${COMMIT_AFTER}" | grep -E '^(thirdeye)'
   ```

##########
File path: .github/workflows/scripts/.pinot_quickstart.sh
##########
@@ -25,7 +25,7 @@ java -version
 COMMIT_BEFORE=$(jq -r ".pull_request.base.sha" "${GITHUB_EVENT_PATH}")
 COMMIT_AFTER=$(jq -r ".pull_request.head.sha" "${GITHUB_EVENT_PATH}")
 git fetch
-git diff --name-only "${COMMIT_BEFORE}...${COMMIT_AFTER}" | grep -E
+git diff --name-only "${COMMIT_BEFORE}...${COMMIT_AFTER}" | grep -E '^(thirdeye)'

Review comment:
       ```suggestion
   git diff --name-only "${COMMIT_BEFORE}" "${COMMIT_AFTER}" | grep -E '^(thirdeye)'
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org