[GitHub] [superset] suddjian commented on a change in pull request #15781: fix(explore): dnd multiple columns doesn't work

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #15781:
URL: https://github.com/apache/superset/pull/15781#discussion_r672442298



##########
File path: superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx
##########
@@ -162,6 +162,7 @@ export const DndMetricSelect = (props: any) => {
 
   const onNewMetric = (newMetric: Metric) => {
     const newValue = props.isMulti ? [...value, newMetric] : [newMetric];
+      props.isMulti || props.multi ? [...value, newMetric] : [newMetric];

Review comment:
       I don't think this line will do anything because the result is not being assigned to a variable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org