You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/03/01 08:12:18 UTC

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20449#discussion_r171485997
  
    --- Diff: core/src/test/scala/org/apache/spark/JobCancellationSuite.scala ---
    @@ -40,6 +41,10 @@ class JobCancellationSuite extends SparkFunSuite with Matchers with BeforeAndAft
       override def afterEach() {
         try {
           resetSparkContext()
    +      // Reset semaphores if used by multiple tests.
    +      // Note: if other semaphores are shared by multiple tests, please reset them in this block
    +      JobCancellationSuite.taskStartedSemaphore.drainPermits()
    +      JobCancellationSuite.taskCancelledSemaphore.drainPermits()
    --- End diff --
    
    nit: for simplicity, I'd like to reset all semaphores here, instead of thinking about which one are shared.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org