You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/09/13 11:33:13 UTC

[GitHub] [hbase] busbey opened a new pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.

busbey opened a new pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
URL: https://github.com/apache/hbase/pull/621
 
 
   
   * leave Zulu JDKs at their normal location
   * set JAVA_HOME in the dockerfile
   * work around yetus setting a different JAVA_HOME
   
   Manually tested locally with Yetus 0.11.0
   ```
    test-patch --docker --dockerfile=dev-support/docker/Dockerfile --mvn-custom-repos --multijdkdirs=/usr/lib/jvm/zulu-8-amd64 --empty-patch --personality=dev-support/hbase-personality.sh
   ...
   || Subsystem || Report/Notes ||
   ============================================================================
   | Docker | Client=19.03.1 Server=19.03.1 base: /private/tmp/yetus-27665.32767/Dockerfile |
   | Optional Tests | dupname asflicense yamllint rubocop shellcheck shelldocs xml hadolint pylint markdownlint javac javadoc unit shadedjars hadoopcheck compile spotbugs findbugs hbaseanti checkstyle refguide cc checkmake golang perlcritic hbaseprotoc prototool jshint |
   | uname | Linux 532f4e654c89 4.9.184-linuxkit #1 SMP Tue Jul 2 22:58:16 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-1 / 4454204 |
   | Default Java | 1.7.0_232 |
   | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_222 /usr/lib/jvm/zulu-7-amd64:1.7.0_232 |
   ...
   ```
   
   The hbase-personality change and the stuff to unset JAVA_HOME in the host environment will need to go to all branches. The rest I think just goes to branches-1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services