You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by sebb <se...@gmail.com> on 2020/10/07 22:56:41 UTC
Re: [whimsy] branch master updated: fix regression by avoiding broken
versions of ruby2js
On Wed, 7 Oct 2020 at 18:57, <ru...@apache.org> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> rubys pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 1800878 fix regression by avoiding broken versions of ruby2js
Note that there are several other Gemfiles which reference 3.3.1 still.
Also one which has no minimum version.
Should those be fixed?
> 1800878 is described below
>
> commit 1800878b2b1345c5ae02d2bd2c55289a05786cfe
> Author: Sam Ruby <ru...@intertwingly.net>
> AuthorDate: Wed Oct 7 13:57:03 2020 -0400
>
> fix regression by avoiding broken versions of ruby2js
> ---
> www/board/agenda/Gemfile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/board/agenda/Gemfile b/www/board/agenda/Gemfile
> index 08b47fb..83cfa0a 100644
> --- a/www/board/agenda/Gemfile
> +++ b/www/board/agenda/Gemfile
> @@ -14,7 +14,7 @@ end
> gem 'rake'
> wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> gem 'wunderbar', wunderbar_version
> -gem 'ruby2js', '>=3.3.1'
> +gem 'ruby2js', '>=3.3.6'
> gem 'sinatra', '~> 2.0'
> gem 'nokogumbo'
> gem 'execjs'
>
Re: [whimsy] branch master updated: fix regression by avoiding broken
versions of ruby2js
Posted by Sam Ruby <ru...@intertwingly.net>.
On Wed, Oct 7, 2020 at 6:56 PM sebb <se...@gmail.com> wrote:
>
> On Wed, 7 Oct 2020 at 18:57, <ru...@apache.org> wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > rubys pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/whimsy.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> > new 1800878 fix regression by avoiding broken versions of ruby2js
>
> Note that there are several other Gemfiles which reference 3.3.1 still.
> Also one which has no minimum version.
>
> Should those be fixed?
In some sense, it doesn't matter. Any commit will cause all of the
whimsy applications to be updated to the latest version of the ruby2js
gem.
- Sam Ruby
> > 1800878 is described below
> >
> > commit 1800878b2b1345c5ae02d2bd2c55289a05786cfe
> > Author: Sam Ruby <ru...@intertwingly.net>
> > AuthorDate: Wed Oct 7 13:57:03 2020 -0400
> >
> > fix regression by avoiding broken versions of ruby2js
> > ---
> > www/board/agenda/Gemfile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/www/board/agenda/Gemfile b/www/board/agenda/Gemfile
> > index 08b47fb..83cfa0a 100644
> > --- a/www/board/agenda/Gemfile
> > +++ b/www/board/agenda/Gemfile
> > @@ -14,7 +14,7 @@ end
> > gem 'rake'
> > wunderbar_version = File.read(File.expand_path("#{root}/wunderbar.version", __FILE__)).chomp
> > gem 'wunderbar', wunderbar_version
> > -gem 'ruby2js', '>=3.3.1'
> > +gem 'ruby2js', '>=3.3.6'
> > gem 'sinatra', '~> 2.0'
> > gem 'nokogumbo'
> > gem 'execjs'
> >