You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/06/01 18:30:59 UTC
[GitHub] [qpid-proton] attila-kun opened a new pull request #255: Fixed idle_timeout connection option not working for SSL connections on Windows.
attila-kun opened a new pull request #255:
URL: https://github.com/apache/qpid-proton/pull/255
Steps to reproduce:
1. Connect your receiver to an SSL-capable broker. The receiver has to be running on Windows.
2. Set the `idle_timeout` connection option to e.g. 2 seconds in your `proton::messaging_handler` instance.
2. In the `on_message` callback, sleep for longer than `idle_timeout`. This should trigger the `on_transport_error` callback with a `amqp:resource-limit-exceeded: local-idle-timeout expired` error. On Windows this does not happen.
I saw that the above scenario worked correctly when connecting to a non-SSL broker but failed with an SSL broker. I looked at the difference between the two code paths and found that for the same input (`transport->output_buffer` being empty and `transport->close_sent == true`) [`transport.c` returns `PN_EOS`](https://github.com/apache/qpid-proton/blob/0.31.0/c/src/core/transport.c#L2722) while `schannel.c` returned `0`. After ensuring that `schannel.c` matches the behaviour of `transport.c`, the problem went away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] gemmellr commented on pull request #255: Fixed idle_timeout connection option not working for SSL connections on Windows.
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #255:
URL: https://github.com/apache/qpid-proton/pull/255#issuecomment-684807293
A start would be to create a JIRA to allow tracking the issue, rebasing your commit against master (rather than merging master), and reference the JIRA in your commit (see existing commits).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] attila-kun edited a comment on pull request #255: Fixed idle_timeout connection option not working for SSL connections on Windows.
Posted by GitBox <gi...@apache.org>.
attila-kun edited a comment on pull request #255:
URL: https://github.com/apache/qpid-proton/pull/255#issuecomment-684764558
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] gemmellr commented on pull request #255: PROTON-2275: Fixed idle_timeout connection option not working for SSL connections on Windows.
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #255:
URL: https://github.com/apache/qpid-proton/pull/255#issuecomment-684986383
Thanks. Hopefully one of the C-inclined folks will be along to review the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] attila-kun commented on pull request #255: PROTON-2275: Fixed idle_timeout connection option not working for SSL connections on Windows.
Posted by GitBox <gi...@apache.org>.
attila-kun commented on pull request #255:
URL: https://github.com/apache/qpid-proton/pull/255#issuecomment-684974641
@gemmellr It's done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] attila-kun commented on pull request #255: Fixed idle_timeout connection option not working for SSL connections on Windows.
Posted by GitBox <gi...@apache.org>.
attila-kun commented on pull request #255:
URL: https://github.com/apache/qpid-proton/pull/255#issuecomment-684764558
Is there anything I can do to make sure this gets merged soon?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org