[drlvm] HARMONY-1635 heap iteration WAS: [general] version of GCC...

[Salikh Zakirov <Sa...@Intel.com>]

Gregory Shimansky wrote:

> I think you could use 4.1.0 in Fedora Core 5. Since patch level
> shouldn't really affect the C++ compilation restrictions, the same patch
> should break on 4.1.0 as well.

Gregory, I've looked at harmony-1635.patch you've uploaded to HARMONY-1635,
and I see that is based on the outdated patch from HARMONY-1635.
(i.e. not the latest version: heap-iteration-optimized.patch).

So I will upload the updated patch myself.
I've checked its compilation on Fedora Core 5 (Bordeaux) with gcc 4.1.0,
and it compiles okay.

I've uploaded updated harmony-1635.patch to HARMONY-1635.

Re: [drlvm] HARMONY-1635 heap iteration WAS: [general] version of GCC...

["Geir Magnusson Jr." <ge...@pobox.com>]

fixed.  sorry.

Geir Magnusson Jr. wrote:
> Yep, I broke it.  I just noticed.  (I didn't read mail last night after 
> a certain point...)
> 
> Sorry - will fix ASAP.
> 
> geir
> 
> Ilya Berezhniuk wrote:
>> Hi,
>> I'm trying to build DRLVM, but it doesn't compile (slot.h, jvmti_heap.h
>> cannot be found).
>> It looks like it's because commit r470903 for HARMONY-1635 doesn't 
>> contain
>> added files.
>>
> 

Re: [drlvm] HARMONY-1635 heap iteration WAS: [general] version of GCC...

["Geir Magnusson Jr." <ge...@pobox.com>]

Yep, I broke it.  I just noticed.  (I didn't read mail last night after 
a certain point...)

Sorry - will fix ASAP.

geir

Ilya Berezhniuk wrote:
> Hi,
> I'm trying to build DRLVM, but it doesn't compile (slot.h, jvmti_heap.h
> cannot be found).
> It looks like it's because commit r470903 for HARMONY-1635 doesn't contain
> added files.
> 

Re: [drlvm] HARMONY-1635 heap iteration WAS: [general] version of GCC...

[Ilya Berezhniuk <il...@gmail.com>]

Hi,
I'm trying to build DRLVM, but it doesn't compile (slot.h, jvmti_heap.h
cannot be found).
It looks like it's because commit r470903 for HARMONY-1635 doesn't contain
added files.

Re: [drlvm] HARMONY-1635 heap iteration WAS: [general] version of GCC...

[Rana Dasgupta <rd...@gmail.com>]

Hi,
   I am trying to a clean build on RHEL ( svn latest trunk ) and getting
tons of build errors from the 1635 heap iteration related changes. The 1635
JIRA notes say that the patch has been committed and applied cleanly, so I
am not sure what is happening. Could you please check?

Thanks,
Rana

On 11/3/06, Geir Magnusson Jr. <ge...@pobox.com> wrote:
>
>
>
> Salikh Zakirov wrote:
> > Gregory Shimansky wrote:
> >
> >> I think you could use 4.1.0 in Fedora Core 5. Since patch level
> >> shouldn't really affect the C++ compilation restrictions, the same
> patch
> >> should break on 4.1.0 as well.
> >
> > Gregory, I've looked at harmony-1635.patch you've uploaded to
> HARMONY-1635,
> > and I see that is based on the outdated patch from HARMONY-1635.
> > (i.e. not the latest version: heap-iteration-optimized.patch).
> >
> > So I will upload the updated patch myself.
> > I've checked its compilation on Fedora Core 5 (Bordeaux) with gcc 4.1.0,
> > and it compiles okay.
> >
> > I've uploaded updated harmony-1635.patch to HARMONY-1635.
>
> trying to commit now
>
> geir
>
> >
> >
>

Re: [drlvm] HARMONY-1635 heap iteration WAS: [general] version of GCC...

["Geir Magnusson Jr." <ge...@pobox.com>]

Salikh Zakirov wrote:
> Gregory Shimansky wrote:
> 
>> I think you could use 4.1.0 in Fedora Core 5. Since patch level
>> shouldn't really affect the C++ compilation restrictions, the same patch
>> should break on 4.1.0 as well.
> 
> Gregory, I've looked at harmony-1635.patch you've uploaded to HARMONY-1635,
> and I see that is based on the outdated patch from HARMONY-1635.
> (i.e. not the latest version: heap-iteration-optimized.patch).
> 
> So I will upload the updated patch myself.
> I've checked its compilation on Fedora Core 5 (Bordeaux) with gcc 4.1.0,
> and it compiles okay.
> 
> I've uploaded updated harmony-1635.patch to HARMONY-1635.

trying to commit now

geir

> 
> 

Re: [drlvm] HARMONY-1635 heap iteration WAS: [general] version of GCC...

[Rana Dasgupta <rd...@gmail.com>]

Yes, I use a gcc version 4.0.2 on RHEL. I have no problems building +
running it now


> > > I can confirm that gcc 4.1.1 compiled this patch without any problems.
> > > As I've written, patchlevel shouldn't matter here, and if gcc 4.1.0
> > > worked, 4.1.1 should work as well (with very rare exceptions). I've
> > > just
> > > built VM with it without any errors.
> > >
> > >
> > > --
> > > Gregory
> > >
> > >

Re: [drlvm] HARMONY-1635 heap iteration WAS: [general] version of GCC...

[Gregory Shimansky <gs...@gmail.com>]

Gregory Shimansky wrote:
> Salikh Zakirov wrote:
>> Gregory Shimansky wrote:
>>
>>> I think you could use 4.1.0 in Fedora Core 5. Since patch level
>>> shouldn't really affect the C++ compilation restrictions, the same patch
>>> should break on 4.1.0 as well.
>>
>> Gregory, I've looked at harmony-1635.patch you've uploaded to 
>> HARMONY-1635,
>> and I see that is based on the outdated patch from HARMONY-1635.
>> (i.e. not the latest version: heap-iteration-optimized.patch).
> 
> Ok I didn't realize which one to take.
> 
>> So I will upload the updated patch myself.
>> I've checked its compilation on Fedora Core 5 (Bordeaux) with gcc 4.1.0,
>> and it compiles okay.
> 
> In this case I think it should be committed. If I get any problems with 
> gcc 4.1.1 (which I don't have at hand right now) I'll try to resolve 
> them myself and create an additional fix.

I can confirm that gcc 4.1.1 compiled this patch without any problems. 
As I've written, patchlevel shouldn't matter here, and if gcc 4.1.0 
worked, 4.1.1 should work as well (with very rare exceptions). I've just 
built VM with it without any errors.


-- 
Gregory

Re: [drlvm] HARMONY-1635 heap iteration WAS: [general] version of GCC...

[Gregory Shimansky <gs...@gmail.com>]

Salikh Zakirov wrote:
> Gregory Shimansky wrote:
> 
>> I think you could use 4.1.0 in Fedora Core 5. Since patch level
>> shouldn't really affect the C++ compilation restrictions, the same patch
>> should break on 4.1.0 as well.
> 
> Gregory, I've looked at harmony-1635.patch you've uploaded to HARMONY-1635,
> and I see that is based on the outdated patch from HARMONY-1635.
> (i.e. not the latest version: heap-iteration-optimized.patch).

Ok I didn't realize which one to take.

> So I will upload the updated patch myself.
> I've checked its compilation on Fedora Core 5 (Bordeaux) with gcc 4.1.0,
> and it compiles okay.

In this case I think it should be committed. If I get any problems with 
gcc 4.1.1 (which I don't have at hand right now) I'll try to resolve 
them myself and create an additional fix.

> I've uploaded updated harmony-1635.patch to HARMONY-1635.

Thank you.

-- 
Gregory