You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Herve Boutemy (JIRA)" <ji...@codehaus.org> on 2012/12/01 04:01:14 UTC
[jira] (MNG-5395) logger name for plugins should not be
DefaultMavenPluginManager
Herve Boutemy created MNG-5395:
----------------------------------
Summary: logger name for plugins should not be DefaultMavenPluginManager
Key: MNG-5395
URL: https://jira.codehaus.org/browse/MNG-5395
Project: Maven 2 & 3
Issue Type: Bug
Components: Plugin Requests
Affects Versions: 3.0.4
Reporter: Herve Boutemy
there are discussion about what should be the best name for every logger in Maven, which hasn't come to a final decision yet.
But waiting for the final choice, actual value is completely wrong: every plugin uses the same logger that is the logger from DefaultMavenPluginManager
In actual spirit, the value should be the mojo class name
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5395) logger name for plugins should not be
DefaultMavenPluginManager
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MNG-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=314802#comment-314802 ]
Herve Boutemy commented on MNG-5395:
------------------------------------
I did a little local fix: the discussion on the global question (logger names, NDC, MDC, coding conventions, actual code state, ...) still need to be done
but no need to stay in the actual bogus situation, this fix will be useful to better see the actual code status
> logger name for plugins should not be DefaultMavenPluginManager
> ---------------------------------------------------------------
>
> Key: MNG-5395
> URL: https://jira.codehaus.org/browse/MNG-5395
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Plugin Requests
> Affects Versions: 3.0.4
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Fix For: 3.1.0
>
>
> there are discussion about what should be the best name for every logger in Maven, which hasn't come to a final decision yet.
> But waiting for the final choice, actual value is completely wrong: every plugin uses the same logger that is the logger from DefaultMavenPluginManager
> In actual spirit, the value should be the mojo class name
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5395) logger name for plugins should not be
DefaultMavenPluginManager
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MNG-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy closed MNG-5395.
------------------------------
Resolution: Fixed
Fix Version/s: 3.1.0
Assignee: Herve Boutemy
fixed in [fee1640d|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=fee1640d]
> logger name for plugins should not be DefaultMavenPluginManager
> ---------------------------------------------------------------
>
> Key: MNG-5395
> URL: https://jira.codehaus.org/browse/MNG-5395
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Plugin Requests
> Affects Versions: 3.0.4
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Fix For: 3.1.0
>
>
> there are discussion about what should be the best name for every logger in Maven, which hasn't come to a final decision yet.
> But waiting for the final choice, actual value is completely wrong: every plugin uses the same logger that is the logger from DefaultMavenPluginManager
> In actual spirit, the value should be the mojo class name
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5395) logger name for plugins should not be
DefaultMavenPluginManager
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MNG-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=314797#comment-314797 ]
Jason van Zyl commented on MNG-5395:
------------------------------------
I think what you did is the proper name. Classname is the standard way to go.
> logger name for plugins should not be DefaultMavenPluginManager
> ---------------------------------------------------------------
>
> Key: MNG-5395
> URL: https://jira.codehaus.org/browse/MNG-5395
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Plugin Requests
> Affects Versions: 3.0.4
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Fix For: 3.1.0
>
>
> there are discussion about what should be the best name for every logger in Maven, which hasn't come to a final decision yet.
> But waiting for the final choice, actual value is completely wrong: every plugin uses the same logger that is the logger from DefaultMavenPluginManager
> In actual spirit, the value should be the mojo class name
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira