You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/10/03 00:44:07 UTC

Re: Review Request 14441: Refactored (re-)registered message handlers in master to properly deal with authentication race.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14441/
-----------------------------------------------------------

(Updated Oct. 2, 2013, 10:44 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

rebase.


Summary (updated)
-----------------

Refactored (re-)registered message handlers in master to properly deal with authentication race.


Repository: mesos-git


Description
-------

The refactor was necessary to properly handle the race between scheduler registering with the master before the master realized that it authenticated it.


Diffs (updated)
-----

  src/master/master.hpp 0aeec7fc540d44c03c1171f31a7281a4b0055925 
  src/master/master.cpp ce8365f082a5f96ef64e33e526cb5047dff52127 
  src/sasl/authenticatee.hpp e1e18fedd0255400b2c98356970c0c5d664f6034 
  src/sasl/authenticator.hpp 2f78cf0fdd97f0ddc3a6ebd162e6559497d708e4 

Diff: https://reviews.apache.org/r/14441/diff/


Testing
-------

make check

./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest*:*Authentication*" --gtest_repeat=390 --gtest_break_on_failure --gtest_shuffle --verbose

./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest.FrameworkReliableRegistration*" --gtest_repeat=10000 --gtest_break_on_failure --gtest_shuffle --verbose


Thanks,

Vinod Kone