[GitHub] [doris] wangbo commented on a diff in pull request #8967: [optimize](storage)optimize date in storage layer

[GitBox <gi...@apache.org>]

wangbo commented on code in PR #8967:
URL: https://github.com/apache/doris/pull/8967#discussion_r902130781


##########
be/src/vec/columns/column_vector.h:
##########
@@ -169,17 +169,16 @@ class ColumnVector final : public COWHelper<ColumnVectorHelper, ColumnVector<T>>
     }
 
     void insert_date_column(const char* data_ptr, size_t num) {
-        size_t value_size = sizeof(uint24_t);
+        size_t input_value_size = sizeof(uint24_t);
+        
         for (int i = 0; i < num; i++) {

Review Comment:
   What's the difference?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org