You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/16 01:06:25 UTC
[GitHub] [apisix] membphis opened a new pull request #2435: CI: turn off the Lua code coverage check in CI.
membphis opened a new pull request #2435:
URL: https://github.com/apache/apisix/pull/2435
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
We don't enable Lua code override now, its output is unstable and this is unacceptable.
Disabling the Lua code override first will make CI run faster.
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2435: CI: turn off the Lua code coverage check in CI.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2435:
URL: https://github.com/apache/apisix/pull/2435#discussion_r505977953
##########
File path: .travis/linux_openresty_runner.sh
##########
@@ -169,7 +169,8 @@ script() {
sudo bash ./utils/check-plugins-code.sh
make lint && make license-check || exit 1
- APISIX_ENABLE_LUACOV=1 PERL5LIB=.:$PERL5LIB prove -Itest-nginx/lib -r t
+ # APISIX_ENABLE_LUACOV=1 PERL5LIB=.:$PERL5LIB prove -Itest-nginx/lib -r t
Review comment:
Could we remove this comment line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2435: CI: turn off the Lua code coverage check in CI.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2435:
URL: https://github.com/apache/apisix/pull/2435#discussion_r505978907
##########
File path: .travis/linux_openresty_runner.sh
##########
@@ -169,7 +169,8 @@ script() {
sudo bash ./utils/check-plugins-code.sh
make lint && make license-check || exit 1
- APISIX_ENABLE_LUACOV=1 PERL5LIB=.:$PERL5LIB prove -Itest-nginx/lib -r t
+ # APISIX_ENABLE_LUACOV=1 PERL5LIB=.:$PERL5LIB prove -Itest-nginx/lib -r t
Review comment:
we may enable it later, so I think we should keep the original version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #2435: CI: turn off the Lua code coverage check in CI.
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2435:
URL: https://github.com/apache/apisix/pull/2435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org