You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2021/10/06 09:55:07 UTC

[GitHub] [groovy] paulk-asert opened a new pull request #1638: GROOVY-10140: No compiler error for invalid transient method modifier

paulk-asert opened a new pull request #1638:
URL: https://github.com/apache/groovy/pull/1638


   This is an alternative to #1627. This version performs the check later. This allows frameworks to keep this feature so long as they remove the transient modifier bit (e.g. with an AST transform) before the `ClassCompletionVerifier` runs (CLASSGEN phase).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [groovy] danielsun1106 commented on pull request #1638: GROOVY-10140: No compiler error for invalid transient method modifier

Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1638:
URL: https://github.com/apache/groovy/pull/1638#issuecomment-937838568






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [groovy] danielsun1106 commented on pull request #1638: GROOVY-10140: No compiler error for invalid transient method modifier

Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1638:
URL: https://github.com/apache/groovy/pull/1638#issuecomment-937838568


   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [groovy] danielsun1106 merged pull request #1638: GROOVY-10140: No compiler error for invalid transient method modifier

Posted by GitBox <gi...@apache.org>.
danielsun1106 merged pull request #1638:
URL: https://github.com/apache/groovy/pull/1638


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [groovy] danielsun1106 merged pull request #1638: GROOVY-10140: No compiler error for invalid transient method modifier

Posted by GitBox <gi...@apache.org>.
danielsun1106 merged pull request #1638:
URL: https://github.com/apache/groovy/pull/1638


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [groovy] danielsun1106 commented on pull request #1638: GROOVY-10140: No compiler error for invalid transient method modifier

Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1638:
URL: https://github.com/apache/groovy/pull/1638#issuecomment-937878067


   Merged. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org