You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/05 06:22:08 UTC
[GitHub] [tvm] cery999 opened a new pull request, #12702: support false-positive fast math
cery999 opened a new pull request, #12702:
URL: https://github.com/apache/tvm/pull/12702
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wzh99 commented on pull request #12702: support false-positive fast math
Posted by GitBox <gi...@apache.org>.
wzh99 commented on PR #12702:
URL: https://github.com/apache/tvm/pull/12702#issuecomment-1236803922
@cery999 I am the author of #11696. Thanks for your efforts in sending this PR. The reason why I did not fix this myself is that I have no idea whether this inconsistency should be regarded as a bug indeed, or an undefined behavior.
@masahi Would you please take a look at this PR and decide whether we should fix the inconsistency between `tanh` and `fast_tanh` on `nan` input, or leave it alone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cery999 commented on a diff in pull request #12702: support false-positive fast math
Posted by GitBox <gi...@apache.org>.
cery999 commented on code in PR #12702:
URL: https://github.com/apache/tvm/pull/12702#discussion_r964320563
##########
apps/android_camera/models/requirements.txt:
##########
@@ -1,4 +1,4 @@
-keras
+keras==2.9.0
mxnet
scipy
-tensorflow
\ No newline at end of file
+tensorflow
Review Comment:
I remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cery999 commented on pull request #12702: support false-positive fast math
Posted by GitBox <gi...@apache.org>.
cery999 commented on PR #12702:
URL: https://github.com/apache/tvm/pull/12702#issuecomment-1237601869
>
I think this is turely a but, it the grad to be nan, it need to abandon this grad and do next iter, and grad scaler need to be updated , if the result will mistakenly be number, the grad scaler will never make sense. so we need to solve it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cery999 commented on pull request #12702: support false-positive fast math
Posted by GitBox <gi...@apache.org>.
cery999 commented on PR #12702:
URL: https://github.com/apache/tvm/pull/12702#issuecomment-1237588243
> @tvm-bot rerun
from tensorflow.python.trackable import base as trackable
[150](https://github.com/apache/tvm/runs/8194885989?check_suite_focus=true#step:11:151)
ModuleNotFoundError: No module named 'tensorflow.python.trackable'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #12702: support false-positive fast math
Posted by GitBox <gi...@apache.org>.
masahi merged PR #12702:
URL: https://github.com/apache/tvm/pull/12702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cery999 commented on pull request #12702: support false-positive fast math
Posted by GitBox <gi...@apache.org>.
cery999 commented on PR #12702:
URL: https://github.com/apache/tvm/pull/12702#issuecomment-1237588962
> @cery999 I am the author of #11696. Thanks for your efforts in sending this PR. The reason why I did not fix this myself is that I have no idea whether this inconsistency should be regarded as a bug indeed, or an undefined behavior.
>
> @masahi Would you please take a look at this PR and decide whether we should fix the inconsistency between `tanh` and `fast_tanh` on `nan` input, or leave it alone?
yes , I saw this issue , but find no fix, so I push it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #12702: support false-positive fast math
Posted by GitBox <gi...@apache.org>.
masahi commented on code in PR #12702:
URL: https://github.com/apache/tvm/pull/12702#discussion_r963526893
##########
apps/android_camera/models/requirements.txt:
##########
@@ -1,4 +1,4 @@
-keras
+keras==2.9.0
mxnet
scipy
-tensorflow
\ No newline at end of file
+tensorflow
Review Comment:
Please drop this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cery999 commented on pull request #12702: support false-positive fast math
Posted by GitBox <gi...@apache.org>.
cery999 commented on PR #12702:
URL: https://github.com/apache/tvm/pull/12702#issuecomment-1236582958
@alexeyr hi, fix the false positive for fast math
case is
nan < 9 ? nan : 9
1 < nan ? 1 : nan
which will case nan to be number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #12702: support false-positive fast math
Posted by GitBox <gi...@apache.org>.
masahi commented on PR #12702:
URL: https://github.com/apache/tvm/pull/12702#issuecomment-1237949891
Please wait until https://github.com/apache/tvm/pull/12710 lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wzh99 commented on pull request #12702: support false-positive fast math
Posted by GitBox <gi...@apache.org>.
wzh99 commented on PR #12702:
URL: https://github.com/apache/tvm/pull/12702#issuecomment-1237561584
@masahi The Android CI still fails. It seems that there is something wrong with the Android CI environment. There is an error in "Build android_camera":
```
Traceback (most recent call last):
File "prepare_model.py", line 139, in <module>
main(model, output_path)
File "prepare_model.py", line 94, in main
net, params = get_model(model_str)
File "prepare_model.py", line 63, in get_model
import keras
File "/home/runner/.local/lib/python3.8/site-packages/keras/__init__.py", line 21, in <module>
from keras import models
File "/home/runner/.local/lib/python3.8/site-packages/keras/models/__init__.py", line 18, in <module>
from keras.engine.functional import Functional
File "/home/runner/.local/lib/python3.8/site-packages/keras/engine/functional.py", line 27, in <module>
from keras.dtensor import layout_map as layout_map_lib
File "/home/runner/.local/lib/python3.8/site-packages/keras/dtensor/layout_map.py", line 25, in <module>
from keras.dtensor import lazy_variable
File "/home/runner/.local/lib/python3.8/site-packages/keras/dtensor/lazy_variable.py", line 26, in <module>
from tensorflow.python.trackable import base as trackable
ModuleNotFoundError: No module named 'tensorflow.python.trackable'
Error: Process completed with exit code 1.
```
I also notice that there is another error message in CI:
```
ERROR: tensorflow 2.9.2 has requirement keras<2.10.0,>=2.9.0rc0, but you'll have keras 2.10.0 which is incompatible.
```
I guess the failure is caused by the incompatible version of Keras with TensorFlow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #12702: support false-positive fast math
Posted by GitBox <gi...@apache.org>.
masahi commented on PR #12702:
URL: https://github.com/apache/tvm/pull/12702#issuecomment-1237395459
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cery999 commented on pull request #12702: support false-positive fast math
Posted by GitBox <gi...@apache.org>.
cery999 commented on PR #12702:
URL: https://github.com/apache/tvm/pull/12702#issuecomment-1238909291
> Please wait until #12710 lands.
fixed, @masahi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org