You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Rakesh Gupta <ra...@gmail.com> on 2024/10/22 12:41:17 UTC

Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/
-----------------------------------------------------------

Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4692
    https://issues.apache.org/jira/browse/RANGER-4692


Repository: ranger


Description
-------

Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.

when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 6c48c49f4 
  security-admin/db/mysql/patches/075-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 551660ab4 
  security-admin/db/oracle/patches/069-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 34a092e89 
  security-admin/db/postgres/patches/075-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 792fffd8d 
  security-admin/db/sqlanywhere/patches/069-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql eccf7f46f 
  security-admin/db/sqlserver/patches/069-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 00062f3e2 
  security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
  security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 


Diff: https://reviews.apache.org/r/75238/diff/1/


Testing
-------

Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:

/service/plugins/info?sortType=desc&sortBy=policyDownloadTime
/service/plugins/info?sortType=desc&sortBy=policyActivationTime
/service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
/service/plugins/info?sortType=desc&sortBy=tagDownloadTime
/service/plugins/info?sortType=desc&sortBy=tagActivationTime
/service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
/service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
/service/plugins/info?sortType=desc&sortBy=gdsActivationTime
/service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
/service/plugins/info?sortType=desc&sortBy=roleDownloadTime
/service/plugins/info?sortType=desc&sortBy=roleActivationTime
/service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
/service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
/service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
/service/plugins/info?sortType=desc&sortBy=clusterName
/service/plugins/info?sortType=desc&sortBy=serviceType

Also tested filtering by:
/service/plugins/info?serviceType={serviceTypeName}
/service/plugins/info?clusterName={clusterName}


Thanks,

Rakesh Gupta


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/#review227025
-----------------------------------------------------------




security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql
Lines 1626 (patched)
<https://reviews.apache.org/r/75238/#comment315291>

    "IF EXISTS" not needed in CREATE INDEX statements?



security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql
Lines 1645 (patched)
<https://reviews.apache.org/r/75238/#comment315289>

    Replace JOINs with LEFT OUTER JOIN, so that the view will return exactly one row for each row in x_plugin_info, irrespective of presence of corresponding entries in x_service/x_service_version_info/x_service_def tables.
    
    SELECT ...
      FROM x_plugin_info xpi
      LEFT OUTER JOIN x_service xs                ON xs.name = xpi.service_name
      LEFT OUTER JOIN x_service_version_info xsvi ON xsvi.service.id = xs.id
      LEFT OUTER JOIN x_service_def xsd           ON xsd.id = xs.`type`


- Madhan Neethiraj


On Nov. 4, 2024, 12:31 p.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75238/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2024, 12:31 p.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4692
>     https://issues.apache.org/jira/browse/RANGER-4692
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.
> 
> when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
>   security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
>   security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
>   security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
>   security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
>   security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
>   security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 
> 
> 
> Diff: https://reviews.apache.org/r/75238/diff/2/
> 
> 
> Testing
> -------
> 
> Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:
> 
> /service/plugins/info?sortType=desc&sortBy=policyDownloadTime
> /service/plugins/info?sortType=desc&sortBy=policyActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
> /service/plugins/info?sortType=desc&sortBy=tagDownloadTime
> /service/plugins/info?sortType=desc&sortBy=tagActivationTime
> /service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
> /service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
> /service/plugins/info?sortType=desc&sortBy=gdsActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
> /service/plugins/info?sortType=desc&sortBy=roleDownloadTime
> /service/plugins/info?sortType=desc&sortBy=roleActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
> /service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
> /service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
> /service/plugins/info?sortType=desc&sortBy=clusterName
> /service/plugins/info?sortType=desc&sortBy=serviceType
> 
> Also tested filtering by:
> /service/plugins/info?serviceType={serviceTypeName}
> /service/plugins/info?clusterName={clusterName}
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/#review227098
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Nov. 29, 2024, 7:05 a.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75238/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2024, 7:05 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4692
>     https://issues.apache.org/jira/browse/RANGER-4692
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.
> 
> when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
>   security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
>   security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
>   security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
>   security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
>   security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
>   security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 
> 
> 
> Diff: https://reviews.apache.org/r/75238/diff/7/
> 
> 
> Testing
> -------
> 
> Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:
> 
> /service/plugins/info?sortType=desc&sortBy=policyDownloadTime
> /service/plugins/info?sortType=desc&sortBy=policyActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
> /service/plugins/info?sortType=desc&sortBy=tagDownloadTime
> /service/plugins/info?sortType=desc&sortBy=tagActivationTime
> /service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
> /service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
> /service/plugins/info?sortType=desc&sortBy=gdsActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
> /service/plugins/info?sortType=desc&sortBy=roleDownloadTime
> /service/plugins/info?sortType=desc&sortBy=roleActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
> /service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
> /service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
> /service/plugins/info?sortType=desc&sortBy=clusterName
> /service/plugins/info?sortType=desc&sortBy=serviceType
> 
> Also tested filtering by:
> /service/plugins/info?serviceType={serviceTypeName}
> /service/plugins/info?clusterName={clusterName}
> 
> 
> Tested Java patch for upgrade scenario: completed processing 1,00,009 records in 21 seconds.
> Here’s are contents from ranger_db_patch.log:
> 
> 2024-11-19 12:19:25,941 [main]      INFO  Found 100009 plugin info records to process.
> 2024-11-19 12:19:26,537 [Thread-10] INFO  PROGRESS: 1000 plugin status records processed.
> 2024-11-19 12:19:26,890 [Thread-12] INFO  PROGRESS: 2000 plugin status records processed.
> 2024-11-19 12:19:27,222 [Thread-11] INFO  PROGRESS: 3000 plugin status records processed.
> ...
> 2024-11-19 12:19:46,647 [Thread-11] INFO  PROGRESS: 99000 plugin status records processed.
> 2024-11-19 12:19:46,808 [Thread-10] INFO  PROGRESS: 100000 plugin status records processed.
> 2024-11-19 12:19:46,813 [main]      INFO  Loading completed!!!. Time taken=21secs, 660ms
> 2024-11-19 12:19:46,813 [Loader Monitor] INFO  Monitor Thread exiting!!!
> 2024-11-19 12:19:46,902 [main] INFO  Load complete. Exiting!!!
> 
> Performance Results:
> API Endpoint: /service/plugins/plugins/info
> 
> Pre-Patch:
> Response Time for pageSize=10,000: 1 minute 59.28 seconds
> 
> Post-Patch:
> pageSize=10,000: 590 ms.
> pageSize=50,000: 1420 ms.
> pageSize=1,00,000: 2.73 s
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/
-----------------------------------------------------------

(Updated Oct. 6, 2025, 12:18 p.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Rebased patch


Bugs: RANGER-4692
    https://issues.apache.org/jira/browse/RANGER-4692


Repository: ranger


Description
-------

Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.

when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java f3396c497 
  dev-support/checkstyle-suppressions.xml 624016707 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql f0448738e 
  security-admin/db/mysql/patches/077-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 64e998e24 
  security-admin/db/oracle/patches/077-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 8b0d8ae6e 
  security-admin/db/postgres/patches/077-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 259225314 
  security-admin/db/sqlanywhere/patches/077-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql ac95cd2b8 
  security-admin/db/sqlserver/patches/077-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java b460d0762 
  security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java 6762a850c 
  security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 747abd223 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerPluginInfoService.java e3cf5ff58 


Diff: https://reviews.apache.org/r/75238/diff/8/

Changes: https://reviews.apache.org/r/75238/diff/7-8/


Testing
-------

Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:

/service/plugins/info?sortType=desc&sortBy=policyDownloadTime
/service/plugins/info?sortType=desc&sortBy=policyActivationTime
/service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
/service/plugins/info?sortType=desc&sortBy=tagDownloadTime
/service/plugins/info?sortType=desc&sortBy=tagActivationTime
/service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
/service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
/service/plugins/info?sortType=desc&sortBy=gdsActivationTime
/service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
/service/plugins/info?sortType=desc&sortBy=roleDownloadTime
/service/plugins/info?sortType=desc&sortBy=roleActivationTime
/service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
/service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
/service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
/service/plugins/info?sortType=desc&sortBy=clusterName
/service/plugins/info?sortType=desc&sortBy=serviceType

Also tested filtering by:
/service/plugins/info?serviceType={serviceTypeName}
/service/plugins/info?clusterName={clusterName}


Tested Java patch for upgrade scenario: completed processing 1,00,009 records in 21 seconds.
Here’s are contents from ranger_db_patch.log:

2024-11-19 12:19:25,941 [main]      INFO  Found 100009 plugin info records to process.
2024-11-19 12:19:26,537 [Thread-10] INFO  PROGRESS: 1000 plugin status records processed.
2024-11-19 12:19:26,890 [Thread-12] INFO  PROGRESS: 2000 plugin status records processed.
2024-11-19 12:19:27,222 [Thread-11] INFO  PROGRESS: 3000 plugin status records processed.
...
2024-11-19 12:19:46,647 [Thread-11] INFO  PROGRESS: 99000 plugin status records processed.
2024-11-19 12:19:46,808 [Thread-10] INFO  PROGRESS: 100000 plugin status records processed.
2024-11-19 12:19:46,813 [main]      INFO  Loading completed!!!. Time taken=21secs, 660ms
2024-11-19 12:19:46,813 [Loader Monitor] INFO  Monitor Thread exiting!!!
2024-11-19 12:19:46,902 [main] INFO  Load complete. Exiting!!!

Performance Results:
API Endpoint: /service/plugins/plugins/info

Pre-Patch:
Response Time for pageSize=10,000: 1 minute 59.28 seconds

Post-Patch:
pageSize=10,000: 590 ms.
pageSize=50,000: 1420 ms.
pageSize=1,00,000: 2.73 s


Thanks,

Rakesh Gupta


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/
-----------------------------------------------------------

(Updated Nov. 29, 2024, 7:05 a.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Addresses Review Comment


Bugs: RANGER-4692
    https://issues.apache.org/jira/browse/RANGER-4692


Repository: ranger


Description
-------

Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.

when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
  security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
  security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
  security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
  security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
  security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
  security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
  security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 


Diff: https://reviews.apache.org/r/75238/diff/7/

Changes: https://reviews.apache.org/r/75238/diff/6-7/


Testing
-------

Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:

/service/plugins/info?sortType=desc&sortBy=policyDownloadTime
/service/plugins/info?sortType=desc&sortBy=policyActivationTime
/service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
/service/plugins/info?sortType=desc&sortBy=tagDownloadTime
/service/plugins/info?sortType=desc&sortBy=tagActivationTime
/service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
/service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
/service/plugins/info?sortType=desc&sortBy=gdsActivationTime
/service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
/service/plugins/info?sortType=desc&sortBy=roleDownloadTime
/service/plugins/info?sortType=desc&sortBy=roleActivationTime
/service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
/service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
/service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
/service/plugins/info?sortType=desc&sortBy=clusterName
/service/plugins/info?sortType=desc&sortBy=serviceType

Also tested filtering by:
/service/plugins/info?serviceType={serviceTypeName}
/service/plugins/info?clusterName={clusterName}


Tested Java patch for upgrade scenario: completed processing 1,00,009 records in 21 seconds.
Here’s are contents from ranger_db_patch.log:

2024-11-19 12:19:25,941 [main]      INFO  Found 100009 plugin info records to process.
2024-11-19 12:19:26,537 [Thread-10] INFO  PROGRESS: 1000 plugin status records processed.
2024-11-19 12:19:26,890 [Thread-12] INFO  PROGRESS: 2000 plugin status records processed.
2024-11-19 12:19:27,222 [Thread-11] INFO  PROGRESS: 3000 plugin status records processed.
...
2024-11-19 12:19:46,647 [Thread-11] INFO  PROGRESS: 99000 plugin status records processed.
2024-11-19 12:19:46,808 [Thread-10] INFO  PROGRESS: 100000 plugin status records processed.
2024-11-19 12:19:46,813 [main]      INFO  Loading completed!!!. Time taken=21secs, 660ms
2024-11-19 12:19:46,813 [Loader Monitor] INFO  Monitor Thread exiting!!!
2024-11-19 12:19:46,902 [main] INFO  Load complete. Exiting!!!

Performance Results:
API Endpoint: /service/plugins/plugins/info

Pre-Patch:
Response Time for pageSize=10,000: 1 minute 59.28 seconds

Post-Patch:
pageSize=10,000: 590 ms.
pageSize=50,000: 1420 ms.
pageSize=1,00,000: 2.73 s


Thanks,

Rakesh Gupta


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Rakesh Gupta <ra...@gmail.com>.

> On Nov. 28, 2024, 8:34 p.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java
> > Lines 95 (patched)
> > <https://reviews.apache.org/r/75238/diff/5-6/?file=2294713#file2294713line97>
> >
> >     Why is @JsonIgnore needed for clusterName attribute?
> 
> Rakesh Gupta wrote:
>     We added @JsonIgnore to ensure the clusterName attribute does not appear twice in the response: once as a separate variable and once within the info map. This change was made to maintain consistency with the existing behavior.
>     e.g.
>     {
>       "clusterName": "Cluster 1",
>       "info": {
>         "clusterName": "Cluster 1"
>       }
>     }

Please ignore the above comment.


- Rakesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/#review227091
-----------------------------------------------------------


On Nov. 28, 2024, 3:05 p.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75238/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2024, 3:05 p.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4692
>     https://issues.apache.org/jira/browse/RANGER-4692
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.
> 
> when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
>   security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
>   security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
>   security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
>   security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
>   security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
>   security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 
> 
> 
> Diff: https://reviews.apache.org/r/75238/diff/6/
> 
> 
> Testing
> -------
> 
> Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:
> 
> /service/plugins/info?sortType=desc&sortBy=policyDownloadTime
> /service/plugins/info?sortType=desc&sortBy=policyActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
> /service/plugins/info?sortType=desc&sortBy=tagDownloadTime
> /service/plugins/info?sortType=desc&sortBy=tagActivationTime
> /service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
> /service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
> /service/plugins/info?sortType=desc&sortBy=gdsActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
> /service/plugins/info?sortType=desc&sortBy=roleDownloadTime
> /service/plugins/info?sortType=desc&sortBy=roleActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
> /service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
> /service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
> /service/plugins/info?sortType=desc&sortBy=clusterName
> /service/plugins/info?sortType=desc&sortBy=serviceType
> 
> Also tested filtering by:
> /service/plugins/info?serviceType={serviceTypeName}
> /service/plugins/info?clusterName={clusterName}
> 
> 
> Tested Java patch for upgrade scenario: completed processing 1,00,009 records in 21 seconds.
> Here’s are contents from ranger_db_patch.log:
> 
> 2024-11-19 12:19:25,941 [main]      INFO  Found 100009 plugin info records to process.
> 2024-11-19 12:19:26,537 [Thread-10] INFO  PROGRESS: 1000 plugin status records processed.
> 2024-11-19 12:19:26,890 [Thread-12] INFO  PROGRESS: 2000 plugin status records processed.
> 2024-11-19 12:19:27,222 [Thread-11] INFO  PROGRESS: 3000 plugin status records processed.
> ...
> 2024-11-19 12:19:46,647 [Thread-11] INFO  PROGRESS: 99000 plugin status records processed.
> 2024-11-19 12:19:46,808 [Thread-10] INFO  PROGRESS: 100000 plugin status records processed.
> 2024-11-19 12:19:46,813 [main]      INFO  Loading completed!!!. Time taken=21secs, 660ms
> 2024-11-19 12:19:46,813 [Loader Monitor] INFO  Monitor Thread exiting!!!
> 2024-11-19 12:19:46,902 [main] INFO  Load complete. Exiting!!!
> 
> Performance Results:
> API Endpoint: /service/plugins/plugins/info
> 
> Pre-Patch:
> Response Time for pageSize=10,000: 1 minute 59.28 seconds
> 
> Post-Patch:
> pageSize=10,000: 590 ms.
> pageSize=50,000: 1420 ms.
> pageSize=1,00,000: 2.73 s
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Rakesh Gupta <ra...@gmail.com>.

> On Nov. 28, 2024, 8:34 p.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java
> > Lines 95 (patched)
> > <https://reviews.apache.org/r/75238/diff/5-6/?file=2294713#file2294713line97>
> >
> >     Why is @JsonIgnore needed for clusterName attribute?

We added @JsonIgnore to ensure the clusterName attribute does not appear twice in the response: once as a separate variable and once within the info map. This change was made to maintain consistency with the existing behavior.
e.g.
{
  "clusterName": "Cluster 1",
  "info": {
    "clusterName": "Cluster 1"
  }
}


- Rakesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/#review227091
-----------------------------------------------------------


On Nov. 28, 2024, 3:05 p.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75238/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2024, 3:05 p.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4692
>     https://issues.apache.org/jira/browse/RANGER-4692
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.
> 
> when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
>   security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
>   security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
>   security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
>   security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
>   security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
>   security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 
> 
> 
> Diff: https://reviews.apache.org/r/75238/diff/6/
> 
> 
> Testing
> -------
> 
> Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:
> 
> /service/plugins/info?sortType=desc&sortBy=policyDownloadTime
> /service/plugins/info?sortType=desc&sortBy=policyActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
> /service/plugins/info?sortType=desc&sortBy=tagDownloadTime
> /service/plugins/info?sortType=desc&sortBy=tagActivationTime
> /service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
> /service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
> /service/plugins/info?sortType=desc&sortBy=gdsActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
> /service/plugins/info?sortType=desc&sortBy=roleDownloadTime
> /service/plugins/info?sortType=desc&sortBy=roleActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
> /service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
> /service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
> /service/plugins/info?sortType=desc&sortBy=clusterName
> /service/plugins/info?sortType=desc&sortBy=serviceType
> 
> Also tested filtering by:
> /service/plugins/info?serviceType={serviceTypeName}
> /service/plugins/info?clusterName={clusterName}
> 
> 
> Tested Java patch for upgrade scenario: completed processing 1,00,009 records in 21 seconds.
> Here’s are contents from ranger_db_patch.log:
> 
> 2024-11-19 12:19:25,941 [main]      INFO  Found 100009 plugin info records to process.
> 2024-11-19 12:19:26,537 [Thread-10] INFO  PROGRESS: 1000 plugin status records processed.
> 2024-11-19 12:19:26,890 [Thread-12] INFO  PROGRESS: 2000 plugin status records processed.
> 2024-11-19 12:19:27,222 [Thread-11] INFO  PROGRESS: 3000 plugin status records processed.
> ...
> 2024-11-19 12:19:46,647 [Thread-11] INFO  PROGRESS: 99000 plugin status records processed.
> 2024-11-19 12:19:46,808 [Thread-10] INFO  PROGRESS: 100000 plugin status records processed.
> 2024-11-19 12:19:46,813 [main]      INFO  Loading completed!!!. Time taken=21secs, 660ms
> 2024-11-19 12:19:46,813 [Loader Monitor] INFO  Monitor Thread exiting!!!
> 2024-11-19 12:19:46,902 [main] INFO  Load complete. Exiting!!!
> 
> Performance Results:
> API Endpoint: /service/plugins/plugins/info
> 
> Pre-Patch:
> Response Time for pageSize=10,000: 1 minute 59.28 seconds
> 
> Post-Patch:
> pageSize=10,000: 590 ms.
> pageSize=50,000: 1420 ms.
> pageSize=1,00,000: 2.73 s
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/#review227091
-----------------------------------------------------------


Fix it, then Ship it!





agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java
Lines 95 (patched)
<https://reviews.apache.org/r/75238/#comment315370>

    Why is @JsonIgnore needed for clusterName attribute?


- Madhan Neethiraj


On Nov. 28, 2024, 3:05 p.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75238/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2024, 3:05 p.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4692
>     https://issues.apache.org/jira/browse/RANGER-4692
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.
> 
> when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
>   security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
>   security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
>   security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
>   security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
>   security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
>   security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 
> 
> 
> Diff: https://reviews.apache.org/r/75238/diff/6/
> 
> 
> Testing
> -------
> 
> Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:
> 
> /service/plugins/info?sortType=desc&sortBy=policyDownloadTime
> /service/plugins/info?sortType=desc&sortBy=policyActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
> /service/plugins/info?sortType=desc&sortBy=tagDownloadTime
> /service/plugins/info?sortType=desc&sortBy=tagActivationTime
> /service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
> /service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
> /service/plugins/info?sortType=desc&sortBy=gdsActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
> /service/plugins/info?sortType=desc&sortBy=roleDownloadTime
> /service/plugins/info?sortType=desc&sortBy=roleActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
> /service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
> /service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
> /service/plugins/info?sortType=desc&sortBy=clusterName
> /service/plugins/info?sortType=desc&sortBy=serviceType
> 
> Also tested filtering by:
> /service/plugins/info?serviceType={serviceTypeName}
> /service/plugins/info?clusterName={clusterName}
> 
> 
> Tested Java patch for upgrade scenario: completed processing 1,00,009 records in 21 seconds.
> Here’s are contents from ranger_db_patch.log:
> 
> 2024-11-19 12:19:25,941 [main]      INFO  Found 100009 plugin info records to process.
> 2024-11-19 12:19:26,537 [Thread-10] INFO  PROGRESS: 1000 plugin status records processed.
> 2024-11-19 12:19:26,890 [Thread-12] INFO  PROGRESS: 2000 plugin status records processed.
> 2024-11-19 12:19:27,222 [Thread-11] INFO  PROGRESS: 3000 plugin status records processed.
> ...
> 2024-11-19 12:19:46,647 [Thread-11] INFO  PROGRESS: 99000 plugin status records processed.
> 2024-11-19 12:19:46,808 [Thread-10] INFO  PROGRESS: 100000 plugin status records processed.
> 2024-11-19 12:19:46,813 [main]      INFO  Loading completed!!!. Time taken=21secs, 660ms
> 2024-11-19 12:19:46,813 [Loader Monitor] INFO  Monitor Thread exiting!!!
> 2024-11-19 12:19:46,902 [main] INFO  Load complete. Exiting!!!
> 
> Performance Results:
> API Endpoint: /service/plugins/plugins/info
> 
> Pre-Patch:
> Response Time for pageSize=10,000: 1 minute 59.28 seconds
> 
> Post-Patch:
> pageSize=10,000: 590 ms.
> pageSize=50,000: 1420 ms.
> pageSize=1,00,000: 2.73 s
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/
-----------------------------------------------------------

(Updated Nov. 28, 2024, 3:05 p.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Addressed Review Comments.


Bugs: RANGER-4692
    https://issues.apache.org/jira/browse/RANGER-4692


Repository: ranger


Description
-------

Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.

when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
  security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
  security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
  security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
  security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
  security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
  security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
  security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 


Diff: https://reviews.apache.org/r/75238/diff/6/

Changes: https://reviews.apache.org/r/75238/diff/5-6/


Testing
-------

Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:

/service/plugins/info?sortType=desc&sortBy=policyDownloadTime
/service/plugins/info?sortType=desc&sortBy=policyActivationTime
/service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
/service/plugins/info?sortType=desc&sortBy=tagDownloadTime
/service/plugins/info?sortType=desc&sortBy=tagActivationTime
/service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
/service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
/service/plugins/info?sortType=desc&sortBy=gdsActivationTime
/service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
/service/plugins/info?sortType=desc&sortBy=roleDownloadTime
/service/plugins/info?sortType=desc&sortBy=roleActivationTime
/service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
/service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
/service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
/service/plugins/info?sortType=desc&sortBy=clusterName
/service/plugins/info?sortType=desc&sortBy=serviceType

Also tested filtering by:
/service/plugins/info?serviceType={serviceTypeName}
/service/plugins/info?clusterName={clusterName}


Tested Java patch for upgrade scenario: completed processing 1,00,009 records in 21 seconds.
Here’s are contents from ranger_db_patch.log:

2024-11-19 12:19:25,941 [main]      INFO  Found 100009 plugin info records to process.
2024-11-19 12:19:26,537 [Thread-10] INFO  PROGRESS: 1000 plugin status records processed.
2024-11-19 12:19:26,890 [Thread-12] INFO  PROGRESS: 2000 plugin status records processed.
2024-11-19 12:19:27,222 [Thread-11] INFO  PROGRESS: 3000 plugin status records processed.
...
2024-11-19 12:19:46,647 [Thread-11] INFO  PROGRESS: 99000 plugin status records processed.
2024-11-19 12:19:46,808 [Thread-10] INFO  PROGRESS: 100000 plugin status records processed.
2024-11-19 12:19:46,813 [main]      INFO  Loading completed!!!. Time taken=21secs, 660ms
2024-11-19 12:19:46,813 [Loader Monitor] INFO  Monitor Thread exiting!!!
2024-11-19 12:19:46,902 [main] INFO  Load complete. Exiting!!!

Performance Results:
API Endpoint: /service/plugins/plugins/info

Pre-Patch:
Response Time for pageSize=10,000: 1 minute 59.28 seconds

Post-Patch:
pageSize=10,000: 590 ms.
pageSize=50,000: 1420 ms.
pageSize=1,00,000: 2.73 s


Thanks,

Rakesh Gupta


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/#review227089
-----------------------------------------------------------




security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql
Line 1657 (original), 1658 (patched)
<https://reviews.apache.org/r/75238/#comment315368>

    With LEFT OUTER JOIN changed to INNER JOIN, the view will not return x_plugin_info row when its corresponding x_service row was deleted. Why was this change needed?
    
    With LEFT OUTER JOIN, all rows in x_plugin_info will be returned, with null as column value for non existing rows from referenced tables (x_service, x_service_def, x_service_version_info). The application code should be updated to handle null.


- Madhan Neethiraj


On Nov. 19, 2024, 9:35 a.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75238/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2024, 9:35 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4692
>     https://issues.apache.org/jira/browse/RANGER-4692
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.
> 
> when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
>   security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
>   security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
>   security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
>   security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
>   security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
>   security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 
> 
> 
> Diff: https://reviews.apache.org/r/75238/diff/5/
> 
> 
> Testing
> -------
> 
> Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:
> 
> /service/plugins/info?sortType=desc&sortBy=policyDownloadTime
> /service/plugins/info?sortType=desc&sortBy=policyActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
> /service/plugins/info?sortType=desc&sortBy=tagDownloadTime
> /service/plugins/info?sortType=desc&sortBy=tagActivationTime
> /service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
> /service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
> /service/plugins/info?sortType=desc&sortBy=gdsActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
> /service/plugins/info?sortType=desc&sortBy=roleDownloadTime
> /service/plugins/info?sortType=desc&sortBy=roleActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
> /service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
> /service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
> /service/plugins/info?sortType=desc&sortBy=clusterName
> /service/plugins/info?sortType=desc&sortBy=serviceType
> 
> Also tested filtering by:
> /service/plugins/info?serviceType={serviceTypeName}
> /service/plugins/info?clusterName={clusterName}
> 
> 
> Tested Java patch for upgrade scenario: completed processing 1,00,009 records in 21 seconds.
> Here’s are contents from ranger_db_patch.log:
> 
> 2024-11-19 12:19:25,941 [main]      INFO  Found 100009 plugin info records to process.
> 2024-11-19 12:19:26,537 [Thread-10] INFO  PROGRESS: 1000 plugin status records processed.
> 2024-11-19 12:19:26,890 [Thread-12] INFO  PROGRESS: 2000 plugin status records processed.
> 2024-11-19 12:19:27,222 [Thread-11] INFO  PROGRESS: 3000 plugin status records processed.
> ...
> 2024-11-19 12:19:46,647 [Thread-11] INFO  PROGRESS: 99000 plugin status records processed.
> 2024-11-19 12:19:46,808 [Thread-10] INFO  PROGRESS: 100000 plugin status records processed.
> 2024-11-19 12:19:46,813 [main]      INFO  Loading completed!!!. Time taken=21secs, 660ms
> 2024-11-19 12:19:46,813 [Loader Monitor] INFO  Monitor Thread exiting!!!
> 2024-11-19 12:19:46,902 [main] INFO  Load complete. Exiting!!!
> 
> Performance Results:
> API Endpoint: /service/plugins/plugins/info
> 
> Pre-Patch:
> Response Time for pageSize=10,000: 1 minute 59.28 seconds
> 
> Post-Patch:
> pageSize=10,000: 590 ms.
> pageSize=50,000: 1420 ms.
> pageSize=1,00,000: 2.73 s
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/#review227090
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java
Lines 484 (patched)
<https://reviews.apache.org/r/75238/#comment315369>

    Why do need to use setCapabilities() and getCapabilities() to set and get Cluster name? Please do it in normal way like other set and get are done.


- Ramesh Mani


On Nov. 19, 2024, 9:35 a.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75238/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2024, 9:35 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4692
>     https://issues.apache.org/jira/browse/RANGER-4692
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.
> 
> when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
>   security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
>   security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
>   security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
>   security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
>   security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
>   security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 
> 
> 
> Diff: https://reviews.apache.org/r/75238/diff/5/
> 
> 
> Testing
> -------
> 
> Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:
> 
> /service/plugins/info?sortType=desc&sortBy=policyDownloadTime
> /service/plugins/info?sortType=desc&sortBy=policyActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
> /service/plugins/info?sortType=desc&sortBy=tagDownloadTime
> /service/plugins/info?sortType=desc&sortBy=tagActivationTime
> /service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
> /service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
> /service/plugins/info?sortType=desc&sortBy=gdsActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
> /service/plugins/info?sortType=desc&sortBy=roleDownloadTime
> /service/plugins/info?sortType=desc&sortBy=roleActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
> /service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
> /service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
> /service/plugins/info?sortType=desc&sortBy=clusterName
> /service/plugins/info?sortType=desc&sortBy=serviceType
> 
> Also tested filtering by:
> /service/plugins/info?serviceType={serviceTypeName}
> /service/plugins/info?clusterName={clusterName}
> 
> 
> Tested Java patch for upgrade scenario: completed processing 1,00,009 records in 21 seconds.
> Here’s are contents from ranger_db_patch.log:
> 
> 2024-11-19 12:19:25,941 [main]      INFO  Found 100009 plugin info records to process.
> 2024-11-19 12:19:26,537 [Thread-10] INFO  PROGRESS: 1000 plugin status records processed.
> 2024-11-19 12:19:26,890 [Thread-12] INFO  PROGRESS: 2000 plugin status records processed.
> 2024-11-19 12:19:27,222 [Thread-11] INFO  PROGRESS: 3000 plugin status records processed.
> ...
> 2024-11-19 12:19:46,647 [Thread-11] INFO  PROGRESS: 99000 plugin status records processed.
> 2024-11-19 12:19:46,808 [Thread-10] INFO  PROGRESS: 100000 plugin status records processed.
> 2024-11-19 12:19:46,813 [main]      INFO  Loading completed!!!. Time taken=21secs, 660ms
> 2024-11-19 12:19:46,813 [Loader Monitor] INFO  Monitor Thread exiting!!!
> 2024-11-19 12:19:46,902 [main] INFO  Load complete. Exiting!!!
> 
> Performance Results:
> API Endpoint: /service/plugins/plugins/info
> 
> Pre-Patch:
> Response Time for pageSize=10,000: 1 minute 59.28 seconds
> 
> Post-Patch:
> pageSize=10,000: 590 ms.
> pageSize=50,000: 1420 ms.
> pageSize=1,00,000: 2.73 s
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/
-----------------------------------------------------------

(Updated Nov. 19, 2024, 9:35 a.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4692
    https://issues.apache.org/jira/browse/RANGER-4692


Repository: ranger


Description
-------

Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.

when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
  security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
  security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
  security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
  security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
  security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
  security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
  security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 


Diff: https://reviews.apache.org/r/75238/diff/5/


Testing (updated)
-------

Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:

/service/plugins/info?sortType=desc&sortBy=policyDownloadTime
/service/plugins/info?sortType=desc&sortBy=policyActivationTime
/service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
/service/plugins/info?sortType=desc&sortBy=tagDownloadTime
/service/plugins/info?sortType=desc&sortBy=tagActivationTime
/service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
/service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
/service/plugins/info?sortType=desc&sortBy=gdsActivationTime
/service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
/service/plugins/info?sortType=desc&sortBy=roleDownloadTime
/service/plugins/info?sortType=desc&sortBy=roleActivationTime
/service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
/service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
/service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
/service/plugins/info?sortType=desc&sortBy=clusterName
/service/plugins/info?sortType=desc&sortBy=serviceType

Also tested filtering by:
/service/plugins/info?serviceType={serviceTypeName}
/service/plugins/info?clusterName={clusterName}


Tested Java patch for upgrade scenario: completed processing 1,00,009 records in 21 seconds.
Here’s are contents from ranger_db_patch.log:

2024-11-19 12:19:25,941 [main]      INFO  Found 100009 plugin info records to process.
2024-11-19 12:19:26,537 [Thread-10] INFO  PROGRESS: 1000 plugin status records processed.
2024-11-19 12:19:26,890 [Thread-12] INFO  PROGRESS: 2000 plugin status records processed.
2024-11-19 12:19:27,222 [Thread-11] INFO  PROGRESS: 3000 plugin status records processed.
...
2024-11-19 12:19:46,647 [Thread-11] INFO  PROGRESS: 99000 plugin status records processed.
2024-11-19 12:19:46,808 [Thread-10] INFO  PROGRESS: 100000 plugin status records processed.
2024-11-19 12:19:46,813 [main]      INFO  Loading completed!!!. Time taken=21secs, 660ms
2024-11-19 12:19:46,813 [Loader Monitor] INFO  Monitor Thread exiting!!!
2024-11-19 12:19:46,902 [main] INFO  Load complete. Exiting!!!

Performance Results:
API Endpoint: /service/plugins/plugins/info

Pre-Patch:
Response Time for pageSize=10,000: 1 minute 59.28 seconds

Post-Patch:
pageSize=10,000: 590 ms.
pageSize=50,000: 1420 ms.
pageSize=1,00,000: 2.73 s


Thanks,

Rakesh Gupta


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/
-----------------------------------------------------------

(Updated Nov. 19, 2024, 9:29 a.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4692
    https://issues.apache.org/jira/browse/RANGER-4692


Repository: ranger


Description
-------

Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.

when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
  security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
  security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
  security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
  security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
  security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
  security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
  security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 


Diff: https://reviews.apache.org/r/75238/diff/5/

Changes: https://reviews.apache.org/r/75238/diff/4-5/


Testing
-------

Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:

/service/plugins/info?sortType=desc&sortBy=policyDownloadTime
/service/plugins/info?sortType=desc&sortBy=policyActivationTime
/service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
/service/plugins/info?sortType=desc&sortBy=tagDownloadTime
/service/plugins/info?sortType=desc&sortBy=tagActivationTime
/service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
/service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
/service/plugins/info?sortType=desc&sortBy=gdsActivationTime
/service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
/service/plugins/info?sortType=desc&sortBy=roleDownloadTime
/service/plugins/info?sortType=desc&sortBy=roleActivationTime
/service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
/service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
/service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
/service/plugins/info?sortType=desc&sortBy=clusterName
/service/plugins/info?sortType=desc&sortBy=serviceType

Also tested filtering by:
/service/plugins/info?serviceType={serviceTypeName}
/service/plugins/info?clusterName={clusterName}


Tested Java patch for upgrade scenario: completed processing 50,005 records in 12 seconds.
Here’s are contents from ranger_db_patch.log:

2024-11-11 15:14:57,286 [main] INFO  Found 50005 plugin info records to process.
2024-11-11 15:14:57,909 [Thread-12] INFO  PROGRESS: 1000 plugin status records processed.
2024-11-11 15:14:58,357 [Thread-14] INFO  PROGRESS: 2000 plugin status records processed.
...
2024-11-11 15:15:08,726 [Thread-13] INFO  PROGRESS: 48000 plugin status records processed.
2024-11-11 15:15:09,129 [Thread-12] INFO  PROGRESS: 50000 plugin status records processed.
2024-11-11 15:15:09,134 [main] INFO  Loading completed! Time taken=12secs, 311ms
2024-11-11 15:15:09,134 [Loader Monitor] INFO  Monitor Thread exiting!!!
2024-11-11 15:15:09,198 [main] INFO  Load complete. Exiting!


Thanks,

Rakesh Gupta


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/#review227050
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java
Line 304 (original), 299 (patched)
<https://reviews.apache.org/r/75238/#comment315343>

    Can hasAssociatedTagService flag be replaced with checking if xObj.getLatestTagVersion() is null?
    
    If yes, searchRangerPluginInfo() can be simplified to not retrieve servicesWithTagService and objectsList.


- Madhan Neethiraj


On Nov. 11, 2024, 11:53 a.m., Rakesh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75238/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2024, 11:53 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4692
>     https://issues.apache.org/jira/browse/RANGER-4692
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.
> 
> when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
>   security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
>   security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
>   security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
>   security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
>   security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
>   security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 
> 
> 
> Diff: https://reviews.apache.org/r/75238/diff/4/
> 
> 
> Testing
> -------
> 
> Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:
> 
> /service/plugins/info?sortType=desc&sortBy=policyDownloadTime
> /service/plugins/info?sortType=desc&sortBy=policyActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
> /service/plugins/info?sortType=desc&sortBy=tagDownloadTime
> /service/plugins/info?sortType=desc&sortBy=tagActivationTime
> /service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
> /service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
> /service/plugins/info?sortType=desc&sortBy=gdsActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
> /service/plugins/info?sortType=desc&sortBy=roleDownloadTime
> /service/plugins/info?sortType=desc&sortBy=roleActivationTime
> /service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
> /service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
> /service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
> /service/plugins/info?sortType=desc&sortBy=clusterName
> /service/plugins/info?sortType=desc&sortBy=serviceType
> 
> Also tested filtering by:
> /service/plugins/info?serviceType={serviceTypeName}
> /service/plugins/info?clusterName={clusterName}
> 
> 
> Tested Java patch for upgrade scenario: completed processing 50,005 records in 12 seconds.
> Here’s are contents from ranger_db_patch.log:
> 
> 2024-11-11 15:14:57,286 [main] INFO  Found 50005 plugin info records to process.
> 2024-11-11 15:14:57,909 [Thread-12] INFO  PROGRESS: 1000 plugin status records processed.
> 2024-11-11 15:14:58,357 [Thread-14] INFO  PROGRESS: 2000 plugin status records processed.
> ...
> 2024-11-11 15:15:08,726 [Thread-13] INFO  PROGRESS: 48000 plugin status records processed.
> 2024-11-11 15:15:09,129 [Thread-12] INFO  PROGRESS: 50000 plugin status records processed.
> 2024-11-11 15:15:09,134 [main] INFO  Loading completed! Time taken=12secs, 311ms
> 2024-11-11 15:15:09,134 [Loader Monitor] INFO  Monitor Thread exiting!!!
> 2024-11-11 15:15:09,198 [main] INFO  Load complete. Exiting!
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/
-----------------------------------------------------------

(Updated Nov. 11, 2024, 11:53 a.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4692
    https://issues.apache.org/jira/browse/RANGER-4692


Repository: ranger


Description
-------

Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.

when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
  security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
  security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
  security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
  security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
  security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
  security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
  security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 


Diff: https://reviews.apache.org/r/75238/diff/4/

Changes: https://reviews.apache.org/r/75238/diff/3-4/


Testing (updated)
-------

Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:

/service/plugins/info?sortType=desc&sortBy=policyDownloadTime
/service/plugins/info?sortType=desc&sortBy=policyActivationTime
/service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
/service/plugins/info?sortType=desc&sortBy=tagDownloadTime
/service/plugins/info?sortType=desc&sortBy=tagActivationTime
/service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
/service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
/service/plugins/info?sortType=desc&sortBy=gdsActivationTime
/service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
/service/plugins/info?sortType=desc&sortBy=roleDownloadTime
/service/plugins/info?sortType=desc&sortBy=roleActivationTime
/service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
/service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
/service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
/service/plugins/info?sortType=desc&sortBy=clusterName
/service/plugins/info?sortType=desc&sortBy=serviceType

Also tested filtering by:
/service/plugins/info?serviceType={serviceTypeName}
/service/plugins/info?clusterName={clusterName}


Tested Java patch for upgrade scenario: completed processing 50,005 records in 12 seconds.
Here’s are contents from ranger_db_patch.log:

2024-11-11 15:14:57,286 [main] INFO  Found 50005 plugin info records to process.
2024-11-11 15:14:57,909 [Thread-12] INFO  PROGRESS: 1000 plugin status records processed.
2024-11-11 15:14:58,357 [Thread-14] INFO  PROGRESS: 2000 plugin status records processed.
...
2024-11-11 15:15:08,726 [Thread-13] INFO  PROGRESS: 48000 plugin status records processed.
2024-11-11 15:15:09,129 [Thread-12] INFO  PROGRESS: 50000 plugin status records processed.
2024-11-11 15:15:09,134 [main] INFO  Loading completed! Time taken=12secs, 311ms
2024-11-11 15:15:09,134 [Loader Monitor] INFO  Monitor Thread exiting!!!
2024-11-11 15:15:09,198 [main] INFO  Load complete. Exiting!


Thanks,

Rakesh Gupta


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/
-----------------------------------------------------------

(Updated Nov. 7, 2024, 2:35 p.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Addressed Review Comments


Bugs: RANGER-4692
    https://issues.apache.org/jira/browse/RANGER-4692


Repository: ranger


Description
-------

Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.

when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
  security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
  security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
  security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
  security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
  security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
  security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
  security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 


Diff: https://reviews.apache.org/r/75238/diff/3/

Changes: https://reviews.apache.org/r/75238/diff/2-3/


Testing
-------

Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:

/service/plugins/info?sortType=desc&sortBy=policyDownloadTime
/service/plugins/info?sortType=desc&sortBy=policyActivationTime
/service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
/service/plugins/info?sortType=desc&sortBy=tagDownloadTime
/service/plugins/info?sortType=desc&sortBy=tagActivationTime
/service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
/service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
/service/plugins/info?sortType=desc&sortBy=gdsActivationTime
/service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
/service/plugins/info?sortType=desc&sortBy=roleDownloadTime
/service/plugins/info?sortType=desc&sortBy=roleActivationTime
/service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
/service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
/service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
/service/plugins/info?sortType=desc&sortBy=clusterName
/service/plugins/info?sortType=desc&sortBy=serviceType

Also tested filtering by:
/service/plugins/info?serviceType={serviceTypeName}
/service/plugins/info?clusterName={clusterName}


Thanks,

Rakesh Gupta


Re: Review Request 75238: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75238/
-----------------------------------------------------------

(Updated Nov. 4, 2024, 12:31 p.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4692
    https://issues.apache.org/jira/browse/RANGER-4692


Repository: ranger


Description
-------

Currently there are different type like (Policy, Role, Tag, UserStore and GDS) on plugin status.

when we have plugins(large enough to accommodate in single page), It will be helpful to identify any out-of-sync plugins based on download times, sorting them by policyDownloadTime, tagDownloadTime, roleDownloadTime, userstoreDownloadTime and gdsDownloadTime.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java 8d46b99f7 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 5fb0d95db 
  security-admin/db/mysql/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 593cffe56 
  security-admin/db/oracle/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 16263a2d7 
  security-admin/db/postgres/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql fa9832314 
  security-admin/db/sqlanywhere/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a0e47004b 
  security-admin/db/sqlserver/patches/076-add-columns-in-x_plugin_info.sql PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 620d1e619 
  security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java a15d8d056 
  security-admin/src/main/java/org/apache/ranger/entity/view/VXXPluginInfo.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForPluginStatusEventSorting_J10064.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java 9dc26ceb7 


Diff: https://reviews.apache.org/r/75238/diff/2/

Changes: https://reviews.apache.org/r/75238/diff/1-2/


Testing
-------

Tested and verified that the plugins are correctly sorted by event type (Policy, Role, Tag, UserStore, GDS) using the following APIs:

/service/plugins/info?sortType=desc&sortBy=policyDownloadTime
/service/plugins/info?sortType=desc&sortBy=policyActivationTime
/service/plugins/info?sortType=desc&sortBy=lastPolicyUpdateTime
/service/plugins/info?sortType=desc&sortBy=tagDownloadTime
/service/plugins/info?sortType=desc&sortBy=tagActivationTime
/service/plugins/info?sortType=desc&sortBy=lasttagUpdateTime
/service/plugins/info?sortType=desc&sortBy=gdsDownloadTime
/service/plugins/info?sortType=desc&sortBy=gdsActivationTime
/service/plugins/info?sortType=desc&sortBy=lastgdsUpdateTime
/service/plugins/info?sortType=desc&sortBy=roleDownloadTime
/service/plugins/info?sortType=desc&sortBy=roleActivationTime
/service/plugins/info?sortType=desc&sortBy=lastroleUpdateTime
/service/plugins/info?sortType=desc&sortBy=userstoreDownloadTime
/service/plugins/info?sortType=desc&sortBy=userstoreActivationTime
/service/plugins/info?sortType=desc&sortBy=clusterName
/service/plugins/info?sortType=desc&sortBy=serviceType

Also tested filtering by:
/service/plugins/info?serviceType={serviceTypeName}
/service/plugins/info?clusterName={clusterName}


Thanks,

Rakesh Gupta