You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/02/29 08:04:58 UTC

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
-----------------------------------------------------------

(Updated 二月 29, 2016, 7:04 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Changes
-------

Rebase


Bugs: MESOS-4801
    https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description (updated)
-------

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_tests.cpp 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
-------

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" --verbose


Thanks,

Guangya Liu


Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review123995
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42386]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 17, 2016, 1:12 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 1:12 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
>     https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 459e02576f6d05abbbcc83ae5cabac5c66e93f05 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> -------
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
-----------------------------------------------------------

(Updated 三月 17, 2016, 1:12 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4801
    https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description
-------

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_tests.cpp 459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
-------

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" --verbose


Thanks,

Guangya Liu


Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review123361
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42386]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 14, 2016, 4:03 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 4:03 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
>     https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 459e02576f6d05abbbcc83ae5cabac5c66e93f05 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> -------
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
-----------------------------------------------------------

(Updated 三月 14, 2016, 4:03 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4801
    https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description
-------

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_tests.cpp 459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
-------

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" --verbose


Thanks,

Guangya Liu


Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
-----------------------------------------------------------

(Updated 三月 11, 2016, 9:10 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4801
    https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description
-------

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_tests.cpp 459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
-------

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" --verbose


Thanks,

Guangya Liu


Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review121206
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42386]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 7:04 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 7:04 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
>     https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> -------
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>