You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2016/05/24 04:10:17 UTC
[GitHub] incubator-guacamole-client pull request: GUACAMOLE-25: Only stream...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/9
GUACAMOLE-25: Only stream audio when requested.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client audio-input-bandwidth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
----
commit 4b88066f26a42f3b57036b4a3945d64269689fcf
Author: Michael Jumper <mj...@apache.org>
Date: 2016-05-02T05:29:29Z
GUACAMOLE-25: Only capture as long as stream is open.
commit df3347f63110c14ce7394352cc144911f862a694
Author: Michael Jumper <mj...@apache.org>
Date: 2016-05-02T06:51:18Z
GUACAMOLE-25: Automatically invalidate output stream due to "ack" ONLY if it's the same stream that received the "ack". It is possible for the output stream to be freed and replaced with a different stream within onack.
commit d0533d097feb19927feb5a546716f5fbea75deba
Author: Michael Jumper <mj...@apache.org>
Date: 2016-05-02T06:51:50Z
GUACAMOLE-25: Implement new "RESOURCE_CLOSED" status code.
commit c32a779825732a27f130e26bc73aa5f60566608c
Author: Michael Jumper <mj...@apache.org>
Date: 2016-05-02T07:12:23Z
GUACAMOLE-25: Add onclose/onerror handlers to Guacamole.AudioRecorder.
commit 421294490b2e44367fca1c6b97533035eb78a950
Author: Michael Jumper <mj...@apache.org>
Date: 2016-05-02T07:39:03Z
GUACAMOLE-25: Automatically reestablish audio stream when it closes normally.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request: GUACAMOLE-25: Only stream...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/9#discussion_r64326254
--- Diff: guacamole-common-js/src/main/webapp/modules/AudioRecorder.js ---
@@ -213,6 +240,14 @@ Guacamole.RawAudioRecorder = function RawAudioRecorder(stream, mimetype) {
var writtenSamples = 0;
/**
+ * The audio stream provided by the browse, if allowed. If no stream has
--- End diff --
:cold_sweat:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request: GUACAMOLE-25: Only stream...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-client/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request: GUACAMOLE-25: Only stream...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/9#discussion_r64326188
--- Diff: guacamole-common-js/src/main/webapp/modules/AudioRecorder.js ---
@@ -213,6 +240,14 @@ Guacamole.RawAudioRecorder = function RawAudioRecorder(stream, mimetype) {
var writtenSamples = 0;
/**
+ * The audio stream provided by the browse, if allowed. If no stream has
--- End diff --
browser?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---