You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by da...@apache.org on 2026/04/21 21:14:26 UTC

(causeway) branch JDOJPA-281 updated: JDOJPA-281 : saveForReplay sets executeIn to FOREGROUND always

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch JDOJPA-281
in repository https://gitbox.apache.org/repos/asf/causeway.git


The following commit(s) were added to refs/heads/JDOJPA-281 by this push:
     new 40d5f8d6603 JDOJPA-281 : saveForReplay sets executeIn to FOREGROUND always
40d5f8d6603 is described below

commit 40d5f8d66030711b94e6a507b1bc8cfc833b37f8
Author: Dan Haywood <da...@haywood-associates.co.uk>
AuthorDate: Tue Apr 21 22:14:08 2026 +0100

    JDOJPA-281 : saveForReplay sets executeIn to FOREGROUND always
---
 .../commandlog/applib/dom/CommandLogEntryRepositoryAbstract.java        | 2 +-
 .../extensions/commandlog/applib/dom/replay/ReplayableCommand.java      | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/CommandLogEntryRepositoryAbstract.java b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/CommandLogEntryRepositoryAbstract.java
index 998116929c8..d46265d9c29 100644
--- a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/CommandLogEntryRepositoryAbstract.java
+++ b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/CommandLogEntryRepositoryAbstract.java
@@ -371,7 +371,7 @@ public C saveForReplay(final CommandDto commandToReplay) {
         final C entity = factoryService.detachedEntity(commandLogEntryClass);
         entity.init(commandToReplay, ReplayState.PENDING, 0);
         entity.setParentInteractionId(null); // n/a for replay
-        entity.setExecuteIn(null); // to be specified later depending on user action
+        entity.setExecuteIn(ExecuteIn.FOREGROUND);  // only ever replay foreground commands.
 
         persist(entity);
 
diff --git a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommand.java b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommand.java
index 48c044edd67..7469af9060a 100644
--- a/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommand.java
+++ b/extensions/core/commandlog/applib/src/main/java/org/apache/causeway/extensions/commandlog/applib/dom/replay/ReplayableCommand.java
@@ -461,7 +461,6 @@ Try<ReplayableCommand> tryReplayOrRetry() {
         return commandLogEntry()
             .filter(ReplayableCommand::canReplayOrRetryOrMarkForExclusion)
             .map(commandLogEntry->{
-                commandLogEntry.setExecuteIn(ExecuteIn.FOREGROUND);
                 var tryResultBookmark = replayContext.commandExecutorService().executeCommand(
                         InteractionContextPolicy.SWITCH_USER_AND_TIME,
                         commandLogEntry.getCommandDto());