You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "nielsbasjes (via GitHub)" <gi...@apache.org> on 2023/03/24 22:20:21 UTC
[GitHub] [maven-shade-plugin] nielsbasjes opened a new pull request, #183: [MSHADE-440] Reproduce problem in IT.
nielsbasjes opened a new pull request, #183:
URL: https://github.com/apache/maven-shade-plugin/pull/183
This is currently ONLY the reproduction of this problem.
Essentially if your run maven shade with an active profile then in some places within that profile properties are expanded to their full value.
I ran into this because by build was no longer reproducible outside of my machine because in the pom.xml packaged in the project the full path had been expanded.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] [JIRA issue](https://issues.apache.org/jira/browse/MSHADE-440).
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MSHADE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] nielsbasjes commented on pull request #183: [MSHADE-440] Reproduce problem in IT.
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on PR #183:
URL: https://github.com/apache/maven-shade-plugin/pull/183#issuecomment-1483515447
To clarify the problem I have created a reproduction in the form of an IT test for the project.
This reproduction has a 3 elements in 3 places: "outside of any profile", "in an INactive profile", "in an ACTIVE profile".
In some of the places in the active profile the project.basedir is expanded to the full value in the dependency-reduced-pom.xml.
Summary of the lines that are present in the generated DRP in my reproduction:
<prop>CHECK Outside profile ${project.basedir}.</prop>
<prop>CHECK Inside inactive profile ${project.basedir}.</prop>
<prop>CHECK Inside active profile ${project.basedir}.</prop>
<id>CHECK Outside profile ${project.basedir}.</id>
<id>CHECK Inside inactive profile ${project.basedir}.</id>
<id>CHECK Inside active profile /home/runner/work/maven-shade-plugin/maven-shade-plugin/target/it/MSHADE-440-DRP-variables-in-profile.</id>
<testOutputDirectory>CHECK Outside profile ${project.basedir}.</testOutputDirectory>
<testOutputDirectory>CHECK Inside inactive profile ${project.basedir}.</testOutputDirectory>
<testOutputDirectory>CHECK Inside active profile /home/runner/work/maven-shade-plugin/maven-shade-plugin/target/it/MSHADE-440-DRP-variables-in-profile.</testOutputDirectory>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] nielsbasjes closed pull request #183: [MSHADE-440] Reproduce problem in IT.
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes closed pull request #183: [MSHADE-440] Reproduce problem in IT.
URL: https://github.com/apache/maven-shade-plugin/pull/183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] nielsbasjes commented on pull request #183: [MSHADE-440] Reproduce problem in IT.
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on PR #183:
URL: https://github.com/apache/maven-shade-plugin/pull/183#issuecomment-1484110121
This is not a bug in maven-shade-plugin.
This is a bug in maven itself.
https://issues.apache.org/jira/browse/MNG-7750
https://github.com/apache/maven/pull/1075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] nielsbasjes commented on pull request #183: [MSHADE-440] Reproduce problem in IT.
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on PR #183:
URL: https://github.com/apache/maven-shade-plugin/pull/183#issuecomment-1483519272
@hboutemy FYI: The reason why yauaa 7.17.0 was (correctly) classified as not reproducible.
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/nl/basjes/parse/useragent/yauaa/yauaa-parent-7.17.0.buildcompare
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org