You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gilles <gi...@harfang.homelinux.org> on 2017/05/27 18:59:08 UTC
Re: [math] (chore) adding commons.module.name to pom
Hi Rob.
Did you read the comment written above the "componentid" properties?
;-)
[In "commons.osgi.symbolicName", "3" -> "4" would be fine.]
Regards,
Gilles
On Sat, 27 May 2017 14:39:37 +0000 (UTC), chtompki@apache.org wrote:
> Repository: commons-math
> Updated Branches:
> refs/heads/master 4a3727381 -> 673ff98e9
>
>
> (chore) adding commons.module.name to pom
>
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/commons-math/commit/673ff98e
> Tree:
> http://git-wip-us.apache.org/repos/asf/commons-math/tree/673ff98e
> Diff:
> http://git-wip-us.apache.org/repos/asf/commons-math/diff/673ff98e
>
> Branch: refs/heads/master
> Commit: 673ff98e9db0d40a76e98f5e18bb7e516f9a3b0e
> Parents: 4a37273
> Author: Rob Tompkins <ch...@gmail.com>
> Authored: Sat May 27 10:39:31 2017 -0400
> Committer: Rob Tompkins <ch...@gmail.com>
> Committed: Sat May 27 10:39:31 2017 -0400
>
>
> ----------------------------------------------------------------------
> pom.xml | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/commons-math/blob/673ff98e/pom.xml
>
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index b864093..74412a2 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -127,6 +127,11 @@
> <id>evanward</id>
> <email>evanward at apache dot org</email>
> </developer>
> + <developer>
> + <name>Rob Tompkins</name>
> + <id>chtompki</id>
> + <email>chtompki at apache dot org</email>
> + </developer>
> </developers>
> <contributors>
> <contributor>
> @@ -328,9 +333,6 @@
> <name>Mauro Talevi</name>
> </contributor>
> <contributor>
> - <name>Rob Tompkins</name>
> - </contributor>
> - <contributor>
> <name>Radoslav Tsvetkov</name>
> </contributor>
> <contributor>
> @@ -430,7 +432,8 @@
> (see "commons.osgi.symbolicName", below). -->
> <!-- TODO: when releasing 4.0, the properties below need to be
> updated, and
> the 3.x release artifacts need to be put int
> commons.release.3 -->
> - <commons.componentid>math</commons.componentid>
> + <commons.componentid>math4</commons.componentid>
> +
> <commons.module.name>org.apache.commons.math4</commons.module.name>
> <!-- This value must reflect the current name of the base
> package. -->
>
>
> <commons.osgi.symbolicName>org.apache.commons.math3</commons.osgi.symbolicName>
> <!-- do not use snapshot suffix here -->
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [math] (chore) adding commons.module.name to pom
Posted by Rob Tompkins <ch...@gmail.com>.
> On May 27, 2017, at 2:59 PM, Gilles <gi...@harfang.homelinux.org> wrote:
>
> Hi Rob.
>
> Did you read the comment written above the "componentid" properties? ;-)
> [In "commons.osgi.symbolicName", "3" -> "4" would be fine.]
Thanks for that set of eyes, and good point. I wasn’t thinking about that correctly when I was making that change.
If I recall correctly, if you omit “commons.osgi.symbolicName” then the parent pom constructs it using “componentid.” But in this case because we’ve overridden the “commons.osgi.symbolicName” then you’re correct.
Cheers,
-Rob
>
> Regards,
> Gilles
>
> On Sat, 27 May 2017 14:39:37 +0000 (UTC), chtompki@apache.org wrote:
>> Repository: commons-math
>> Updated Branches:
>> refs/heads/master 4a3727381 -> 673ff98e9
>>
>>
>> (chore) adding commons.module.name to pom
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/673ff98e
>> Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/673ff98e
>> Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/673ff98e
>>
>> Branch: refs/heads/master
>> Commit: 673ff98e9db0d40a76e98f5e18bb7e516f9a3b0e
>> Parents: 4a37273
>> Author: Rob Tompkins <ch...@gmail.com>
>> Authored: Sat May 27 10:39:31 2017 -0400
>> Committer: Rob Tompkins <ch...@gmail.com>
>> Committed: Sat May 27 10:39:31 2017 -0400
>>
>> ----------------------------------------------------------------------
>> pom.xml | 11 +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/commons-math/blob/673ff98e/pom.xml
>> ----------------------------------------------------------------------
>> diff --git a/pom.xml b/pom.xml
>> index b864093..74412a2 100644
>> --- a/pom.xml
>> +++ b/pom.xml
>> @@ -127,6 +127,11 @@
>> <id>evanward</id>
>> <email>evanward at apache dot org</email>
>> </developer>
>> + <developer>
>> + <name>Rob Tompkins</name>
>> + <id>chtompki</id>
>> + <email>chtompki at apache dot org</email>
>> + </developer>
>> </developers>
>> <contributors>
>> <contributor>
>> @@ -328,9 +333,6 @@
>> <name>Mauro Talevi</name>
>> </contributor>
>> <contributor>
>> - <name>Rob Tompkins</name>
>> - </contributor>
>> - <contributor>
>> <name>Radoslav Tsvetkov</name>
>> </contributor>
>> <contributor>
>> @@ -430,7 +432,8 @@
>> (see "commons.osgi.symbolicName", below). -->
>> <!-- TODO: when releasing 4.0, the properties below need to be
>> updated, and
>> the 3.x release artifacts need to be put int commons.release.3 -->
>> - <commons.componentid>math</commons.componentid>
>> + <commons.componentid>math4</commons.componentid>
>> + <commons.module.name>org.apache.commons.math4</commons.module.name>
>> <!-- This value must reflect the current name of the base package. -->
>>
>> <commons.osgi.symbolicName>org.apache.commons.math3</commons.osgi.symbolicName>
>> <!-- do not use snapshot suffix here -->
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org