You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by kohlmu-pivotal <gi...@git.apache.org> on 2017/08/24 19:55:49 UTC
[GitHub] geode pull request #742: GEODE-3473: Initial commit of the internal package ...
GitHub user kohlmu-pivotal opened a pull request:
https://github.com/apache/geode/pull/742
GEODE-3473: Initial commit of the internal package renaming refactor.
Changing the protobuf file refactor first.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/geode feature/GEODE-3473
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/742.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #742
----
commit acc9cebcb996da8413e9bfd47cc0bf20976ebf23
Author: Udo Kohlmeyer <uk...@pivotal.io>
Date: 2017-08-24T19:54:38Z
GEODE-3473: Initial commit of the internal package renaming refactor.
Changing the protobuf file refactor first.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #742: GEODE-3473: Initial commit of the internal package renamin...
Posted by kohlmu-pivotal <gi...@git.apache.org>.
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/742
@galen-pivotal @bschuchardt @pivotal-amurmann @WireBaron @hiteshk25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #742: GEODE-3473: Initial commit of the internal package renamin...
Posted by kohlmu-pivotal <gi...@git.apache.org>.
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/742
@pivotal-amurmann no files should have been moved. Only class import locations have changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #742: GEODE-3473: Initial commit of the internal package ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #742: GEODE-3473: Initial commit of the internal package renamin...
Posted by pivotal-amurmann <gi...@git.apache.org>.
Github user pivotal-amurmann commented on the issue:
https://github.com/apache/geode/pull/742
This looks good. However, I'd like to understand what the plan is for moving the files to the location suggested by the package name/path. Maybe the Commit message could clarify that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---