You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Tsukikage7 (via GitHub)" <gi...@apache.org> on 2026/01/08 08:04:43 UTC
[PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Tsukikage7 opened a new pull request, #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856
## What this PR does
This PR unifies the IDL definitions and modernizes the API in `tools/benchmark` module.
Closes #835
## Background
The benchmark module previously had three separate IDL definitions:
- `api/samples_api.proto` - for Triple protocol with `Greeter` service
- `protocol/grpc/proto/hello_grpc.proto` - for gRPC protocol with `UserProvider` service
- Go structs with Hessian serialization - for Dubbo protocol
This inconsistency made it difficult to compare performance across protocols fairly.
## Changes
### Unified IDL Definition
Created a single `benchmark.proto` defining `BenchmarkService` with consistent message types:
```protobuf
service BenchmarkService {
rpc GetUser(GetUserRequest) returns (GetUsersResponse);
rpc GetUsers(GetUsersRequest) returns (GetUsersResponse);
rpc GetUserByName(GetUserByNameRequest) returns (GetUsersResponse);
rpc SayHello(HelloRequest) returns (HelloResponse);
}
```
### Protocol-Specific Stubs
- **Triple**: Stubs generated in `api/` using `protoc-gen-go-triple/v3` (new programmatic API)
- **gRPC**: Stubs generated in `api/grpcstub/` using standard `protoc-gen-go-grpc`
- **Dubbo**: Continues to use Hessian serialization with updated provider implementation
### Server Implementations Updated
| Protocol | Changes |
|----------|---------|
| gRPC | Uses `grpcstub.BenchmarkServiceServer` with standard `google.golang.org/grpc` |
| Triple | Uses new dubbo-go v3 programmatic API (`server.NewServer()` + `RegisterBenchmarkServiceHandler()`) |
| Dubbo | Cleaned up `UserProvider` with simplified structure |
### Triple Protocol Modernization
Migrated from config-based API to new dubbo-go v3 programmatic API:
**Server (before)**:
```go
config.SetProviderService(&pkg.BenchmarkProvider{})
config.Load()
```
**Server (after)**:
```go
srv, _ := server.NewServer(
server.WithServerProtocol(
protocol.WithPort(20000),
protocol.WithTriple(),
),
)
api.RegisterBenchmarkServiceHandler(srv, pkg.NewBenchmarkProvider())
srv.Serve()
```
**Client (before)**:
```go
config.SetConsumerService(grpcBenchmarkService)
config.Load()
```
**Client (after)**:
```go
cli, _ := client.NewClient(client.WithClientURL("tri://127.0.0.1:20000"))
benchmarkService, _ := api.NewBenchmarkService(cli)
```
### Dependencies
- Upgraded `google.golang.org/grpc` to v1.78.0
- Updated `dubbo.apache.org/dubbo-go/v3` to v3.3.1
### Removed Files
- `api/samples_api.proto` and generated files
- `protocol/grpc/proto/hello_grpc.proto` and generated files
## Benchmark Results
Test environment: macOS, Apple Silicon, N=500 samples per method
### gRPC Protocol (Direct)
| Method | Min | Median | Mean | StdDev | Max |
|--------|-----|--------|------|--------|-----|
| GetUser | 100µs | 200µs | 400µs | 1.1ms | 8.2ms |
| GetUsers | 100µs | 200µs | 200µs | 100µs | 400µs |
| GetUserByName | 100µs | 200µs | 200µs | 100µs | 600µs |
| SayHello | 100µs | 200µs | 200µs | 100µs | 400µs |
### gRPC via Pixiu
| Method | Min | Median | Mean | StdDev | Max |
|--------|-----|--------|------|--------|-----|
| GetUser | 600µs | 1.4ms | 1.8ms | 1.8ms | 12.7ms |
| GetUsers | 500µs | 1.4ms | 1.7ms | 1.2ms | 14.6ms |
| GetUserByName | 500µs | 1.3ms | 2ms | 2ms | 17.1ms |
| SayHello | 600µs | 1.3ms | 1.8ms | 2ms | 32.8ms |
### Triple Protocol (Direct)
| Method | Min | Median | Mean | StdDev | Max |
|--------|-----|--------|------|--------|-----|
| GetUser | 200µs | 1.8ms | 2.5ms | 2.4ms | 14.5ms |
| SayHello | 200µs | 900µs | 1.4ms | 1.3ms | 12.5ms |
### Triple via Pixiu
| Method | Min | Median | Mean | StdDev | Max |
|--------|-----|--------|------|--------|-----|
| GetUser | 1ms | 2.1ms | 2.8ms | 3.1ms | 24.4ms |
| SayHello | 700µs | 2ms | 2.5ms | 1.4ms | 12ms |
### Dubbo via Pixiu
| Method | Min | Median | Mean | StdDev | Max |
|--------|-----|--------|------|--------|-----|
| GetUser | 700µs | 2ms | 3ms | 5.9ms | 44.7ms |
| GetGender | 300µs | 800µs | 1ms | 500µs | 3.1ms |
| GetUser0 | 300µs | 700µs | 800µs | 500µs | 4.2ms |
| GetUsers | 100µs | 500µs | 600µs | 400µs | 3.2ms |
### Summary
Pixiu proxy adds approximately 0.3-1.1ms overhead compared to direct protocol calls. Performance comparison (median latency):
| Protocol | Direct | via Pixiu | Overhead |
|----------|--------|-----------|----------|
| gRPC | ~200µs | ~1.3ms | ~1.1ms |
| Triple | ~1.4ms | ~2ms | ~0.6ms |
| Dubbo | - | ~700µs | - |
## How to verify
```bash
cd tools/benchmark
# Build all packages
go build ./...
# Run import formatter
cd ../.. && make import-format
# Run tests (requires local environment setup)
go test ./test/...
```
## Checklist
- [x] Code compiles correctly
- [x] Passes `make import-format`
- [x] Updated `generate.sh` for code generation
- [x] All three protocol servers use unified service definition
- [x] Test files updated to use new API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3731841887
@Similarityoung @nanjiek check this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "Tsukikage7 (via GitHub)" <gi...@apache.org>.
Tsukikage7 commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3789617068
> Wouldn't it be better if the contents of tools/benchmark/protocol/triple/pb could be put into tools/benchmark/protocol/triple, after all, the proto file is in a separate folder
Good suggestion! I've moved go-server and pixiu from protocol/triple/pb/ to protocol/triple/
to keep the directory structure consistent with other protocols (grpc, dubbo, dubbo-direct).
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3802712861
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856) **Quality Gate passed**
Issues
 [32 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_coverage&view=list)
 [49.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3727855262
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856) **Quality Gate passed**
Issues
 [43 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_coverage&view=list)
 [52.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3727932852
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/856?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 19.69%. Comparing base ([`4d9a422`](https://app.codecov.io/gh/apache/dubbo-go-pixiu/commit/4d9a42295d4133e6c551aadaaceec8a88a4c51c9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`dde725f`](https://app.codecov.io/gh/apache/dubbo-go-pixiu/commit/dde725fc85dda384106c96b6e74046b90b3f3411?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #856 +/- ##
========================================
Coverage 19.69% 19.69%
========================================
Files 255 255
Lines 18360 18360
========================================
Hits 3616 3616
Misses 14377 14377
Partials 367 367
```
| [Flag](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/856/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [unittests](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/856/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `19.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/856?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3794008704
please fix the ci failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "Tsukikage7 (via GitHub)" <gi...@apache.org>.
Tsukikage7 commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3789646637
> 1. what's the difference between the proto file in `tools/benchmark/api/grpcstub/benchmark.proto` and the proto file in `tools/benchmark/api/benchmark.proto` can't we use the same proto file?
> 2. why dubbo direct has 6 interfaces? why not delete `GetUser2` and `GetErr`?
Thanks for the suggestions!
1. Proto file: Removed the duplicate grpcstub/benchmark.proto. Now both gRPC and Triple stubs
are generated from a single api/benchmark.proto using protoc's --go_opt=M... flag.
2. Dubbo interfaces: Removed GetUser2, GetUser3, GetErr and other redundant methods. Now
dubbo keeps only 4 core interfaces (GetUser, GetUser0, GetUsers, GetGender), aligned with the
benchmark purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "Similarityoung (via GitHub)" <gi...@apache.org>.
Similarityoung commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3731848027
Wouldn't it be better if the contents of tools/benchmark/protocol/triple/pb could be put into tools/benchmark/protocol/triple, after all, the proto file is in a separate folder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3789607818
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856) **Quality Gate passed**
Issues
 [32 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_coverage&view=list)
 [49.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3722634304
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856) **Quality Gate passed**
Issues
 [39 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_coverage&view=list)
 [51.9% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3727885267
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856) **Quality Gate passed**
Issues
 [42 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_coverage&view=list)
 [52.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3726996938
pls don't forget import-format before commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl merged PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3727871221
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856) **Quality Gate passed**
Issues
 [43 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_coverage&view=list)
 [52.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(benchmark): unify IDL definitions and modernize to dubbo-go v3 A… [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3789645271
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856) **Quality Gate passed**
Issues
 [32 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=856&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_coverage&view=list)
 [49.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=856&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=856)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org